iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
870b6a15619c48cf1fcd5dd8c97d87b069501bbb
linux/net/sched
History
Toke Høiland-Jørgensen 870b6a1561 sch_cake: Return __NET_XMIT_STOLEN when consuming enqueued skb 
[ Upstream commit 90fabae8a2 ]

When the GSO splitting feature of sch_cake is enabled, GSO superpackets
will be broken up and the resulting segments enqueued in place of the
original skb. In this case, CAKE calls consume_skb() on the original skb,
but still returns NET_XMIT_SUCCESS. This can confuse parent qdiscs into
assuming the original skb still exists, when it really has been freed. Fix
this by adding the __NET_XMIT_STOLEN flag to the return value in this case.

Fixes: 0c850344d3 ("sch_cake: Conditionally split GSO segments")
Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
Reported-by: zdi-disclosures@trendmicro.com # ZDI-CAN-18231
Link: https://lore.kernel.org/r/20220831092103.442868-1-toke@toke.dk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-09-08 11:11:37 +02:00
..
act_api.c
net/sched: act_api: Notify user space if any actions were flushed before error
2022-07-07 17:52:18 +02:00
act_bpf.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_connmark.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_csum.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_ct.c
net/sched: act_ct: Fix flow table lookup after ct clear or switching zones
2022-03-02 11:42:50 +01:00
act_ctinfo.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-10-05 18:40:01 -07:00
act_gact.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_gate.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-10-05 18:40:01 -07:00
act_ife.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_ipt.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_meta_mark.c
…
act_meta_skbprio.c
…
act_meta_skbtcindex.c
…
act_mirred.c
net: sched: act_mirred: drop dst for the direction from egress to ingress
2021-11-26 10:39:16 +01:00
act_mpls.c
net/sched: act_mpls: ensure LSE is pullable before reading it
2020-12-03 11:13:37 -08:00
act_nat.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_pedit.c
net/sched: act_pedit: sanitize shift argument before usage
2022-05-25 09:17:58 +02:00
act_police.c
net/sched: act_police: more accurate MTU policing
2022-06-22 14:13:20 +02:00
act_sample.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_simple.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_skbedit.c
net_sched: defer tcf_idr_insert() in tcf_action_init_1()
2020-09-24 19:46:21 -07:00
act_skbmod.c
net/sched: act_skbmod: Skip non-Ethernet packets
2021-07-28 14:35:40 +02:00
act_tunnel_key.c
net/sched: act_tunnel_key: fix OOB write in case of IPv6 ERSPAN tunnels
2020-10-20 21:10:41 -07:00
act_vlan.c
net/sched: act_vlan: Fix modify to allow 0
2021-07-14 16:56:19 +02:00
cls_api.c
net/sched: fix initialization order when updating chain 0 head
2022-04-20 09:23:12 +02:00
cls_basic.c
…
cls_bpf.c
…
cls_cgroup.c
…
cls_flow.c
Merge tag 'uninit-macro-v5.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
2020-08-04 13:49:43 -07:00
cls_flower.c
net/sched: flower: fix parsing of ethertype following VLAN header
2022-04-20 09:23:11 +02:00
cls_fw.c
…
cls_matchall.c
net: qos offload add flow status with dropped count
2020-06-19 12:53:30 -07:00
cls_route.c
net_sched: cls_route: disallow handle of 0
2022-08-21 15:16:26 +02:00
cls_rsvp6.c
…
cls_rsvp.c
…
cls_rsvp.h
…
cls_tcindex.c
net: sched: fix memory leak in tcindex_partial_destroy_work
2021-07-28 14:35:38 +02:00
cls_u32.c
net/sched: cls_u32: fix possible leak in u32_init_knode()
2022-04-27 13:53:50 +02:00
em_canid.c
net: sched: kerneldoc fixes
2020-07-13 17:20:40 -07:00
em_cmp.c
…
em_ipset.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-03 14:34:53 -07:00
em_ipt.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-03 14:34:53 -07:00
em_meta.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-03 14:34:53 -07:00
em_nbyte.c
net: sched: Replace zero-length array with flexible-array member
2020-02-29 21:27:02 -08:00
em_text.c
…
em_u32.c
…
ematch.c
net: sched: kerneldoc fixes
2020-07-13 17:20:40 -07:00
Kconfig
net: sched: incorrect Kconfig dependencies on Netfilter modules
2021-02-23 15:53:23 +01:00
Makefile
net: qos: introduce a gate control flow action
2020-05-01 16:08:19 -07:00
sch_api.c
net_sched: add __rcu annotation to netdev->qdisc
2022-02-23 12:01:02 +01:00
sch_atm.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_blackhole.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_cake.c
sch_cake: Return __NET_XMIT_STOLEN when consuming enqueued skb
2022-09-08 11:11:37 +02:00
sch_cbq.c
net: sched: Fix qdisc_rate_table refcount leak when get tcf_block failed
2021-09-15 09:50:45 +02:00
sch_cbs.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_choke.c
net: sched: validate stab values
2021-03-30 14:31:57 +02:00
sch_codel.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_drr.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_dsmark.c
sch_dsmark: fix a NULL deref in qdisc_reset()
2021-06-03 09:00:50 +02:00
sch_etf.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_ets.c
net/sched: sch_ets: don't remove idle classes from the round-robin list
2021-12-22 09:30:54 +01:00
sch_fifo.c
net_sched: fix NULL deref in fifo_set_limit()
2021-10-13 10:04:26 +02:00
sch_fq_codel.c
fq_codel: reject silly quantum parameters
2021-09-22 12:28:05 +02:00
sch_fq_pie.c
net/sched: fq_pie: prevent dismantle issue
2021-12-14 11:32:37 +01:00
sch_fq.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_generic.c
net/sched: fix netdevice reference leaks in attach_default_qdiscs()
2022-09-08 11:11:36 +02:00
sch_gred.c
net: sched: validate stab values
2021-03-30 14:31:57 +02:00
sch_hfsc.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
2020-08-05 20:13:21 -07:00
sch_hhf.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_htb.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
2020-08-05 20:13:21 -07:00
sch_ingress.c
net: sched: Pass ingress block to tcf_classify_ingress
2020-02-19 17:49:48 -08:00
sch_mq.c
net: sched: update default qdisc visibility after Tx queue cnt changes
2021-11-18 14:03:53 +01:00
sch_mqprio.c
net: sched: update default qdisc visibility after Tx queue cnt changes
2021-11-18 14:03:53 +01:00
sch_multiq.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_netem.c
net/sched: sch_netem: Fix arithmetic in netem_dump() for 32-bit platforms
2022-06-29 08:59:47 +02:00
sch_pie.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_plug.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_prio.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_qfq.c
sch_qfq: prevent shift-out-of-bounds in qfq_init_qdisc
2022-01-11 15:25:00 +01:00
sch_red.c
net: sched: validate stab values
2021-03-30 14:31:57 +02:00
sch_sfb.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_sfq.c
net: sched: validate stab values
2021-03-30 14:31:57 +02:00
sch_skbprio.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_taprio.c
net/sched: taprio: Check if socket flags are valid
2022-04-20 09:23:13 +02:00
sch_tbf.c
net: sched: tbf: don't call qdisc_put() while holding tree lock
2022-09-08 11:11:36 +02:00
sch_teql.c
net: sched: sch_teql: fix null-pointer dereference
2021-04-14 08:42:02 +02:00