iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/bluetooth
History
Schspa Shi 877afadad2 Bluetooth: When HCI work queue is drained, only queue chained work 
The HCI command, event, and data packet processing workqueue is drained
to avoid deadlock in commit
76727c02c1e1 ("Bluetooth: Call drain_workqueue() before resetting state").

There is another delayed work, which will queue command to this drained
workqueue. Which results in the following error report:

Bluetooth: hci2: command 0x040f tx timeout
WARNING: CPU: 1 PID: 18374 at kernel/workqueue.c:1438 __queue_work+0xdad/0x1140
Workqueue: events hci_cmd_timeout
RIP: 0010:__queue_work+0xdad/0x1140
RSP: 0000:ffffc90002cffc60 EFLAGS: 00010093
RAX: 0000000000000000 RBX: ffff8880b9d3ec00 RCX: 0000000000000000
RDX: ffff888024ba0000 RSI: ffffffff814e048d RDI: ffff8880b9d3ec08
RBP: 0000000000000008 R08: 0000000000000000 R09: 00000000b9d39700
R10: ffffffff814f73c6 R11: 0000000000000000 R12: ffff88807cce4c60
R13: 0000000000000000 R14: ffff8880796d8800 R15: ffff8880796d8800
FS:  0000000000000000(0000) GS:ffff8880b9d00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000000c0174b4000 CR3: 000000007cae9000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 ? queue_work_on+0xcb/0x110
 ? lockdep_hardirqs_off+0x90/0xd0
 queue_work_on+0xee/0x110
 process_one_work+0x996/0x1610
 ? pwq_dec_nr_in_flight+0x2a0/0x2a0
 ? rwlock_bug.part.0+0x90/0x90
 ? _raw_spin_lock_irq+0x41/0x50
 worker_thread+0x665/0x1080
 ? process_one_work+0x1610/0x1610
 kthread+0x2e9/0x3a0
 ? kthread_complete_and_exit+0x40/0x40
 ret_from_fork+0x1f/0x30
 </TASK>

To fix this, we can add a new HCI_DRAIN_WQ flag, and don't queue the
timeout workqueue while command workqueue is draining.

Fixes: 76727c02c1e1 ("Bluetooth: Call drain_workqueue() before resetting state")
Reported-by: syzbot+63bed493aebbf6872647@syzkaller.appspotmail.com
Signed-off-by: Schspa Shi <schspa@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
2022-07-21 17:05:22 -07:00
..
bnep
bluetooth: Use netif_rx().
2022-03-07 11:40:41 +00:00
cmtp
Merge branch 'signal-for-v5.17' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace
2022-01-17 05:49:30 +02:00
hidp
Merge branch 'signal-for-v5.17' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace
2022-01-17 05:49:30 +02:00
rfcomm
bluetooth-next pull request for net-next:
2021-10-05 07:41:16 -07:00
6lowpan.c
bluetooth: Use netif_rx().
2022-03-07 11:40:41 +00:00
a2mp.c
Bluetooth: a2mp: Use the correct print format
2021-06-26 07:12:41 +02:00
a2mp.h
Bluetooth: Replace zero-length array with flexible-array member
2020-02-28 08:30:02 +01:00
af_bluetooth.c
net: SO_RCVMARK socket option for SO_MARK with recvmsg()
2022-04-28 13:08:15 -07:00
amp.c
Bluetooth: amp: Use the correct print format
2021-06-26 07:12:41 +02:00
amp.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 284
2019-06-05 17:36:37 +02:00
aosp.c
Bluetooth: aosp: Support AOSP Bluetooth Quality Report
2021-11-02 19:37:52 +01:00
aosp.h
Bluetooth: aosp: Support AOSP Bluetooth Quality Report
2021-11-02 19:37:52 +01:00
ecdh_helper.c
crypto: ecdh - move curve_id of ECDH from the key to algorithm name
2021-03-13 00:04:03 +11:00
ecdh_helper.h
Fix misc new gcc warnings
2021-04-27 17:05:53 -07:00
eir.c
Bluetooth: eir: Add helpers for managing service data
2022-05-19 20:11:26 +02:00
eir.h
Bluetooth: eir: Add helpers for managing service data
2022-05-19 20:11:26 +02:00
hci_codec.c
Bluetooth: Read codec capabilities only if supported
2021-10-07 17:57:22 +02:00
hci_codec.h
Bluetooth: Add support for Read Local Supported Codecs V2
2021-09-07 14:09:18 -07:00
hci_conn.c
Bluetooth: clear the temporary linkkey in hci_conn_cleanup
2022-07-21 17:04:53 -07:00
hci_core.c
Bluetooth: When HCI work queue is drained, only queue chained work
2022-07-21 17:05:22 -07:00
hci_debugfs.c
Bluetooth: hci_core: Move all debugfs handling to hci_debugfs.c
2021-09-22 16:17:13 +02:00
hci_debugfs.h
Bluetooth: hci_core: Move all debugfs handling to hci_debugfs.c
2021-09-22 16:17:13 +02:00
hci_event.c
Bluetooth: When HCI work queue is drained, only queue chained work
2022-07-21 17:05:22 -07:00
hci_request.c
bluetooth: don't use bitmaps for random flag accesses
2022-06-05 16:28:41 -07:00
hci_request.h
Bluetooth: hci_sync: Add hci_le_create_conn_sync
2021-12-22 23:01:35 +01:00
hci_sock.c
net: remove noblock parameter from skb_recv_datagram()
2022-04-06 13:45:26 +01:00
hci_sync.c
Bluetooth: core: Fix deadlock on hci_power_on_sync.
2022-07-05 13:20:03 -07:00
hci_sysfs.c
Bluetooth: Fix memory leak of hci device
2021-10-13 14:31:50 +02:00
Kconfig
Bluetooth: Add support for reading AOSP vendor capabilities
2021-04-06 14:11:23 -07:00
l2cap_core.c
Bluetooth: Don't assign twice the same value
2022-03-18 17:12:08 +01:00
l2cap_sock.c
Bluetooth: L2CAP: uninitialized variables in l2cap_sock_setsockopt()
2022-01-07 08:40:11 +01:00
leds.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
leds.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
lib.c
Bluetooth: Introduce debug feature when dynamic debug is disabled
2020-05-11 12:16:27 +02:00
Makefile
Bluetooth: Add helper for serialized HCI command execution
2021-10-29 16:51:58 +02:00
mgmt_config.c
Bluetooth: mgmt: Use the correct print format
2021-06-26 07:12:42 +02:00
mgmt_config.h
Bluetooth: mgmt: Add commands for runtime configuration
2020-06-18 13:11:03 +03:00
mgmt_util.c
Bluetooth: Keep MGMT pending queue ordered FIFO
2022-05-13 13:05:48 +02:00
mgmt_util.h
Bluetooth: mgmt: Introduce mgmt_alloc_skb and mgmt_send_event_skb
2021-12-07 17:05:52 +01:00
mgmt.c
bluetooth: don't use bitmaps for random flag accesses
2022-06-05 16:28:41 -07:00
msft.c
Bluetooth: msft: Clear tracked devices on resume
2022-03-18 17:12:08 +01:00
msft.h
Bluetooth: msft: Fix compilation when CONFIG_BT_MSFTEXT is not set
2021-12-07 17:05:51 +01:00
sco.c
Bluetooth: HCI: Add HCI_QUIRK_BROKEN_ENHANCED_SETUP_SYNC_CONN quirk
2022-05-13 13:05:48 +02:00
selftest.c
crypto: ecdh - move curve_id of ECDH from the key to algorithm name
2021-03-13 00:04:03 +11:00
selftest.h
…
smp.c
Bluetooth: use inclusive language in HCI role comments
2021-06-26 07:12:43 +02:00
smp.h
Bluetooth: use inclusive language in SMP
2021-06-26 07:12:37 +02:00