linux/drivers/staging/comedi
Ian Abbott 56c90457eb staging: comedi: mf6x4: Fix AI end-of-conversion detection
I have had reports from two different people that attempts to read the
analog input channels of the MF624 board fail with an `ETIMEDOUT` error.

After triggering the conversion, the code calls `comedi_timeout()` with
`mf6x4_ai_eoc()` as the callback function to check if the conversion is
complete.  The callback returns 0 if complete or `-EBUSY` if not yet
complete.  `comedi_timeout()` returns `-ETIMEDOUT` if it has not
completed within a timeout period which is propagated as an error to the
user application.

The existing code considers the conversion to be complete when the EOLC
bit is high.  However, according to the user manuals for the MF624 and
MF634 boards, this test is incorrect because EOLC is an active low
signal that goes high when the conversion is triggered, and goes low
when the conversion is complete.  Fix the problem by inverting the test
of the EOLC bit state.

Fixes: 04b565021a ("comedi: Humusoft MF634 and MF624 DAQ cards driver")
Cc: <stable@vger.kernel.org> # v4.4+
Cc: Rostislav Lisovy <lisovy@gmail.com>
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Link: https://lore.kernel.org/r/20201207145806.4046-1-abbotti@mev.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-12-09 15:49:13 +01:00
..
drivers staging: comedi: mf6x4: Fix AI end-of-conversion detection 2020-12-09 15:49:13 +01:00
kcomedilib staging: add missing SPDX lines to Makefile files 2019-04-03 11:10:15 +02:00
comedi_buf.c staging: comedi: use dma_mmap_coherent for DMA-able buffer mmap 2019-06-26 09:32:13 +08:00
comedi_fops.c staging: comedi: Replace HTTP links with HTTPS ones 2020-07-25 15:27:24 +02:00
comedi_internal.h Staging/IIO driver patches for 5.8-rc1 2020-06-07 10:45:08 -07:00
comedi_pci.c staging: comedi: Replace HTTP links with HTTPS ones 2020-07-25 15:27:24 +02:00
comedi_pci.h
comedi_pcmcia.c staging: comedi: Replace HTTP links with HTTPS ones 2020-07-25 15:27:24 +02:00
comedi_pcmcia.h
comedi_usb.c staging: comedi: Replace HTTP links with HTTPS ones 2020-07-25 15:27:24 +02:00
comedi_usb.h
comedi.h drivers: staging: comedi: fixed duplicate words from checkpatch 2020-08-28 12:19:16 +02:00
comedidev.h drivers: staging: comedi: fixed duplicate words from checkpatch 2020-08-28 12:19:16 +02:00
comedilib.h
drivers.c staging: comedi: Add lockdep_assert_held() calls for dev->attach_lock 2019-04-19 14:33:41 +02:00
Kconfig staging: comedi: use help instead of ---help--- in Kconfig 2019-04-19 15:01:50 +02:00
Makefile comedi: move compat ioctl handling to native fops 2020-05-28 20:29:17 -04:00
proc.c
range.c comedi: get rid of compat_alloc_user_space() mess in COMEDI_RANGEINFO compat 2020-05-28 20:31:19 -04:00
TODO