iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/core
History
YueHaibing 895a5e96db net-sysfs: Fix mem leak in netdev_register_kobject 
syzkaller report this:
BUG: memory leak
unreferenced object 0xffff88837a71a500 (size 256):
  comm "syz-executor.2", pid 9770, jiffies 4297825125 (age 17.843s)
  hex dump (first 32 bytes):
    00 00 00 00 ad 4e ad de ff ff ff ff 00 00 00 00  .....N..........
    ff ff ff ff ff ff ff ff 20 c0 ef 86 ff ff ff ff  ........ .......
  backtrace:
    [<00000000db12624b>] netdev_register_kobject+0x124/0x2e0 net/core/net-sysfs.c:1751
    [<00000000dc49a994>] register_netdevice+0xcc1/0x1270 net/core/dev.c:8516
    [<00000000e5f3fea0>] tun_set_iff drivers/net/tun.c:2649 [inline]
    [<00000000e5f3fea0>] __tun_chr_ioctl+0x2218/0x3d20 drivers/net/tun.c:2883
    [<000000001b8ac127>] vfs_ioctl fs/ioctl.c:46 [inline]
    [<000000001b8ac127>] do_vfs_ioctl+0x1a5/0x10e0 fs/ioctl.c:690
    [<0000000079b269f8>] ksys_ioctl+0x89/0xa0 fs/ioctl.c:705
    [<00000000de649beb>] __do_sys_ioctl fs/ioctl.c:712 [inline]
    [<00000000de649beb>] __se_sys_ioctl fs/ioctl.c:710 [inline]
    [<00000000de649beb>] __x64_sys_ioctl+0x74/0xb0 fs/ioctl.c:710
    [<000000007ebded1e>] do_syscall_64+0xc8/0x580 arch/x86/entry/common.c:290
    [<00000000db315d36>] entry_SYSCALL_64_after_hwframe+0x49/0xbe
    [<00000000115be9bb>] 0xffffffffffffffff

It should call kset_unregister to free 'dev->queues_kset'
in error path of register_queue_kobjects, otherwise will cause a mem leak.

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 1d24eb4815d1 ("xps: Transmit Packet Steering")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-03-03 21:10:57 -08:00
..
datagram.c
for-4.21/block-20181221
2018-12-28 13:19:59 -08:00
dev_addr_lists.c
net: dev: Issue NETDEV_PRE_CHANGEADDR
2018-12-13 18:41:38 -08:00
dev_ioctl.c
net: dev: Add extack argument to dev_set_mac_address()
2018-12-13 18:41:38 -08:00
dev.c
net: Fix for_each_netdev_feature on Big endian
2019-02-15 20:23:50 -08:00
devlink.c
devlink: Add 'fw_load_policy' generic parameter
2018-12-03 13:55:43 -08:00
drop_monitor.c
treewide: setup_timer() -> timer_setup()
2017-11-21 15:57:07 -08:00
dst_cache.c
net: core: dst_cache_set_ip6: Rename 'addr' parameter to 'saddr' for consistency
2018-03-05 12:52:45 -05:00
dst.c
netfilter: nf_tables: add tunnel support
2018-08-03 21:12:12 +02:00
ethtool.c
ethtool: check the return value of get_regs_len
2018-12-28 21:24:56 -08:00
failover.c
net: Introduce generic failover module
2018-05-28 22:59:54 -04:00
fib_notifier.c
net: Fix fib notifer to return errno
2018-03-29 14:10:30 -04:00
fib_rules.c
net/fib_rules: Update fib_nl_dumprule for strict data checking
2018-10-08 10:39:05 -07:00
filter.c
bpf: only adjust gso_size on bytestream protocols
2019-02-10 19:57:34 -08:00
flow_dissector.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2018-12-20 11:53:36 -08:00
gen_estimator.c
net: core: protect rate estimator statistics pointer with lock
2018-08-11 12:37:10 -07:00
gen_stats.c
net: sched: put back q.qlen into a single location
2019-03-02 14:10:18 -08:00
gro_cells.c
gro_cell: add napi_disable in gro_cells_destroy
2018-12-19 15:50:02 -08:00
hwbm.c
…
link_watch.c
net: linkwatch: add check for netdevice being present to linkwatch_do_dev
2018-09-19 21:06:46 -07:00
lwt_bpf.c
bpf: in __bpf_redirect_no_mac pull mac only if present
2019-01-20 01:11:48 +01:00
lwtunnel.c
ipv6: sr: define core operations for seg6local lightweight tunnel
2017-08-07 14:16:22 -07:00
Makefile
bpf, sockmap: convert to generic sk_msg interface
2018-10-15 12:23:19 -07:00
neighbour.c
neighbour: Do not perturb drop profiles when neigh_probe
2019-01-17 22:08:14 -08:00
net_namespace.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2018-12-24 16:19:56 -08:00
net-procfs.c
proc: introduce proc_create_net{,_data}
2018-05-16 07:24:30 +02:00
net-sysfs.c
net-sysfs: Fix mem leak in netdev_register_kobject
2019-03-03 21:10:57 -08:00
net-sysfs.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
net-traces.c
net/ipv6: Udate fib6_table_lookup tracepoint
2018-05-24 23:01:15 -04:00
netclassid_cgroup.c
cgroup, netclassid: add a preemption point to write_classid
2018-10-23 12:58:17 -07:00
netevent.c
…
netpoll.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
2018-12-27 13:04:52 -08:00
netprio_cgroup.c
net: remove duplicate includes
2017-12-13 13:18:46 -05:00
page_pool.c
net/page_pool: Fix inconsistent lock state warning
2018-07-19 23:23:01 -07:00
pktgen.c
pktgen: Fix fall-through annotation
2018-09-13 15:36:41 -07:00
ptp_classifier.c
…
request_sock.c
…
rtnetlink.c
net: rtnetlink: address is mandatory for rtnl_fdb_get
2018-12-30 11:35:36 -08:00
scm.c
sched/headers: Prepare for new header dependencies before moving code to <linux/sched/user.h>
2017-03-02 08:42:29 +01:00
secure_seq.c
infiniband: i40iw, nes: don't use wall time for TCP sequence numbers
2018-07-11 12:10:19 -06:00
skbuff.c
net: Do not allocate page fragments that are not skb aligned
2019-02-17 15:48:43 -08:00
skmsg.c
sk_msg: Always cancel strp work before freeing the psock
2019-01-29 00:05:03 +01:00
sock_diag.c
net: sock_diag: Fix spectre v1 gadget in __sock_diag_cmd()
2018-08-14 10:01:24 -07:00
sock_map.c
bpf: skmsg, fix psock create on existing kcm/tls port
2018-10-20 00:40:45 +02:00
sock_reuseport.c
sctp: add sock_reuseport for the sock in __sctp_hash_endpoint
2018-11-12 09:09:51 -08:00
sock.c
net: fix possible overflow in __sk_mem_raise_allocated()
2019-02-13 21:05:18 -08:00
stream.c
tcp: reduce POLLOUT events caused by TCP_NOTSENT_LOWAT
2018-12-04 21:21:18 -08:00
sysctl_net_core.c
bpf: fix bpf_jit_limit knob for PAGE_SIZE >= 64K
2018-12-11 19:12:21 -08:00
timestamping.c
…
tso.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
utils.c
net: Remove some unneeded semicolon
2018-08-04 13:05:39 -07:00
xdp.c
xdp: remove redundant variable 'headroom'
2018-09-01 01:35:53 +02:00