Julian Wiedmann f9e50b02a9 s390/qeth: fix dangling IO buffers after halt/clear ... The cio layer's intparm logic does not align itself well with how qeth manages cmd IOs. When an active IO gets terminated via halt/clear, the corresponding IRQ's intparm does not reflect the cmd buffer but rather the intparm that was passed to ccw_device_halt() / ccw_device_clear(). This behaviour was recently clarified in commit b91d9e67e5 ("s390/cio: fix intparm documentation"). As a result, qeth_irq() currently doesn't cancel a cmd that was terminated via halt/clear. This primarily causes us to leak card->read_cmd after the qeth device is removed, since our IO path still holds a refcount for this cmd. For qeth this means that we need to keep track of which IO is pending on a device ('active_cmd'), and use this as the intparm when calling halt/clear. Otherwise qeth_irq() can't match the subsequent IRQ to its cmd buffer. Since we now keep track of the _expected_ intparm, we can also detect any mismatch; this would constitute a bug somewhere in the lower layers. In this case cancel the active cmd - we effectively "lost" the IRQ and should not expect any further notification for this IO. Fixes: 405548959c ("s390/qeth: add support for dynamically allocated cmds") Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-12-05 12:25:05 -08:00
..
block	block: remove (__)blkdev_reread_part as an exported API	2019-11-14 07:43:59 -07:00
char	compat_ioctl: move tape handling into drivers	2019-10-23 17:23:44 +02:00
cio	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next	2019-11-25 20:02:57 -08:00
crypto	s390 updates for the 5.5 merge window	2019-11-25 17:23:53 -08:00
net	s390/qeth: fix dangling IO buffers after halt/clear	2019-12-05 12:25:05 -08:00
scsi	scsi: zfcp: fix reaction on bit error threshold notification	2019-10-03 21:45:53 -04:00
virtio	virtio/s390: fix race on airq_areas[]	2019-07-26 13:36:18 +02:00
Makefile	s390: remove pointless drivers-y in drivers/s390/Makefile	2019-09-16 13:21:51 +02:00