Carlos Maiolino 8aea3ff411 xfs: Fix m_agirotor reset during AG selection
xfs_ialloc_next_ag() currently resets m_agirotor when it is equal to
m_maxagi:

         if (++mp->m_agirotor == mp->m_maxagi)
	         mp->m_agirotor = 0;

But, if for some reason mp->m_maxagi changes to a lower value than
current m_agirotor, this condition will never be true, causing
m_agirotor to exceed the maximum allowed value (m_maxagi).

This implies mainly during lookups for xfs_perag structs in its radix
tree, since the agno value used for the lookup is based on m_agirotor.
An out-of-range m_agirotor may cause a lookup failure which in case will
return NULL.

As an example, the value of m_maxagi is decreased during
inode64->inode32 remount process, case where I've found this problem.

Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
2012-09-26 15:42:42 -05:00
..
2012-07-14 16:34:32 +04:00
2012-07-30 17:25:16 -07:00
2012-07-14 16:38:34 +04:00
2012-07-14 16:34:32 +04:00
2012-07-14 16:34:47 +04:00
2012-08-02 09:11:19 -07:00
2012-07-27 15:17:50 -05:00
2012-07-14 16:34:47 +04:00
2012-07-26 11:25:33 -07:00
2012-07-14 16:38:34 +04:00
2012-07-16 14:24:43 -05:00
2012-07-14 16:34:32 +04:00
2012-07-30 17:25:16 -07:00
2012-07-22 23:58:09 +04:00
2012-07-14 16:34:47 +04:00
2012-07-14 16:34:47 +04:00
2012-07-14 16:38:34 +04:00
2012-07-30 17:25:19 -07:00
2012-07-14 16:34:47 +04:00
2012-07-14 16:34:47 +04:00
2012-07-30 17:25:16 -07:00
2012-07-14 16:34:32 +04:00
2012-07-14 16:34:47 +04:00
2012-07-22 23:58:16 +04:00
2012-07-14 16:34:47 +04:00
2012-03-20 21:29:46 -04:00
2012-03-20 21:29:46 -04:00
2012-07-30 17:25:21 -07:00
2012-07-14 16:32:47 +04:00
2012-07-14 16:38:34 +04:00
2012-03-20 21:29:38 -04:00
2012-07-14 16:32:48 +04:00