Oleg Nesterov 3716748530 [PATCH] taskstats: cleanup reply assembling
Thomas Graf wrote:
>
> nla_nest_start() may return NULL, either rely on prepare_reply() to be
> correct and BUG() on failure or do proper error handling for all
> functions.

nla_put() in taskstat.c can fail only if the 'size' argument of alloc_skb()
was not right. This is a kernel bug, we should not hide it. So add 'BUG()'
on error path and check for 'na == NULL'.

> genlmsg_cancel() is only required in error paths for dumping
> procedures.

So we can remove 'genlmsg_cancel()' calls and 'void *reply' (saves 227 bytes).

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Thomas Graf <tgraf@suug.ch>
Cc: Shailabh Nagar <nagar@watson.ibm.com>
Cc: Balbir Singh <balbir@in.ibm.com>
Cc: Jay Lan <jlan@sgi.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-12-07 08:39:34 -08:00
..
2006-09-11 13:32:30 -04:00
2006-09-29 09:18:12 -07:00
2006-12-07 08:39:25 -08:00
2006-10-03 08:03:41 -07:00
2006-03-26 08:57:03 -08:00
2006-09-29 09:18:15 -07:00
2006-12-04 02:00:22 -05:00
2006-07-03 15:27:04 -07:00
2006-12-04 02:00:22 -05:00
2006-09-30 01:47:55 +02:00
2006-12-07 08:39:25 -08:00
2006-11-03 12:27:58 -08:00
2006-09-29 09:18:12 -07:00
2006-11-22 14:57:56 +00:00
2006-12-07 08:39:32 -08:00
2005-04-16 15:20:36 -07:00
2006-10-01 00:39:27 -07:00
2006-04-19 16:27:18 -07:00
2006-12-07 08:39:25 -08:00
2006-07-10 13:24:25 -07:00