iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
8bcb80293b
linux/net/smc
History
Guangguan Wang 06b4934ab2 net/smc: use smc_lgr_list.lock to protect smc_lgr_list.list iterate in smcr_port_add 
[ Upstream commit f5146e3ef0a9eea405874b36178c19a4863b8989 ]

While doing smcr_port_add, there maybe linkgroup add into or delete
from smc_lgr_list.list at the same time, which may result kernel crash.
So, use smc_lgr_list.lock to protect smc_lgr_list.list iterate in
smcr_port_add.

The crash calltrace show below:
BUG: kernel NULL pointer dereference, address: 0000000000000000
PGD 0 P4D 0
Oops: 0000 [] SMP NOPTI
CPU: 0 PID: 559726 Comm: kworker/0:92 Kdump: loaded Tainted: G
Hardware name: Alibaba Cloud Alibaba Cloud ECS, BIOS 449e491 04/01/2014
Workqueue: events smc_ib_port_event_work [smc]
RIP: 0010:smcr_port_add+0xa6/0xf0 [smc]
RSP: 0000:ffffa5a2c8f67de0 EFLAGS: 00010297
RAX: 0000000000000001 RBX: ffff9935e0650000 RCX: 0000000000000000
RDX: 0000000000000010 RSI: ffff9935e0654290 RDI: ffff9935c8560000
RBP: 0000000000000000 R08: 0000000000000000 R09: ffff9934c0401918
R10: 0000000000000000 R11: ffffffffb4a5c278 R12: ffff99364029aae4
R13: ffff99364029aa00 R14: 00000000ffffffed R15: ffff99364029ab08
FS:  0000000000000000(0000) GS:ffff994380600000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000000 CR3: 0000000f06a10003 CR4: 0000000002770ef0
PKRU: 55555554
Call Trace:
 smc_ib_port_event_work+0x18f/0x380 [smc]
 process_one_work+0x19b/0x340
 worker_thread+0x30/0x370
 ? process_one_work+0x340/0x340
 kthread+0x114/0x130
 ? __kthread_cancel_work+0x50/0x50
 ret_from_fork+0x1f/0x30

Fixes: 1f90a05d9ff9 ("net/smc: add smcr_port_add() and smcr_link_up() processing")
Signed-off-by: Guangguan Wang <guangguan.wang@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-09-19 12:23:03 +02:00
..
af_smc.c
net/smc: fix fallback failed while sendmsg with fastopen
2023-03-17 08:48:56 +01:00
Kconfig
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
Makefile
net/smc: Add SMC statistics support
2021-06-16 12:54:02 -07:00
smc_cdc.c
net/smc: fix NULL sndbuf_desc in smc_cdc_tx_handler()
2023-03-22 13:31:25 +01:00
smc_cdc.h
net/smc: fix kernel panic caused by race of smc_sock
2022-01-05 12:42:36 +01:00
smc_clc.c
net/smc: add missing error check in smc_clc_prfx_set()
2021-09-21 10:54:16 +01:00
smc_clc.h
net/smc: Add support for obtaining system information
2020-12-01 17:56:13 -08:00
smc_close.c
net: deal with most data-races in sk_wait_event()
2023-05-24 17:36:42 +01:00
smc_close.h
net/smc: remove close abort worker
2019-10-22 11:23:44 -07:00
smc_core.c
net/smc: use smc_lgr_list.lock to protect smc_lgr_list.list iterate in smcr_port_add
2023-09-19 12:23:03 +02:00
smc_core.h
net/smc: Reset conn->lgr when link group registration fails
2022-01-27 11:03:53 +01:00
smc_diag.c
net/smc: Introduce SMCR get link command
2020-12-01 17:56:13 -08:00
smc_ib.c
net/smc: fix kernel panic caused by race of smc_sock
2022-01-05 12:42:36 +01:00
smc_ib.h
net/smc: fix kernel panic caused by race of smc_sock
2022-01-05 12:42:36 +01:00
smc_ism.c
net/smc: no need to flush smcd_dev's event_wq before destroying it
2021-06-03 13:54:49 -07:00
smc_ism.h
net/smc: Add support for obtaining SMCD device list
2020-12-01 17:56:13 -08:00
smc_llc.c
net/smc: Avoid to access invalid RMBs' MRs in SMCRv1 ADD LINK CONT
2023-06-14 11:13:01 +02:00
smc_llc.h
net/smc: move add link processing for new device into llc layer
2020-07-19 15:30:22 -07:00
smc_netlink.c
net/smc: Add netlink support for SMC fallback statistics
2021-06-16 12:54:02 -07:00
smc_netlink.h
net/smc: Add netlink support for SMC fallback statistics
2021-06-16 12:54:02 -07:00
smc_netns.h
net/smc: introduce list of pnetids for Ethernet devices
2020-09-28 15:19:03 -07:00
smc_pnet.c
net/smc: Fix NULL pointer dereference in smc_pnet_find_ib()
2022-04-20 09:34:11 +02:00
smc_pnet.h
net/smc: Use a mutex for locking "struct smc_pnettable"
2022-03-02 11:47:59 +01:00
smc_rx.c
net: deal with most data-races in sk_wait_event()
2023-05-24 17:36:42 +01:00
smc_rx.h
…
smc_stats.c
net/smc: Fix ENODATA tests in smc_nl_get_fback_stats()
2021-06-21 12:16:58 -07:00
smc_stats.h
net/smc: Make SMC statistics network namespace aware
2021-06-16 12:54:02 -07:00
smc_tx.c
net: deal with most data-races in sk_wait_event()
2023-05-24 17:36:42 +01:00
smc_tx.h
net/smc: Send directly when TCP_CORK is cleared
2022-04-13 20:59:02 +02:00
smc_wr.c
net/smc: fix kernel panic caused by race of smc_sock
2022-01-05 12:42:36 +01:00
smc_wr.h
net/smc: fix kernel panic caused by race of smc_sock
2022-01-05 12:42:36 +01:00
smc.h
net/smc: Forward wakeup to smc socket waitqueue after fallback
2022-02-08 18:34:09 +01:00