iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs
History
Filipe Manana 8c17312125 Btrfs: fix use-after-free when using the tree modification log 
commit efad8a853ad2057f96664328a0d327a05ce39c76 upstream.

At ctree.c:get_old_root(), we are accessing a root's header owner field
after we have freed the respective extent buffer. This results in an
use-after-free that can lead to crashes, and when CONFIG_DEBUG_PAGEALLOC
is set, results in a stack trace like the following:

  [ 3876.799331] stack segment: 0000 [#1] SMP DEBUG_PAGEALLOC PTI
  [ 3876.799363] CPU: 0 PID: 15436 Comm: pool Not tainted 5.3.0-rc3-btrfs-next-54 #1
  [ 3876.799385] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.12.0-0-ga698c8995f-prebuilt.qemu.org 04/01/2014
  [ 3876.799433] RIP: 0010:btrfs_search_old_slot+0x652/0xd80 [btrfs]
  (...)
  [ 3876.799502] RSP: 0018:ffff9f08c1a2f9f0 EFLAGS: 00010286
  [ 3876.799518] RAX: ffff8dd300000000 RBX: ffff8dd85a7a9348 RCX: 000000038da26000
  [ 3876.799538] RDX: 0000000000000000 RSI: ffffe522ce368980 RDI: 0000000000000246
  [ 3876.799559] RBP: dae1922adadad000 R08: 0000000008020000 R09: ffffe522c0000000
  [ 3876.799579] R10: ffff8dd57fd788c8 R11: 000000007511b030 R12: ffff8dd781ddc000
  [ 3876.799599] R13: ffff8dd9e6240578 R14: ffff8dd6896f7a88 R15: ffff8dd688cf90b8
  [ 3876.799620] FS:  00007f23ddd97700(0000) GS:ffff8dda20200000(0000) knlGS:0000000000000000
  [ 3876.799643] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
  [ 3876.799660] CR2: 00007f23d4024000 CR3: 0000000710bb0005 CR4: 00000000003606f0
  [ 3876.799682] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
  [ 3876.799703] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
  [ 3876.799723] Call Trace:
  [ 3876.799735]  ? do_raw_spin_unlock+0x49/0xc0
  [ 3876.799749]  ? _raw_spin_unlock+0x24/0x30
  [ 3876.799779]  resolve_indirect_refs+0x1eb/0xc80 [btrfs]
  [ 3876.799810]  find_parent_nodes+0x38d/0x1180 [btrfs]
  [ 3876.799841]  btrfs_check_shared+0x11a/0x1d0 [btrfs]
  [ 3876.799870]  ? extent_fiemap+0x598/0x6e0 [btrfs]
  [ 3876.799895]  extent_fiemap+0x598/0x6e0 [btrfs]
  [ 3876.799913]  do_vfs_ioctl+0x45a/0x700
  [ 3876.799926]  ksys_ioctl+0x70/0x80
  [ 3876.799938]  ? trace_hardirqs_off_thunk+0x1a/0x20
  [ 3876.799953]  __x64_sys_ioctl+0x16/0x20
  [ 3876.799965]  do_syscall_64+0x62/0x220
  [ 3876.799977]  entry_SYSCALL_64_after_hwframe+0x49/0xbe
  [ 3876.799993] RIP: 0033:0x7f23e0013dd7
  (...)
  [ 3876.800056] RSP: 002b:00007f23ddd96ca8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
  [ 3876.800078] RAX: ffffffffffffffda RBX: 00007f23d80210f8 RCX: 00007f23e0013dd7
  [ 3876.800099] RDX: 00007f23d80210f8 RSI: 00000000c020660b RDI: 0000000000000003
  [ 3876.800626] RBP: 000055fa2a2a2440 R08: 0000000000000000 R09: 00007f23ddd96d7c
  [ 3876.801143] R10: 00007f23d8022000 R11: 0000000000000246 R12: 00007f23ddd96d80
  [ 3876.801662] R13: 00007f23ddd96d78 R14: 00007f23d80210f0 R15: 00007f23ddd96d80
  (...)
  [ 3876.805107] ---[ end trace e53161e179ef04f9 ]---

Fix that by saving the root's header owner field into a local variable
before freeing the root's extent buffer, and then use that local variable
when needed.

Fixes: 30b0463a9394d9 ("Btrfs: fix accessing the root pointer in tree mod log functions")
CC: stable@vger.kernel.org # 3.10+
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-10-05 12:48:09 +02:00
..
9p
9p: pass the correct prototype to read_cache_page
2019-07-31 07:28:55 +02:00
adfs
fs/adfs: super: fix use-after-free bug
2019-08-06 19:05:21 +02:00
affs
affs_lookup(): close a race with affs_remove_link()
2018-05-30 07:51:47 +02:00
afs
afs: Fix directory permissions check
2018-07-08 15:30:51 +02:00
autofs4
autofs: fix error return in autofs_fill_super()
2019-03-13 14:03:19 -07:00
befs
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
bfs
bfs: add sanity check at bfs_fill_super()
2018-12-01 09:42:51 +01:00
btrfs
Btrfs: fix use-after-free when using the tree modification log
2019-10-05 12:48:09 +02:00
cachefiles
fscache, cachefiles: remove redundant variable 'cache'
2018-12-17 09:28:53 +01:00
ceph
ceph: fix buffer free while holding i_ceph_lock in fill_inode()
2019-09-10 10:32:18 +01:00
cifs
cifs: Use kzfree() to zero out the password
2019-09-21 07:15:38 +02:00
coda
coda: add error handling for fget
2019-08-06 19:05:23 +02:00
configfs
configfs: Fix use-after-free when accessing sd->s_dentry
2019-06-22 08:16:17 +02:00
cramfs
Cramfs: fix abad comparison when wrap-arounds occur
2018-11-13 11:15:12 -08:00
crypto
fscrypt: clean up some BUG_ON()s in block encryption/decryption
2019-07-31 07:28:22 +02:00
debugfs
debugfs: fix use-after-free on symlink traversal
2019-05-08 07:20:49 +02:00
devpts
fs/devpts: always delete dcache dentry-s in dput()
2019-03-23 14:35:21 +01:00
dlm
dlm: Don't swamp the CPU with callbacks queued during recovery
2019-02-12 19:45:57 +01:00
ecryptfs
eCryptfs: fix a couple type promotion bugs
2019-07-31 07:28:42 +02:00
efivarfs
VFS: Kill off s_options and helpers
2017-07-11 06:09:21 -04:00
efs
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
exofs
fs/exofs: fix potential memory leak in mount option parsing
2018-11-27 16:10:47 +01:00
exportfs
exportfs: do not read dentry after free
2018-12-17 09:28:50 +01:00
ext2
ext2: Fix underflow in ext2_max_size()
2019-03-23 14:35:23 +01:00
ext4
ext4: allow directory holes
2019-07-31 07:28:47 +02:00
f2fs
f2fs: use generic EFSBADCRC/EFSCORRUPTED
2019-10-05 12:47:39 +02:00
fat
fs/fat/file.c: issue flush after the writeback of FAT
2019-06-15 11:54:51 +02:00
freevxfs
…
fscache
fscache: fix race between enablement and dropping of object
2018-12-17 09:28:53 +01:00
fuse
fuse: fix missing unlock_page in fuse_writepage()
2019-10-05 12:48:05 +02:00
gfs2
gfs2: clear buf_in_tr when ending a transaction in sweep_bh_for_rgrps
2019-10-05 12:48:08 +02:00
hfs
hfs: do not free node before using
2018-12-17 09:28:54 +01:00
hfsplus
hfsplus: do not free node before using
2018-12-17 09:28:54 +01:00
hostfs
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
hpfs
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
hugetlbfs
hugetlb: use same fault hash key for shared and private mappings
2019-05-31 06:47:12 -07:00
isofs
isofs: reject hardware sector size > 2048 bytes
2018-10-03 17:00:57 -07:00
jbd2
jbd2: introduce jbd2_inode dirty range scoping
2019-07-31 07:28:47 +02:00
jffs2
jffs2: fix use-after-free on symlink traversal
2019-05-08 07:20:49 +02:00
jfs
jfs: Fix inconsistency between memory allocation and ea_buf->max_size
2018-08-09 12:16:39 +02:00
kernfs
kernfs: fix barrier usage in __kernfs_new_node()
2019-05-16 19:42:19 +02:00
lockd
Revert "lockd: Show pid of lockd for remote locks"
2019-06-09 09:18:18 +02:00
minix
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
ncpfs
staging: ncpfs: memory corruption in ncp_read_kernel()
2018-03-28 18:24:43 +02:00
nfs
NFSv2: Fix write regression
2019-09-21 07:15:37 +02:00
nfs_common
lockd: fix "list_add double add" caused by legacy signal interface
2018-02-03 17:39:08 +01:00
nfsd
nfsd: Fix overflow causing non-working mounts on 1 TB machines
2019-07-31 07:28:48 +02:00
nilfs2
do d_instantiate/unlock_new_inode combinations safely
2018-05-30 07:51:47 +02:00
nls
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
notify
fanotify: fix handling of events on child sub-directory
2019-02-06 17:31:37 +01:00
ntfs
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
ocfs2
ocfs2: remove set but not used variable 'last_hash'
2019-08-25 10:50:17 +02:00
omfs
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
openpromfs
…
orangefs
orangefs: report attributes_mask and attributes for statx
2018-06-26 08:06:33 +08:00
overlayfs
ovl: filter of trusted xattr results in audit
2019-10-05 12:48:09 +02:00
proc
fs/proc/proc_sysctl.c: fix the default values of i_uid/i_gid on /proc/sys inodes.
2019-07-31 07:28:38 +02:00
pstore
pstore/ram: Run without kernel crash dump region
2019-06-11 12:21:48 +02:00
qnx4
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
qnx6
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
quota
quota: fix a problem about transfer quota
2019-07-21 09:04:28 +02:00
ramfs
mm: make pagevec_lookup() update index
2017-09-06 17:27:26 -07:00
reiserfs
reiserfs: propagate errors from fill_with_dentries() properly
2018-11-27 16:10:46 +01:00
romfs
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
squashfs
Squashfs: Compute expected length from inode size rather than block length
2018-09-05 09:26:32 +02:00
sysfs
scsi: sysfs: Introduce sysfs_{un,}break_active_protection()
2018-09-05 09:26:41 +02:00
sysv
sysv: return 'err' instead of 0 in __sysv_write_inode
2018-12-17 09:28:48 +01:00
tracefs
VFS: Don't use save/replace_mount_options if not using generic_show_options
2017-07-06 03:31:46 -04:00
ubifs
ubifs: Correctly use tnc_next() in search_dh_cookie()
2019-09-19 09:08:06 +02:00
udf
udf: Fix incorrect final NOT_ALLOCATED (hole) extent length
2019-07-21 09:04:30 +02:00
ufs
ufs: fix braino in ufs_get_inode_gid() for solaris UFS flavour
2019-05-25 18:25:36 +02:00
xfs
xfs: don't crash on null attr fork xfs_bmapi_read
2019-10-05 12:47:38 +02:00
aio.c
aio: fix spectre gadget in lookup_ioctx
2018-12-21 14:13:04 +01:00
anon_inodes.c
…
attr.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
bad_inode.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
binfmt_aout.c
fs: fix kernel_read prototype
2017-09-04 19:05:15 -04:00
binfmt_elf_fdpic.c
Merge branch 'work.set_fs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2017-09-14 18:13:32 -07:00
binfmt_elf.c
binfmt_elf: Do not move brk for INTERP-less ET_EXEC
2019-10-05 12:48:06 +02:00
binfmt_em86.c
…
binfmt_flat.c
fs/binfmt_flat.c: make load_flat_shared_library() work
2019-07-03 13:15:59 +02:00
binfmt_misc.c
fs/binfmt_misc.c: do not allow offset overflow
2018-06-26 08:06:33 +08:00
binfmt_script.c
Revert "exec: load_script: don't blindly truncate shebang string"
2019-02-15 09:08:56 +01:00
block_dev.c
block: fix the return errno for direct IO
2019-04-17 08:37:53 +02:00
buffer.c
fs: fix guard_bio_eod to check for real EOD errors
2019-04-05 22:31:28 +02:00
char_dev.c
chardev: add additional check for minor range overlap
2019-05-31 06:47:31 -07:00
compat_binfmt_elf.c
…
compat_ioctl.c
compat_ioctl: pppoe: fix PPPOEIOCSFWD handling
2019-08-09 17:53:35 +02:00
compat.c
…
coredump.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
dax.c
fs/dax.c: release PMD lock even when there is no PMD support in DAX
2018-04-26 11:02:14 +02:00
dcache.c
fs/dcache: Fix incorrect nr_dentry_unused accounting in shrink_dcache_sb()
2019-02-06 17:31:34 +01:00
dcookies.c
…
direct-io.c
iomap: report collisions between directio and buffered writes to userspace
2019-04-27 09:35:41 +02:00
drop_caches.c
fs/drop_caches.c: avoid softlockups in drop_pagecache_sb()
2019-03-13 14:03:18 -07:00
eventfd.c
There has been a fair amount of activity in the docs tree this time
2017-07-03 21:13:25 -07:00
eventpoll.c
fs/epoll: drop ovflist branch prediction
2019-02-12 19:46:10 +01:00
exec.c
sched/fair: Don't free p->numa_faults with concurrent readers
2019-08-04 09:32:03 +02:00
fcntl.c
fcntl: don't cap l_start and l_end values for F_GETLK64 in compat syscall
2017-12-17 15:07:59 +01:00
fhandle.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
file_table.c
fput: Don't reinvent the wheel but use existing llist API
2017-08-28 00:50:23 -04:00
file.c
fs/file.c: initialize init_files.resize_wait
2019-04-05 22:31:28 +02:00
filesystems.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
fs_pin.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
fs_struct.c
…
fs-writeback.c
blkcg, writeback: dead memcgs shouldn't contribute to writeback ownership arbitration
2019-07-31 07:28:25 +02:00
inode.c
Abort file_remove_privs() for non-reg. files
2019-06-22 08:16:19 +02:00
internal.h
Merge branch 'overlayfs-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs
2017-09-13 09:11:44 -07:00
ioctl.c
vfs: swap names of {do,vfs}_clone_file_range()
2018-11-10 07:48:33 -08:00
iomap.c
iomap: report collisions between directio and buffered writes to userspace
2019-04-27 09:35:41 +02:00
Kconfig
fs/Kconfig: kill CONFIG_PERCPU_RWSEM some more
2017-07-12 16:26:00 -07:00
Kconfig.binfmt
…
libfs.c
fs: convert __generic_file_fsync to use errseq_t based reporting
2017-07-06 07:02:29 -04:00
locks.c
fs/lock: skip lock owner pid translation in case we are in init_pid_ns
2018-10-03 17:00:53 -07:00
Makefile
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
mbcache.c
mbcache: initialize entry->e_referenced in mb_cache_entry_create()
2018-02-22 15:42:25 +01:00
mount.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
mpage.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
namei.c
namei: allow restricted O_CREAT of FIFOs and regular files
2018-12-01 09:42:59 +01:00
namespace.c
mount: Prevent MNT_DETACH from disconnecting locked mounts
2018-11-21 09:24:14 +01:00
no-block.c
…
nsfs.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
open.c
access: avoid the RCU grace period for the temporary subjective credentials
2019-07-31 07:28:58 +02:00
pipe.c
fs: prevent page refcount overflow in pipe_buf_get
2019-05-04 09:15:18 +02:00
pnode.c
mnt: Make propagate_umount less slow for overlapping mount propagation trees
2017-05-23 08:41:17 -05:00
pnode.h
…
posix_acl.c
…
proc_namespace.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
read_write.c
vfs: fix page locking deadlocks when deduping files
2019-09-10 10:32:15 +01:00
readdir.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
select.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
seq_file.c
seq_file: fix incomplete reset on read from zero offset
2018-02-22 15:42:28 +01:00
signalfd.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
splice.c
fs: prevent page refcount overflow in pipe_buf_get
2019-05-04 09:15:18 +02:00
stack.c
…
stat.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
statfs.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
super.c
fs: don't scan the inode cache before SB_BORN is set
2018-05-30 07:51:47 +02:00
sync.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
timerfd.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
userfaultfd.c
userfaultfd_release: always remove uffd flags and clear vm_userfaultfd_ctx
2019-08-29 08:26:43 +02:00
utimes.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
xattr.c
sysfs: Do not return POSIX ACL xattrs via listxattr
2018-10-10 08:54:27 +02:00