Oleg Nesterov 8dc3e9099e [PATCH] sched_setscheduler: fix? policy checks ...

I am not sure this patch is correct: I can't understand what the current
code does, and I don't know what it was supposed to do.

The comment says:

		 * can't change policy, except between SCHED_NORMAL
		 * and SCHED_BATCH:

The code:

		if (((policy != SCHED_NORMAL && p->policy != SCHED_BATCH) &&
			(policy != SCHED_BATCH && p->policy != SCHED_NORMAL)) &&

But this is equivalent to:

		if ( (is_rt_policy(policy) && has_rt_policy(p)) &&

which means something different.  We can't _decrease_ the current
->rt_priority with such a check (if rlim[RLIMIT_RTPRIO] == 0).

Probably, it was supposed to be:

		if (	!(policy == SCHED_NORMAL && p->policy == SCHED_BATCH)  &&
			!(policy == SCHED_BATCH  && p->policy == SCHED_NORMAL)

this matches the comment, but strange: it doesn't allow to _drop_ the
realtime priority when rlim[RLIMIT_RTPRIO] == 0.

I think the right check would be:

		/* can't set/change rt policy */
		if (is_rt_policy(policy) &&
				policy != p->policy &&
				!rlim_rtprio)
			return -EPERM;

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

2006-09-29 09:18:17 -07:00

..

irq

[PATCH] irq: remove a extra line

2006-09-29 09:18:07 -07:00

power

Merge master.kernel.org:/pub/scm/linux/kernel/git/gregkh/driver-2.6

2006-09-26 11:49:46 -07:00

time

[PATCH] time: rename clocksource functions

2006-06-26 09:58:21 -07:00

.gitignore

gitignore: ignore more generated files

2006-01-03 11:35:26 +01:00

acct.c

[PATCH] Fix sighand->siglock usage in kernel/acct.c

2006-07-14 21:53:54 -07:00

audit.c

[PATCH] selinux: rename selinux_ctxid_to_string

2006-09-26 08:48:52 -07:00

audit.h

[PATCH] audit: AUDIT_PERM support

2006-09-11 13:32:30 -04:00

auditfilter.c

[PATCH] selinux: rename selinux_ctxid_to_string

2006-09-26 08:48:52 -07:00

auditsc.c

[PATCH] selinux: rename selinux_ctxid_to_string

2006-09-26 08:48:52 -07:00

capability.c

[PATCH] pidspace: is_init()

2006-09-29 09:18:12 -07:00

compat.c

[PATCH] posix-timers: Fix clock_nanosleep() doesn't return the remaining time in compatibility mode

2006-09-29 09:18:15 -07:00

configs.c

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

cpu.c

[PATCH] Disable CPU hotplug during suspend

2006-09-26 08:48:59 -07:00

cpuset.c

[PATCH] pidspace: is_init()

2006-09-29 09:18:12 -07:00

delayacct.c

[PATCH] task delay accounting fixes

2006-09-01 11:39:08 -07:00

dma.c

Linux-2.6.12-rc2

2005-04-16 15:20:36 -07:00

exec_domain.c

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

exit.c

[PATCH] exit: fix crash case

2006-09-29 09:18:16 -07:00

extable.c

[PATCH] symbol_put_addr() locks kernel

2006-05-15 11:20:55 -07:00

fork.c

[PATCH] ifdef blktrace debugging fields

2006-09-29 09:18:09 -07:00

futex_compat.c

[PATCH] futex: Apply recent futex fixes to futex_compat

2006-08-06 08:57:49 -07:00

futex.c

[PATCH] Use the correct restart option for futex_lock_pi

2006-09-08 10:22:50 -07:00

hrtimer.c

[PATCH] posix-timers: Fix clock_nanosleep() doesn't return the remaining time in compatibility mode

2006-09-29 09:18:15 -07:00

itimer.c

[PATCH] hrtimers: remove data field

2006-03-26 08:57:03 -08:00

kallsyms.c

[PATCH] null-terminate over-long /proc/kallsyms symbols

2006-07-14 21:53:52 -07:00

Kconfig.hz

[PATCH] i386: Selectable Frequency of the Timer Interrupt

2005-06-23 09:45:10 -07:00

Kconfig.preempt

[PATCH] sched: voluntary kernel preemption

2005-06-25 16:24:45 -07:00

kexec.c

[PATCH] kexec warning fix

2006-09-29 09:18:15 -07:00

kfifo.c

[PATCH] memory ordering in __kfifo primitives

2006-09-29 09:18:13 -07:00

kmod.c

[PATCH] Fix ____call_usermodehelper errors being silently ignored

2006-09-29 09:18:16 -07:00

kprobes.c

[PATCH] IA64: kprobe invalidate icache of jump buffer

2006-07-31 13:28:38 -07:00

ksysfs.c

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

kthread.c

[PATCH] remove kernel/kthread.c:kthread_stop_sem()

2006-07-14 21:53:52 -07:00

lockdep_internals.h

[PATCH] lockdep: double the number of stack-trace entries

2006-09-13 07:32:14 -07:00

lockdep_proc.c

[PATCH] lockdep: procfs

2006-07-03 15:27:04 -07:00

lockdep.c

[PATCH] lockdep: print kernel version

2006-09-29 09:18:13 -07:00

Makefile

[PATCH] per-task-delay-accounting: taskstats interface

2006-07-14 21:53:56 -07:00

module.c

[PATCH] load_module: no BUG if module_subsys uninitialized

2006-09-25 17:38:36 -07:00

mutex-debug.c

[PATCH] lockdep: prove mutex locking correctness

2006-07-03 15:27:04 -07:00

mutex-debug.h

[PATCH] lockdep: better lock debugging

2006-07-03 15:27:01 -07:00

mutex.c

[PATCH] lockdep: prove mutex locking correctness

2006-07-03 15:27:04 -07:00

mutex.h

[PATCH] lockdep: prove mutex locking correctness

2006-07-03 15:27:04 -07:00

panic.c

[PATCH] Add the __stack_chk_fail() function

2006-09-26 10:52:39 +02:00

params.c

[PATCH] module_subsys: initialize earlier

2006-09-29 09:18:08 -07:00

pid.c

[PATCH] pid: remove temporary debug code in attach_pid

2006-09-27 08:26:19 -07:00

posix-cpu-timers.c

[PATCH] posix-timers: Fix the flags handling in posix_cpu_nsleep()

2006-09-29 09:18:15 -07:00

posix-timers.c

[PATCH] posix-timers: Fix clock_nanosleep() doesn't return the remaining time in compatibility mode

2006-09-29 09:18:15 -07:00

printk.c

[PATCH] PM: make it possible to disable console suspending

2006-09-26 08:49:03 -07:00

profile.c

[PATCH] Profiling: require buffer allocation on the correct node

2006-09-26 08:48:50 -07:00

ptrace.c

[PATCH] pidspace: is_init()

2006-09-29 09:18:12 -07:00

rcupdate.c

[PATCH] rcu_do_batch: make ->qlen decrement irq safe

2006-09-13 07:32:14 -07:00

rcutorture.c

[PATCH] rcu: add lock annotations to rcu{,_bh}_torture_read_{lock,unlock}

2006-09-29 09:18:08 -07:00

relay.c

[PATCH] kernel-doc for relay interface

2006-09-29 09:18:06 -07:00

resource.c

Resources: insert identical resources above existing resources

2006-09-26 17:43:52 -07:00

rtmutex_common.h

[PATCH] pi-futex: futex_lock_pi/futex_unlock_pi support

2006-06-27 17:32:47 -07:00

rtmutex-debug.c

[PATCH] sched: cleanup, remove task_t, convert to struct task_struct

2006-07-03 15:27:11 -07:00

rtmutex-debug.h

[PATCH] lockdep: better lock debugging

2006-07-03 15:27:01 -07:00

rtmutex-tester.c

[PATCH] Add try_to_freeze() to rt-test kthreads

2006-07-14 21:53:53 -07:00

rtmutex.c

[PATCH] clean up and remove some extra spinlocks from rtmutex

2006-09-29 09:18:09 -07:00

rtmutex.h

[PATCH] lockdep: better lock debugging

2006-07-03 15:27:01 -07:00

rwsem.c

[PATCH] lockdep: prove rwsem locking correctness

2006-07-03 15:27:04 -07:00

sched.c

[PATCH] sched_setscheduler: fix? policy checks

2006-09-29 09:18:17 -07:00

seccomp.c

Linux-2.6.12-rc2

2005-04-16 15:20:36 -07:00

signal.c

[PATCH] __dequeue_signal() cleanup

2006-09-29 09:18:15 -07:00

softirq.c

[PATCH] check return value of cpu_callback

2006-09-29 09:18:14 -07:00

softlockup.c

[PATCH] check return value of cpu_callback

2006-09-29 09:18:14 -07:00

spinlock.c

[PATCH] remove generic__raw_read_trylock()

2006-09-29 09:18:03 -07:00

stacktrace.c

[PATCH] lockdep: stacktrace subsystem, core

2006-07-03 15:27:02 -07:00

stop_machine.c

[PATCH] Remove redundant up() in stop_machine()

2006-08-27 11:01:31 -07:00

sys_ni.c

[PATCH] sys_move_pages: 32bit support (i386, x86_64)

2006-06-23 07:42:53 -07:00

sys.c

[PATCH] kill extraneous printk in kernel_restart()

2006-09-29 09:18:16 -07:00

sysctl.c

[PATCH] pidspace: is_init()

2006-09-29 09:18:12 -07:00

taskstats.c

[NETLINK]: Extend netlink messaging interface

2006-09-22 14:53:43 -07:00

time.c

[PATCH] Time: Introduce arch generic time accessors

2006-06-26 09:58:20 -07:00

timer.c

[PATCH] simplify update_times (avoid jiffies/jiffies_64 aliasing problem)

2006-09-29 09:18:15 -07:00

uid16.c

[PATCH] Add more prevent_tail_call()

2006-04-19 16:27:18 -07:00

unwind.c

[PATCH] unwind: fix unused variable warning when !CONFIG_MODULES

2006-09-29 09:18:11 -07:00

user.c

[PATCH] selinux: add hooks for key subsystem

2006-06-22 15:05:55 -07:00

wait.c

[PATCH] uninline init_waitqueue_head()

2006-07-10 13:24:25 -07:00

workqueue.c

[PATCH] workqueue: remove lock_cpu_hotplug()

2006-08-14 12:54:29 -07:00