linux

iv/linux

History

Peter Senna Tschudin 8ea6cdf527 staging: et131x: Remove useless return variables

This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.

Verified by compilation only.

The coccinelle script that find and fixes this issue is:
// <smpl>
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2014-05-23 20:43:47 +09:00

et131x.c

staging: et131x: Remove useless return variables

2014-05-23 20:43:47 +09:00

et131x.h

staging: et131x: clear up use of TRUEPHY defines

2013-12-06 12:55:48 -08:00

Kconfig

staging: fix more ET131X build errors

2011-11-18 15:00:54 -08:00

Makefile

staging: et131x: Put all .c files into one big file

2011-10-23 10:03:40 +02:00

Module.symvers

staging: et131x: Remove unused rcv_pend_lock spinlock

2013-09-17 07:47:43 -07:00

README

staging: et131x: remove item that have been done in TODO file

2013-12-10 23:12:13 -08:00

README

This is a driver for the ET1310 network device.

Based on the driver found at https://sourceforge.net/projects/et131x/

Cleaned up immensely by Olaf Hartman and Christoph Hellwig <hch@infradead.org>

Note, the powermanagement options were removed from the vendor provided
driver as they did not build properly at the time.

TODO:
	- Look at reducing the number of spinlocks
	- Simplify code in nic_rx_pkts(), when determining multicast_pkts_rcvd
	- Implement NAPI support
	- In et131x_tx(), don't return NETDEV_TX_BUSY, just drop the packet with kfree_skb().
	- Reduce the number of split lines by careful consideration of variable names etc.

Please send patches to:
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
	Mark Einon <mark.einon@gmail.com>