Tyrel Datwyler
b36522150e
scsi: ibmvscsi: Fix WARN_ON during event pool release
...
While removing an ibmvscsi client adapter a WARN_ON like the following is
seen in the kernel log:
drmgr: drmgr: -r -c slot -s U9080.M9S.783AEC8-V11-C11 -w 5 -d 1
WARNING: CPU: 9 PID: 24062 at ../kernel/dma/mapping.c:311 dma_free_attrs+0x78/0x110
Supported: No, Unreleased kernel
CPU: 9 PID: 24062 Comm: drmgr Kdump: loaded Tainted: G X 5.3.18-12-default
NIP: c0000000001fa758 LR: c0000000001fa744 CTR: c0000000001fa6e0
REGS: c0000002173375d0 TRAP: 0700 Tainted: G X (5.3.18-12-default)
MSR: 8000000000029033 <SF,EE,ME,IR,DR,RI,LE> CR: 28088282 XER: 20000000
CFAR: c0000000001fbf0c IRQMASK: 1
GPR00: c0000000001fa744 c000000217337860 c00000000161ab00 0000000000000000
GPR04: 0000000000000000 c000011e12250000 0000000018010000 0000000000000000
GPR08: 0000000000000000 0000000000000001 0000000000000001 c0080000190f4fa8
GPR12: c0000000001fa6e0 c000000007fc2a00 0000000000000000 0000000000000000
GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
GPR20: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
GPR24: 000000011420e310 0000000000000000 0000000000000000 0000000018010000
GPR28: c00000000159de50 c000011e12250000 0000000000006600 c000011e5c994848
NIP [c0000000001fa758] dma_free_attrs+0x78/0x110
LR [c0000000001fa744] dma_free_attrs+0x64/0x110
Call Trace:
[c000000217337860] [000000011420e310] 0x11420e310 (unreliable)
[c0000002173378b0] [c0080000190f0280] release_event_pool+0xd8/0x120 [ibmvscsi]
[c000000217337930] [c0080000190f3f74] ibmvscsi_remove+0x6c/0x160 [ibmvscsi]
[c000000217337960] [c0000000000f3cac] vio_bus_remove+0x5c/0x100
[c0000002173379a0] [c00000000087a0a4] device_release_driver_internal+0x154/0x280
[c0000002173379e0] [c0000000008777cc] bus_remove_device+0x11c/0x220
[c000000217337a60] [c000000000870fc4] device_del+0x1c4/0x470
[c000000217337b10] [c0000000008712a0] device_unregister+0x30/0xa0
[c000000217337b80] [c0000000000f39ec] vio_unregister_device+0x2c/0x60
[c000000217337bb0] [c00800001a1d0964] dlpar_remove_slot+0x14c/0x250 [rpadlpar_io]
[c000000217337c50] [c00800001a1d0bcc] remove_slot_store+0xa4/0x110 [rpadlpar_io]
[c000000217337cd0] [c000000000c091a0] kobj_attr_store+0x30/0x50
[c000000217337cf0] [c00000000057c934] sysfs_kf_write+0x64/0x90
[c000000217337d10] [c00000000057be10] kernfs_fop_write+0x1b0/0x290
[c000000217337d60] [c000000000488c4c] __vfs_write+0x3c/0x70
[c000000217337d80] [c00000000048c648] vfs_write+0xd8/0x260
[c000000217337dd0] [c00000000048ca8c] ksys_write+0xdc/0x130
[c000000217337e20] [c00000000000b488] system_call+0x5c/0x70
Instruction dump:
7c840074 f8010010 f821ffb1 20840040 eb830218 7c8407b4 48002019 60000000
2fa30000 409e003c 892d0988 792907e0 <0b090000> 2fbd0000 419e0028 2fbc0000
---[ end trace 5955b3c0cc079942 ]---
rpadlpar_io: slot U9080.M9S.783AEC8-V11-C11 removed
This is tripped as a result of irqs being disabled during the call to
dma_free_coherent() by release_event_pool(). At this point in the code path
we have quiesced the adapter and it is overly paranoid to be holding the
host lock.
[mkp: fixed build warning reported by sfr]
Link: https://lore.kernel.org/r/1588027793-17952-1-git-send-email-tyreld@linux.ibm.com
Signed-off-by: Tyrel Datwyler <tyreld@linux.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2020-04-28 22:59:55 -04:00
..
2020-04-10 12:21:11 -07:00
2020-04-10 12:21:11 -07:00
2020-01-03 09:42:52 +01:00
2020-04-02 17:03:53 -07:00
2019-10-24 21:22:32 -04:00
2020-03-17 13:36:09 -04:00
2019-09-30 23:59:53 -04:00
2020-03-31 22:35:02 -04:00
2020-01-06 09:45:59 +01:00
2020-01-29 18:16:16 -08:00
2019-12-27 17:28:41 -08:00
2019-12-02 13:37:02 -08:00
2019-11-07 06:43:18 -07:00
2020-03-11 23:07:59 -04:00
2020-02-04 03:05:26 +00:00
2019-09-21 10:50:15 -07:00
2020-03-17 13:36:10 -04:00
2020-04-13 13:28:13 -04:00
2020-04-28 22:59:55 -04:00
2019-12-19 22:08:54 -05:00
2020-04-02 17:03:53 -07:00
2020-04-10 12:21:11 -07:00
2020-03-26 10:28:17 -06:00
2020-04-10 12:21:11 -07:00
2020-04-02 17:03:53 -07:00
2020-03-31 22:02:37 -04:00
2020-03-11 23:07:56 -04:00
2020-03-11 23:08:01 -04:00
2020-03-17 13:57:19 -04:00
2020-03-05 17:36:24 -08:00
2020-03-26 22:38:54 -04:00
2020-04-24 12:17:06 -04:00
2019-12-19 22:08:55 -05:00
2020-03-17 13:36:13 -04:00
2020-03-11 23:07:56 -04:00
2019-12-19 22:08:54 -05:00
2020-04-10 12:21:11 -07:00
2020-03-25 11:50:48 +01:00
2019-02-25 21:37:25 -05:00
2019-03-02 11:39:54 -08:00
2019-10-23 17:23:44 +02:00
2018-10-17 21:58:51 -04:00
2019-05-24 17:36:45 +02:00
2018-08-30 07:27:22 -04:00
2019-01-08 07:58:37 -05:00
2019-05-21 10:50:45 +02:00
2019-10-18 15:01:54 +02:00
2019-05-21 10:50:45 +02:00
2020-02-18 00:39:54 -05:00
2020-03-11 23:07:58 -04:00
2019-05-21 10:50:45 +02:00
2020-03-26 21:10:53 -04:00
2019-05-21 10:50:45 +02:00
2019-11-12 22:21:34 -05:00
2019-11-12 22:21:35 -05:00
2020-04-02 17:03:53 -07:00
2019-06-05 17:37:11 +02:00
2019-05-21 10:50:45 +02:00
2020-02-24 14:54:25 -05:00
2020-04-01 22:03:04 -04:00
2020-03-26 22:51:18 -04:00
2019-05-24 17:36:45 +02:00
2020-03-11 23:07:59 -04:00
2020-03-11 23:07:59 -04:00
2019-12-19 22:08:51 -05:00
2019-12-19 22:08:51 -05:00
2019-07-30 12:18:24 -04:00
2019-06-18 19:46:18 -04:00
2019-07-30 12:17:28 -04:00
2019-06-18 19:46:22 -04:00
2018-09-25 20:45:53 -04:00
2020-03-11 23:08:00 -04:00
2019-01-08 21:58:35 -05:00
2020-03-17 13:36:10 -04:00
2019-01-08 21:57:42 -05:00
2019-05-30 11:25:18 -07:00
2019-01-08 21:58:35 -05:00
2019-05-21 10:50:45 +02:00
2020-02-28 20:54:52 -05:00
2019-07-11 15:14:01 -07:00
2020-03-26 22:44:41 -04:00
2019-06-18 19:46:18 -04:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:36:37 +02:00
2019-07-11 15:17:41 -07:00
2019-12-19 22:08:54 -05:00
2020-04-02 17:03:53 -07:00
2020-04-02 17:03:53 -07:00
2019-09-30 22:46:40 -04:00
2018-11-06 21:31:28 -05:00
2019-06-05 17:36:37 +02:00
2020-01-15 22:48:34 -05:00
2019-05-30 11:26:37 -07:00
2019-05-21 10:50:45 +02:00
2020-04-14 21:16:16 -04:00
2020-01-06 09:45:59 +01:00
2019-07-11 15:14:01 -07:00
2020-03-26 22:48:58 -04:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2019-11-12 22:21:34 -05:00
2019-07-17 22:39:27 +09:00
2020-03-24 07:57:07 -06:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2018-12-18 23:13:12 -05:00
2019-07-11 15:17:41 -07:00
2020-03-11 23:07:56 -04:00
2020-01-06 09:45:59 +01:00
2020-01-02 21:57:44 -05:00
2020-01-06 09:45:59 +01:00
2020-01-02 21:57:44 -05:00
2020-03-11 23:08:01 -04:00
2019-05-24 17:36:45 +02:00
2019-11-19 21:37:34 -05:00
2019-06-20 15:37:02 -04:00
2019-10-24 21:22:32 -04:00
2019-05-24 17:39:02 +02:00
2019-10-23 17:23:44 +02:00
2020-03-11 23:07:56 -04:00
2019-06-20 15:21:33 -04:00
2019-05-30 11:26:38 -07:00
2020-01-20 18:35:55 -05:00
2020-01-15 23:09:11 -05:00
2019-03-19 17:11:37 -04:00
2018-12-18 23:19:21 -05:00
2019-08-07 21:32:53 -04:00
2019-02-13 22:07:03 -05:00
2019-06-05 17:37:17 +02:00
2019-05-24 17:36:45 +02:00
2020-03-24 07:57:08 -06:00
2019-07-30 12:42:55 -04:00
2019-05-21 06:16:21 -04:00
2020-02-04 03:05:26 +00:00
2019-05-30 11:26:35 -07:00
2020-02-28 20:54:55 -05:00
2020-01-03 09:33:18 +01:00
2020-04-21 23:44:26 -04:00
2019-09-30 23:07:16 -04:00
2019-12-19 22:08:54 -05:00
2019-05-30 11:26:35 -07:00
2019-09-12 07:11:58 -06:00
2020-02-28 20:54:55 -05:00
2020-02-04 03:05:26 +00:00
2020-02-28 20:54:55 -05:00
2019-05-30 11:29:53 -07:00
2020-03-17 13:36:12 -04:00
2020-03-16 22:08:36 -04:00
2019-07-11 15:14:01 -07:00
2020-03-31 21:39:58 -04:00
2019-11-21 21:12:39 -05:00
2019-05-30 11:26:35 -07:00
2019-06-19 17:09:56 +02:00
2020-02-28 20:54:55 -05:00
2020-03-24 07:57:08 -06:00
2019-06-05 17:37:14 +02:00
2020-02-24 12:50:32 -05:00
2020-03-30 11:20:13 -07:00
2019-12-08 12:23:42 -08:00
2019-07-11 15:14:01 -07:00
2020-04-14 21:15:53 -04:00
2018-12-18 23:19:21 -05:00
2019-05-24 17:36:45 +02:00
2020-01-06 09:45:59 +01:00
2018-08-02 15:22:13 -06:00
2020-02-24 14:59:01 -05:00
2020-04-10 12:21:11 -07:00
2020-02-24 15:01:57 -05:00
2020-03-16 22:08:34 -04:00
2020-03-11 23:07:56 -04:00
2020-01-15 23:02:24 -05:00
2019-11-12 22:21:34 -05:00
2020-01-06 09:45:59 +01:00
2019-05-21 10:50:45 +02:00
2020-02-10 22:46:55 -05:00
2019-12-19 22:42:44 -05:00
2019-08-07 21:35:59 -04:00
2019-05-24 17:39:02 +02:00
2019-07-11 15:14:01 -07:00
2018-11-15 14:27:08 -05:00
2018-12-18 23:13:12 -05:00
2020-01-06 09:45:59 +01:00
2019-05-21 10:50:45 +02:00
2020-02-12 22:56:47 -05:00