Namjae Jeon
8ed1118da8
ksmbd: fix possible deadlock in smb2_open ...
[ Upstream commit 864fb5d3716303a045c3ffb397f651bfd37bfb36 ]
[ 8743.393379] ======================================================
[ 8743.393385] WARNING: possible circular locking dependency detected
[ 8743.393391] 6.4.0-rc1+ #11 Tainted: G OE
[ 8743.393397] ------------------------------------------------------
[ 8743.393402] kworker/0:2/12921 is trying to acquire lock:
[ 8743.393408] ffff888127a14460 (sb_writers#8){.+.+}-{0:0}, at: ksmbd_vfs_setxattr+0x3d/0xd0 [ksmbd]
[ 8743.393510]
but task is already holding lock:
[ 8743.393515] ffff8880360d97f0 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: ksmbd_vfs_kern_path_locked+0x181/0x670 [ksmbd]
[ 8743.393618]
which lock already depends on the new lock.
[ 8743.393623]
the existing dependency chain (in reverse order) is:
[ 8743.393628]
-> #1 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}:
[ 8743.393648] down_write_nested+0x9a/0x1b0
[ 8743.393660] filename_create+0x128/0x270
[ 8743.393670] do_mkdirat+0xab/0x1f0
[ 8743.393680] __x64_sys_mkdir+0x47/0x60
[ 8743.393690] do_syscall_64+0x5d/0x90
[ 8743.393701] entry_SYSCALL_64_after_hwframe+0x72/0xdc
[ 8743.393711]
-> #0 (sb_writers#8){.+.+}-{0:0}:
[ 8743.393728] __lock_acquire+0x2201/0x3b80
[ 8743.393737] lock_acquire+0x18f/0x440
[ 8743.393746] mnt_want_write+0x5f/0x240
[ 8743.393755] ksmbd_vfs_setxattr+0x3d/0xd0 [ksmbd]
[ 8743.393839] ksmbd_vfs_set_dos_attrib_xattr+0xcc/0x110 [ksmbd]
[ 8743.393924] compat_ksmbd_vfs_set_dos_attrib_xattr+0x39/0x50 [ksmbd]
[ 8743.394010] smb2_open+0x3432/0x3cc0 [ksmbd]
[ 8743.394099] handle_ksmbd_work+0x2c9/0x7b0 [ksmbd]
[ 8743.394187] process_one_work+0x65a/0xb30
[ 8743.394198] worker_thread+0x2cf/0x700
[ 8743.394209] kthread+0x1ad/0x1f0
[ 8743.394218] ret_from_fork+0x29/0x50
This patch add mnt_want_write() above parent inode lock and remove
nested mnt_want_write calls in smb2_open().
Fixes: 40b268d384a2 ("ksmbd: add mnt_want_write to ksmbd vfs functions")
Cc: stable@vger.kernel.org
Reported-by: Marios Makassikis <mmakassikis@freebox.fr>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-12-23 10:41:59 +01:00
2023-11-28 16:56:19 +00:00
2023-02-01 08:27:06 +01:00
2023-12-20 15:17:34 +01:00
2023-09-23 11:09:54 +02:00
2021-08-19 09:02:55 +09:00
2023-12-20 15:17:41 +01:00
2022-07-02 16:41:14 +02:00
2023-10-19 23:05:36 +02:00
2023-12-13 18:36:50 +01:00
2023-03-10 09:39:50 +01:00
2022-12-31 13:14:15 +01:00
2022-11-10 18:15:37 +01:00
2022-12-31 13:14:03 +01:00
2022-02-01 17:27:01 +01:00
2023-09-19 12:22:52 +02:00
2022-07-02 16:41:14 +02:00
2023-09-06 21:28:37 +01:00
2023-11-28 16:56:19 +00:00
2022-06-09 10:23:32 +02:00
2023-09-23 11:09:57 +02:00
2023-12-20 15:17:41 +01:00
2023-11-28 16:56:34 +00:00
2022-06-09 10:22:42 +02:00
2021-10-04 22:13:12 +01:00
2023-12-20 15:17:38 +01:00
2023-11-28 16:56:22 +00:00
2023-03-10 09:39:57 +01:00
2023-05-24 17:36:43 +01:00
2021-08-26 22:28:02 +02:00
2022-12-31 13:14:44 +01:00
2023-12-08 08:48:05 +01:00
2021-11-12 15:05:50 +01:00
2023-11-28 16:56:30 +00:00
2023-07-23 13:47:34 +02:00
2023-11-28 16:56:18 +00:00
2023-07-23 13:47:23 +02:00
2023-12-23 10:41:59 +01:00
2023-09-19 12:22:43 +02:00
2022-04-13 20:59:10 +02:00
2021-12-29 12:28:59 +01:00
2023-11-28 16:56:21 +00:00
2021-10-04 22:02:17 +01:00
2023-11-28 16:56:34 +00:00
2023-12-13 18:36:43 +01:00
2023-09-19 12:22:27 +02:00
2023-07-23 13:47:36 +02:00
2022-11-26 09:24:52 +01:00
2023-11-08 17:26:46 +01:00
2023-09-19 12:22:34 +02:00
2022-12-31 13:14:44 +01:00
2023-11-28 16:56:29 +00:00
2023-12-03 07:31:24 +01:00
2023-11-20 11:08:13 +01:00
2021-09-21 08:36:48 -07:00
2023-11-28 16:56:31 +00:00
2023-07-23 13:47:33 +02:00
2023-09-19 12:22:30 +02:00
2021-12-14 10:57:12 +01:00
2023-02-22 12:57:07 +01:00
2023-08-11 15:13:58 +02:00
2023-09-23 11:10:02 +02:00
2023-05-17 11:50:14 +02:00
2023-09-19 12:22:53 +02:00
2021-08-19 09:02:55 +09:00
2021-09-27 11:26:21 -07:00
2023-09-19 12:22:52 +02:00
2023-11-28 16:56:26 +00:00
2023-04-05 11:25:01 +02:00
2023-02-22 12:57:05 +01:00
2023-09-23 11:10:01 +02:00
2021-09-05 10:15:05 -07:00
2023-10-06 13:18:24 +02:00
2022-11-03 23:59:12 +09:00
2022-06-09 10:22:26 +02:00
2022-12-31 13:14:39 +01:00
2022-11-26 09:24:51 +01:00
2022-12-31 13:14:30 +01:00
2022-04-08 14:24:18 +02:00
2021-09-02 10:07:29 -07:00
2022-09-28 11:11:56 +02:00
2021-09-03 09:58:10 -07:00
2023-09-19 12:22:30 +02:00
2023-06-21 15:59:14 +02:00
2022-11-03 23:59:12 +09:00
2021-09-03 10:08:28 -07:00
2022-10-26 12:34:58 +02:00
2023-08-11 15:13:58 +02:00
2021-08-23 01:25:40 -04:00
2023-07-23 13:47:34 +02:00
2021-09-07 16:07:47 -04:00
2023-11-20 11:08:13 +01:00
2023-12-08 08:48:04 +01:00
2023-08-30 16:18:19 +02:00
2022-05-25 09:57:26 +02:00
2021-09-12 10:10:21 -07:00
2021-10-18 20:22:03 -10:00
2022-12-31 13:14:03 +01:00
2023-09-23 11:09:55 +02:00
2022-12-14 11:37:31 +01:00
2023-01-12 11:59:20 +01:00
2023-12-23 10:41:55 +01:00
2023-04-13 16:48:25 +02:00
2023-08-11 15:13:57 +02:00
2022-06-06 08:43:37 +02:00
2023-01-12 11:58:47 +01:00
2022-07-02 16:41:17 +02:00
2022-07-02 16:41:14 +02:00
2022-12-19 12:36:39 +01:00
2022-07-21 21:24:14 +02:00
2022-01-29 10:58:25 +01:00
2022-07-12 16:35:08 +02:00
2021-12-14 10:57:15 +01:00
2022-10-26 12:34:17 +02:00
2022-04-27 14:38:57 +02:00
2023-05-24 17:36:54 +01:00
2023-08-11 15:13:58 +02:00
2022-04-27 14:38:50 +02:00
2022-10-26 12:34:36 +02:00
2022-12-31 13:14:01 +01:00
8ed1118da8