Christian Brauner 8f203dd401 ovl: check type and offset of struct vfsmount in ovl_entry
[ Upstream commit f723edb8a532cd26e1ff0a2b271d73762d48f762 ]

Porting overlayfs to the new amount api I started experiencing random
crashes that couldn't be explained easily. So after much debugging and
reasoning it became clear that struct ovl_entry requires the point to
struct vfsmount to be the first member and of type struct vfsmount.

During the port I added a new member at the beginning of struct
ovl_entry which broke all over the place in the form of random crashes
and cache corruptions. While there's a comment in ovl_free_fs() to the
effect of "Hack! Reuse ofs->layers as a vfsmount array before freeing
it" there's no such comment on struct ovl_entry which makes this easy to
trip over.

Add a comment and two static asserts for both the offset and the type of
pointer in struct ovl_entry.

Signed-off-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-08-30 16:27:09 +02:00
..
2023-06-21 15:44:12 +02:00
2023-08-11 11:53:59 +02:00
2021-09-22 12:26:25 +02:00
2023-07-27 08:37:03 +02:00
2022-06-14 18:11:36 +02:00
2023-07-27 08:37:06 +02:00
2023-08-30 16:27:09 +02:00
2023-02-22 12:50:35 +01:00
2022-06-14 18:11:41 +02:00
2020-10-01 13:17:19 +02:00
2023-07-27 08:37:26 +02:00
2023-01-18 11:41:44 +01:00