8d89cf6ff2
SND_SOC_QCOM_COMMON depends on SOUNDWIRE for some symbols but this
is not explicitly specified using Kconfig depends. On the other hand
SND_SOC_QCOM_COMMON is also directly selected by the sound card
Kconfigs, this could result in various combinations and some symbols
ending up in modules and soundcard that uses those symbols as in-build
driver.
Fix these issues by explicitly specifying the dependencies of
SND_SOC_QCOM_COMMON and also use imply a to select SND_SOC_QCOM_COMMON
so that the symbol is selected based on its dependencies.
Also remove dummy stubs in common.c around CONFIG_SOUNDWIRE
Fixes: 3bd975f3ae0a ("ASoC: qcom: sm8250: move some code to common")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20221124140351.407506-1-srinivas.kandagatla@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
24 lines
807 B
C
24 lines
807 B
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
// Copyright (c) 2018, The Linux Foundation. All rights reserved.
|
|
|
|
#ifndef __QCOM_SND_COMMON_H__
|
|
#define __QCOM_SND_COMMON_H__
|
|
|
|
#include <sound/soc.h>
|
|
#include <linux/soundwire/sdw.h>
|
|
|
|
int qcom_snd_parse_of(struct snd_soc_card *card);
|
|
int qcom_snd_wcd_jack_setup(struct snd_soc_pcm_runtime *rtd,
|
|
struct snd_soc_jack *jack, bool *jack_setup);
|
|
|
|
int qcom_snd_sdw_prepare(struct snd_pcm_substream *substream,
|
|
struct sdw_stream_runtime *runtime,
|
|
bool *stream_prepared);
|
|
int qcom_snd_sdw_hw_params(struct snd_pcm_substream *substream,
|
|
struct snd_pcm_hw_params *params,
|
|
struct sdw_stream_runtime **psruntime);
|
|
int qcom_snd_sdw_hw_free(struct snd_pcm_substream *substream,
|
|
struct sdw_stream_runtime *sruntime,
|
|
bool *stream_prepared);
|
|
#endif
|