899b2608d8
The debugfs code is provided an array of a single drm_connector. Then to access the connector, the list of all connectors of the DRM device is traversed and all non-DisplayPort connectors are skipped, to find the one and only DisplayPort connector. But as we move to support multiple DisplayPort controllers this will now find multiple connectors and has no way to distinguish them. Pass the single connector to dp_debug_get() and use this in the debugfs functions instead, both to simplify the code and the support the multiple instances. Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org> Reviewed-by: Stephen Boyd <swboyd@chromium.org> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Link: https://lore.kernel.org/r/20211015232213.1839472-1-bjorn.andersson@linaro.org Signed-off-by: Rob Clark <robdclark@chromium.org>
75 lines
1.8 KiB
C
75 lines
1.8 KiB
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
/*
|
|
* Copyright (c) 2017-2020, The Linux Foundation. All rights reserved.
|
|
*/
|
|
|
|
#ifndef _DP_DEBUG_H_
|
|
#define _DP_DEBUG_H_
|
|
|
|
#include "dp_panel.h"
|
|
#include "dp_link.h"
|
|
|
|
/**
|
|
* struct dp_debug
|
|
* @debug_en: specifies whether debug mode enabled
|
|
* @vdisplay: used to filter out vdisplay value
|
|
* @hdisplay: used to filter out hdisplay value
|
|
* @vrefresh: used to filter out vrefresh value
|
|
* @tpg_state: specifies whether tpg feature is enabled
|
|
*/
|
|
struct dp_debug {
|
|
bool debug_en;
|
|
int aspect_ratio;
|
|
int vdisplay;
|
|
int hdisplay;
|
|
int vrefresh;
|
|
};
|
|
|
|
#if defined(CONFIG_DEBUG_FS)
|
|
|
|
/**
|
|
* dp_debug_get() - configure and get the DisplayPlot debug module data
|
|
*
|
|
* @dev: device instance of the caller
|
|
* @panel: instance of panel module
|
|
* @usbpd: instance of usbpd module
|
|
* @link: instance of link module
|
|
* @connector: double pointer to display connector
|
|
* @minor: pointer to drm minor number after device registration
|
|
* return: pointer to allocated debug module data
|
|
*
|
|
* This function sets up the debug module and provides a way
|
|
* for debugfs input to be communicated with existing modules
|
|
*/
|
|
struct dp_debug *dp_debug_get(struct device *dev, struct dp_panel *panel,
|
|
struct dp_usbpd *usbpd, struct dp_link *link,
|
|
struct drm_connector *connector,
|
|
struct drm_minor *minor);
|
|
|
|
/**
|
|
* dp_debug_put()
|
|
*
|
|
* Cleans up dp_debug instance
|
|
*
|
|
* @dp_debug: instance of dp_debug
|
|
*/
|
|
void dp_debug_put(struct dp_debug *dp_debug);
|
|
|
|
#else
|
|
|
|
static inline
|
|
struct dp_debug *dp_debug_get(struct device *dev, struct dp_panel *panel,
|
|
struct dp_usbpd *usbpd, struct dp_link *link,
|
|
struct drm_connector *connector, struct drm_minor *minor)
|
|
{
|
|
return ERR_PTR(-EINVAL);
|
|
}
|
|
|
|
static inline void dp_debug_put(struct dp_debug *dp_debug)
|
|
{
|
|
}
|
|
|
|
#endif /* defined(CONFIG_DEBUG_FS) */
|
|
|
|
#endif /* _DP_DEBUG_H_ */
|