linux

iv/linux

History

Yafang Shao 9067d90006 cgroup: Eliminate the need for cgroup_mutex in proc_cgroup_show()

The cgroup root_list is already RCU-safe. Therefore, we can replace the
cgroup_mutex with the RCU read lock in some particular paths. This change
will be particularly beneficial for frequent operations, such as
`cat /proc/self/cgroup`, in a cgroup1-based container environment.

I did stress tests with this change, as outlined below
(with CONFIG_PROVE_RCU_LIST enabled):

- Continuously mounting and unmounting named cgroups in some tasks,
  for example:

  cgrp_name=$1
  while true
  do
      mount -t cgroup -o none,name=$cgrp_name none /$cgrp_name
      umount /$cgrp_name
  done

- Continuously triggering proc_cgroup_show() in some tasks concurrently,
  for example:
  while true; do cat /proc/self/cgroup > /dev/null; done

They can ran successfully after implementing this change, with no RCU
warnings in dmesg.

Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>

2023-11-09 13:25:47 -10:00

cgroup-internal.h

cgroup: Make operations on the cgroup root_list RCU safe

2023-11-09 13:25:47 -10:00

cgroup-v1.c

cgroup: Remove duplicates in cgroup v1 tasks file

2023-10-09 06:42:05 -10:00

cgroup.c

cgroup: Eliminate the need for cgroup_mutex in proc_cgroup_show()

2023-11-09 13:25:47 -10:00

cpuset.c

cgroup/cpuset: Cleanup signedness issue in cpu_exclusive_check()