iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/mm
History
Michal Hocko 698d0831ba vmalloc: fix __GFP_HIGHMEM usage for vmalloc_32 on 32b systems 
Kai Heng Feng has noticed that BUG_ON(PageHighMem(pg)) triggers in
drivers/media/common/saa7146/saa7146_core.c since 19809c2da28a ("mm,
vmalloc: use __GFP_HIGHMEM implicitly").

saa7146_vmalloc_build_pgtable uses vmalloc_32 and it is reasonable to
expect that the resulting page is not in highmem.  The above commit
aimed to add __GFP_HIGHMEM only for those requests which do not specify
any zone modifier gfp flag.  vmalloc_32 relies on GFP_VMALLOC32 which
should do the right thing.  Except it has been missed that GFP_VMALLOC32
is an alias for GFP_KERNEL on 32b architectures.  Thanks to Matthew to
notice this.

Fix the problem by unconditionally setting GFP_DMA32 in GFP_VMALLOC32
for !64b arches (as a bailout).  This should do the right thing and use
ZONE_NORMAL which should be always below 4G on 32b systems.

Debugged by Matthew Wilcox.

[akpm@linux-foundation.org: coding-style fixes]
Link: http://lkml.kernel.org/r/20180212095019.GX21609@dhcp22.suse.cz
Fixes: 19809c2da28a ("mm, vmalloc: use __GFP_HIGHMEM implicitly”)
Signed-off-by: Michal Hocko <mhocko@suse.com>
Reported-by: Kai Heng Feng <kai.heng.feng@canonical.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Laura Abbott <labbott@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-02-21 15:35:43 -08:00
..
kasan
kasan: fix prototype author email address
2018-02-06 18:32:43 -08:00
backing-dev.c
Revert "bdi: add error handle for bdi_debug_register"
2017-12-21 10:01:30 -07:00
balloon_compaction.c
virtio_balloon: fix deadlock on OOM
2017-11-14 23:57:38 +02:00
bootmem.c
mm: docs: fix parameter names mismatch
2018-02-06 18:32:48 -08:00
cleancache.c
fs: switch ->s_uuid to uuid_t
2017-06-05 16:59:12 +02:00
cma_debug.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
cma.c
mm/cma.c: change pr_info to pr_err for cma_alloc fail log
2017-11-15 18:21:03 -08:00
cma.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
compaction.c
mm/compaction.c: fix comment for try_to_compact_pages()
2018-01-31 17:18:39 -08:00
debug_page_ref.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
debug.c
mm/debug.c: provide useful debugging information for VM_BUG
2018-01-04 16:45:09 -08:00
dmapool.c
lib/vsprintf.c: remove %Z support
2017-02-27 18:43:47 -08:00
early_ioremap.c
mm/early_ioremap: Fix boot hang with earlyprintk=efi,keep
2017-12-11 14:54:44 +01:00
fadvise.c
mm/fadvise: discard partial page if endbyte is also EOF
2018-01-31 17:18:39 -08:00
failslab.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
filemap.c
mm/filemap.c: remove include of hardirq.h
2018-01-31 17:18:36 -08:00
frame_vector.c
mm/frame_vector.c: release a semaphore in 'get_vaddr_frames()'
2017-12-14 16:00:48 -08:00
frontswap.c
mm, frontswap: convert frontswap_enabled to static key
2016-07-26 16:19:19 -07:00
gup_benchmark.c
mm: add infrastructure for get_user_pages_fast() benchmarking
2017-11-17 16:10:04 -08:00
gup.c
libnvdimm for 4.16
2018-02-06 10:41:33 -08:00
highmem.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
hmm.c
libnvdimm for 4.16
2018-02-06 10:41:33 -08:00
huge_memory.c
mm/thp: remove pmd_huge_split_prepare()
2018-01-31 17:18:38 -08:00
hugetlb_cgroup.c
mm, hugetlb_cgroup: round limit_in_bytes down to hugepage size
2016-05-20 17:58:30 -07:00
hugetlb.c
hugetlb, mbind: fall back to default policy if vma is NULL
2018-01-31 17:18:40 -08:00
hwpoison-inject.c
mm/memory_failure: Remove unused trapno from memory_failure
2018-01-23 12:17:42 -06:00
init-mm.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
internal.h
Revert "mm, thp: Do not make pmd/pud dirty without a reason"
2017-11-29 09:01:01 -08:00
interval_tree.c
mm/interval_tree.c: use vma_pages() helper
2018-01-31 17:18:37 -08:00
Kconfig
mm: relax deferred struct page requirements
2018-01-31 17:18:36 -08:00
Kconfig.debug
kmemcheck: rip it out
2017-11-15 18:21:05 -08:00
khugepaged.c
mm: thp: use down_read_trylock() in khugepaged to avoid long block
2018-01-31 17:18:38 -08:00
kmemleak-test.c
mm: convert printk(KERN_<LEVEL> to pr_<level>
2016-03-17 15:09:34 -07:00
kmemleak.c
mm: kmemleak: remove unused hardirq.h
2018-01-31 17:18:36 -08:00
ksm.c
mm: docs: fixup punctuation
2018-02-06 18:32:48 -08:00
list_lru.c
mm/list_lru.c: mark expected switch fall-through
2017-11-15 18:21:07 -08:00
maccess.c
mm: docs: fix parameter names mismatch
2018-02-06 18:32:48 -08:00
madvise.c
mm/memory_failure: Remove unused trapno from memory_failure
2018-01-23 12:17:42 -06:00
Makefile
mm: add infrastructure for get_user_pages_fast() benchmarking
2017-11-17 16:10:04 -08:00
memblock.c
mm/memblock: memblock_is_map/region_memory can be boolean
2018-02-06 18:32:47 -08:00
memcontrol.c
vfs: do bulk POLL* -> EPOLL* replacement
2018-02-11 14:34:03 -08:00
memory_hotplug.c
libnvdimm for 4.16
2018-02-06 10:41:33 -08:00
memory-failure.c
x86/mm, mm/hwpoison: Don't unconditionally unmap kernel 1:1 pages
2018-02-13 16:25:06 +01:00
memory.c
mm: hide a #warning for COMPILE_TEST
2018-02-16 09:41:36 -08:00
mempolicy.c
hugetlb, mbind: fall back to default policy if vma is NULL
2018-01-31 17:18:40 -08:00
mempool.c
kasan: detect invalid frees for large mempool objects
2018-02-06 18:32:43 -08:00
memtest.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
migrate.c
mm, hugetlb: do not rely on overcommit limit during migration
2018-01-31 17:18:40 -08:00
mincore.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
mlock.c
mm, mlock, vmscan: no more skipping pagevecs
2018-02-21 15:35:42 -08:00
mm_init.c
mm: convert printk(KERN_<LEVEL> to pr_<level>
2016-03-17 15:09:34 -07:00
mmap.c
mm, oom_reaper: fix memory corruption
2017-12-14 16:00:49 -08:00
mmu_context.c
sched/headers: Prepare to move the task_lock()/unlock() APIs to <linux/sched/task.h>
2017-03-02 08:42:38 +01:00
mmu_notifier.c
mm, mmu_notifier: annotate mmu notifiers with blockable invalidate callbacks
2018-01-31 17:18:38 -08:00
mmzone.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
mprotect.c
mm: numa: do not trap faults on shared data section pages.
2018-01-31 17:18:40 -08:00
mremap.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
msync.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
nobootmem.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
nommu.c
mm: docs: fixup punctuation
2018-02-06 18:32:48 -08:00
oom_kill.c
mm, oom: avoid reaping only for mm's with blockable invalidate callbacks
2018-01-31 17:18:38 -08:00
page_alloc.c
libnvdimm for 4.16
2018-02-06 10:41:33 -08:00
page_counter.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
page_ext.c
mm/page_ext.c: make page_ext_init a noop when CONFIG_PAGE_EXTENSION but nothing uses it
2018-01-31 17:18:39 -08:00
page_idle.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
page_io.c
block: convert to bio_first_bvec_all & bio_first_page_all
2018-01-06 09:18:00 -07:00
page_isolation.c
mm: distinguish CMA and MOVABLE isolation in has_unmovable_pages()
2017-11-15 18:21:02 -08:00
page_owner.c
mm/page_owner.c: clean up init_pages_in_zone()
2018-01-31 17:18:39 -08:00
page_poison.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
page_vma_mapped.c
mm, page_vma_mapped: Introduce pfn_in_hpage()
2018-01-22 12:15:57 -08:00
page-writeback.c
Revert "mm/page-writeback.c: print a warning if the vm dirtiness settings are illogical"
2017-11-29 18:40:43 -08:00
pagewalk.c
mm: docs: add blank lines to silence sphinx "Unexpected indentation" errors
2018-02-06 18:32:48 -08:00
percpu-internal.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
percpu-km.c
percpu: replace area map allocator with bitmap
2017-07-26 17:41:05 -04:00
percpu-stats.c
percpu: fix starting offset for chunk statistics traversal
2017-09-27 14:45:57 -07:00
percpu-vm.c
mm: remove __GFP_COLD
2017-11-15 18:21:06 -08:00
percpu.c
percpu: hack to let the CRIS architecture to boot until they clean up
2017-11-27 12:53:12 -08:00
pgtable-generic.c
mm: do not lose dirty and accessed bits in pmdp_invalidate()
2018-01-31 17:18:38 -08:00
process_vm_access.c
mm: docs: add blank lines to silence sphinx "Unexpected indentation" errors
2018-02-06 18:32:48 -08:00
quicklist.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
readahead.c
mm: don't cap request size based on read-ahead setting
2016-12-12 18:55:08 -08:00
rmap.c
mm: remove cold parameter from free_hot_cold_page*
2017-11-15 18:21:06 -08:00
rodata_test.c
mm: fix RODATA_TEST failure "rodata_test: test data was not read only"
2017-10-03 17:54:24 -07:00
shmem.c
shmem: add sealing support to hugetlb-backed memfd
2018-01-31 17:18:39 -08:00
slab_common.c
Currently, hardened usercopy performs dynamic bounds checking on slab
2018-02-03 16:25:42 -08:00
slab.c
kasan: don't use __builtin_return_address(1)
2018-02-06 18:32:43 -08:00
slab.h
Currently, hardened usercopy performs dynamic bounds checking on slab
2018-02-03 16:25:42 -08:00
slob.c
slab, slub, slob: add slab_flags_t
2017-11-15 18:21:01 -08:00
slub.c
kasan: don't use __builtin_return_address(1)
2018-02-06 18:32:43 -08:00
sparse-vmemmap.c
mm: merge vmem_altmap_alloc into altmap_alloc_block_buf
2018-01-08 11:46:23 -08:00
sparse.c
libnvdimm for 4.16
2018-02-06 10:41:33 -08:00
swap_cgroup.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
swap_slots.c
mm/swap_slots.c: fix race conditions in swap_slots cache init
2017-11-15 18:21:03 -08:00
swap_state.c
mm: remove cold parameter for release_pages
2017-11-15 18:21:06 -08:00
swap.c
mm/swap.c: make functions and their kernel-doc agree (again)
2018-02-21 15:35:43 -08:00
swapfile.c
vfs: do bulk POLL* -> EPOLL* replacement
2018-02-11 14:34:03 -08:00
truncate.c
mm: add unmap_mapping_pages()
2018-01-31 17:18:37 -08:00
usercopy.c
usercopy: WARN() on slab cache usercopy region violations
2018-01-15 12:07:48 -08:00
userfaultfd.c
mm/userfaultfd.c: remove duplicate include
2018-02-06 18:32:47 -08:00
util.c
new primitive: vmemdup_user()
2018-01-07 13:06:15 -05:00
vmacache.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
vmalloc.c
vmalloc: fix __GFP_HIGHMEM usage for vmalloc_32 on 32b systems
2018-02-21 15:35:43 -08:00
vmpressure.c
mm, vmpressure: pass-through notification support
2017-07-10 16:32:31 -07:00
vmscan.c
mm, mlock, vmscan: no more skipping pagevecs
2018-02-21 15:35:42 -08:00
vmstat.c
mm, sysctl: make NUMA stats configurable
2017-11-15 18:21:07 -08:00
workingset.c
mm, truncate: do not check mapping for every page being truncated
2017-11-15 18:21:06 -08:00
z3fold.c
mm: docs: fix parameter names mismatch
2018-02-06 18:32:48 -08:00
zbud.c
mm: docs: fix parameter names mismatch
2018-02-06 18:32:48 -08:00
zpool.c
mm/zpool.c: zpool_evictable: fix mismatch in parameter name and kernel-doc
2018-02-21 15:35:43 -08:00
zsmalloc.c
zsmalloc: use U suffix for negative literals being shifted
2018-01-31 17:18:39 -08:00
zswap.c
mm, swap, frontswap: fix THP swap if frontswap enabled
2018-02-21 15:35:43 -08:00