James Bottomley
90a88d6ef8
scsi: fix soft lockup in scsi_remove_target() on module removal ...
This softlockup is currently happening:
[ 444.088002] NMI watchdog: BUG: soft lockup - CPU#1 stuck for 22s! [kworker/1:1:29]
[ 444.088002] Modules linked in: lpfc(-) qla2x00tgt(O) qla2xxx_scst(O) scst_vdisk(O) scsi_transport_fc libcrc32c scst(O) dlm configfs nfsd lockd grace nfs_acl auth_rpcgss sunrpc ed
d snd_pcm_oss snd_mixer_oss snd_seq snd_seq_device dm_mod iTCO_wdt snd_hda_codec_realtek snd_hda_codec_generic gpio_ich iTCO_vendor_support ppdev snd_hda_intel snd_hda_codec snd_hda
_core snd_hwdep tg3 snd_pcm snd_timer libphy lpc_ich parport_pc ptp acpi_cpufreq snd pps_core fjes parport i2c_i801 ehci_pci tpm_tis tpm sr_mod cdrom soundcore floppy hwmon sg 8250_
fintek pcspkr i915 drm_kms_helper uhci_hcd ehci_hcd drm fb_sys_fops sysimgblt sysfillrect syscopyarea i2c_algo_bit usbcore button video usb_common fan ata_generic ata_piix libata th
ermal
[ 444.088002] CPU: 1 PID: 29 Comm: kworker/1:1 Tainted: G O 4.4.0-rc5-2.g1e923a3-default #1
[ 444.088002] Hardware name: FUJITSU SIEMENS ESPRIMO E /D2164-A1, BIOS 5.00 R1.10.2164.A1 05/08/2006
[ 444.088002] Workqueue: fc_wq_4 fc_rport_final_delete [scsi_transport_fc]
[ 444.088002] task: f6266ec0 ti: f6268000 task.ti: f6268000
[ 444.088002] EIP: 0060:[<c07e7044>] EFLAGS: 00000286 CPU: 1
[ 444.088002] EIP is at _raw_spin_unlock_irqrestore+0x14/0x20
[ 444.088002] EAX: 00000286 EBX: f20d3800 ECX: 00000002 EDX: 00000286
[ 444.088002] ESI: f50ba800 EDI: f2146848 EBP: f6269ec8 ESP: f6269ec8
[ 444.088002] DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068
[ 444.088002] CR0: 8005003b CR2: 08f96600 CR3: 363ae000 CR4: 000006d0
[ 444.088002] Stack:
[ 444.088002] f6269eec c066b0f7 00000286 f2146848 f50ba808 f50ba800 f50ba800 f2146a90
[ 444.088002] f2146848 f6269f08 f8f0a4ed f3141000 f2146800 f2146a90 f619fa00 00000040
[ 444.088002] f6269f40 c026cb25 00000001 166c6392 00000061 f6757140 f6136340 00000004
[ 444.088002] Call Trace:
[ 444.088002] [<c066b0f7>] scsi_remove_target+0x167/0x1c0
[ 444.088002] [<f8f0a4ed>] fc_rport_final_delete+0x9d/0x1e0 [scsi_transport_fc]
[ 444.088002] [<c026cb25>] process_one_work+0x155/0x3e0
[ 444.088002] [<c026cde7>] worker_thread+0x37/0x490
[ 444.088002] [<c027214b>] kthread+0x9b/0xb0
[ 444.088002] [<c07e72c1>] ret_from_kernel_thread+0x21/0x40
What appears to be happening is that something has pinned the target
so it can't go into STARGET_DEL via final release and the loop in
scsi_remove_target spins endlessly until that happens.
The fix for this soft lockup is to not keep looping over a device that
we've called remove on but which hasn't gone into DEL state. This
patch will retain a simplistic memory of the last target and not keep
looping over it.
Reported-by: Sebastian Herbszt <herbszt@gmx.de>
Tested-by: Sebastian Herbszt <herbszt@gmx.de>
Fixes: 40998193560dab6c3ce8d25f4fa58a23e252ef38
Cc: stable@vger.kernel.org
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
2016-02-11 21:47:32 -08:00
2015-11-25 22:27:30 -05:00
2016-01-05 22:10:35 +01:00
2015-11-25 22:12:50 -05:00
2015-11-30 18:51:20 -05:00
2016-01-06 21:43:09 -05:00
2015-12-11 11:52:26 -08:00
2015-12-02 17:07:57 -05:00
2015-11-09 17:32:34 -08:00
2015-06-02 17:15:24 -07:00
2015-11-09 17:11:57 -08:00
2016-01-08 12:51:04 -05:00
2016-01-06 20:58:29 -05:00
2016-02-04 22:26:06 -05:00
2015-11-09 17:11:57 -08:00
2015-12-15 16:49:58 -05:00
2015-11-09 17:11:57 -08:00
2016-02-04 21:37:52 -08:00
2015-11-12 07:06:18 -05:00
2015-11-12 07:06:18 -05:00
2015-11-09 17:15:52 -08:00
2015-03-24 17:08:29 -07:00
2015-12-21 22:08:49 -05:00
2016-01-08 13:03:53 -05:00
2016-01-07 15:51:13 -08:00
2016-01-07 15:51:13 -08:00
2015-12-10 13:14:56 -05:00
2015-05-31 18:06:28 -07:00
2015-11-12 07:06:18 -05:00
2016-01-20 17:20:53 -08:00
2015-11-13 20:35:54 -08:00
2015-11-13 20:35:54 -08:00
2014-11-24 14:45:27 +01:00
2015-11-30 20:52:33 -05:00
2015-10-07 10:24:48 -07:00
2015-04-27 10:10:19 -07:00
2015-04-27 10:04:39 -07:00
2015-04-27 10:04:39 -07:00
2016-01-08 12:51:03 -05:00
2015-04-27 10:05:55 -07:00
2015-11-09 17:11:57 -08:00
2015-08-07 15:03:42 +02:00
2013-11-26 11:09:07 +01:00
2014-10-20 16:21:33 +02:00
2014-10-20 16:21:33 +02:00
2015-12-03 09:32:33 -08:00
2015-05-31 18:06:28 -07:00
2015-05-31 18:06:28 -07:00
2015-04-09 18:08:31 -07:00
2015-05-31 18:06:28 -07:00
2015-05-31 18:06:28 -07:00
2015-04-17 10:13:56 -07:00
2016-01-06 21:43:10 -05:00
2016-01-06 21:43:08 -05:00
2015-11-25 22:08:55 -05:00
2015-11-25 22:08:52 -05:00
2015-02-02 09:57:45 -08:00
2013-06-26 18:32:47 -07:00
2014-10-20 16:21:33 +02:00
2015-04-14 09:50:27 -07:00
2015-01-09 15:44:31 +01:00
2015-02-02 09:57:46 -08:00
2016-01-06 21:43:09 -05:00
2015-07-31 13:31:10 +02:00
2014-07-17 22:07:37 +02:00
2016-01-06 21:43:09 -05:00
2016-01-06 21:43:03 -05:00
2015-02-02 09:57:45 -08:00
2014-11-24 14:45:27 +01:00
2015-11-09 17:11:57 -08:00
2014-11-24 16:13:16 +01:00
2015-05-31 18:06:28 -07:00
2015-11-09 16:32:14 -08:00
2016-01-06 21:43:13 -05:00
2016-01-06 21:43:13 -05:00
2015-02-02 09:57:45 -08:00
2013-04-09 14:13:16 -04:00
2014-11-24 20:01:40 +01:00
2013-04-09 14:13:16 -04:00
2013-11-26 11:09:07 +01:00
2015-12-03 09:32:33 -08:00
2016-01-06 15:10:36 -05:00
2016-01-07 15:51:13 -08:00
2016-01-06 15:10:35 -05:00
2015-08-12 13:14:57 -07:00
2015-08-12 13:14:57 -07:00
2016-01-08 13:08:15 -05:00
2015-02-02 09:57:46 -08:00
2015-11-20 11:39:03 -05:00
2016-01-23 18:45:06 -08:00
2015-12-11 11:52:24 -08:00
2015-06-02 17:24:54 -07:00
2013-04-09 14:13:27 -04:00
2014-03-15 10:19:19 -07:00
2014-11-24 14:45:27 +01:00
2014-04-11 16:15:36 -04:00
2014-10-20 16:21:33 +02:00
2016-01-23 18:45:06 -08:00
2014-03-15 10:19:18 -07:00
2015-09-17 07:25:02 -07:00
2015-05-31 18:06:28 -07:00
2014-10-20 16:21:33 +02:00
2016-01-06 21:43:09 -05:00
2015-11-25 22:12:51 -05:00
2015-08-26 07:23:04 -07:00
2014-03-27 08:26:31 -07:00
2015-03-23 14:29:40 +11:00
2014-10-20 16:21:33 +02:00
2013-04-09 14:13:15 -04:00
2015-11-11 20:45:23 -05:00
2013-04-15 14:30:44 -06:00
2014-11-24 14:45:27 +01:00
2014-07-17 22:07:35 +02:00
2015-05-31 18:06:28 -07:00
2016-01-06 21:43:10 -05:00
2016-01-06 21:43:10 -05:00
2015-05-31 18:06:28 -07:00
2014-11-24 20:01:28 +01:00
2016-01-06 21:43:09 -05:00
2016-01-06 21:43:03 -05:00
2015-11-12 07:06:18 -05:00
2015-05-31 18:06:28 -07:00
2015-05-31 18:06:28 -07:00
2015-05-31 18:06:28 -07:00
2015-05-31 18:06:28 -07:00
2015-05-31 18:06:28 -07:00
2015-07-23 22:53:05 -07:00
2016-01-07 15:51:13 -08:00
2016-02-04 21:37:52 -08:00
2015-12-02 16:29:19 -05:00
2015-11-06 17:50:42 -08:00
2014-11-12 11:16:12 +01:00
2015-12-02 16:43:11 -05:00
2015-02-04 08:00:24 -08:00
2014-11-12 11:16:05 +01:00
2014-04-24 13:44:54 -04:00
2015-12-10 12:24:44 -05:00
2015-12-02 16:29:19 -05:00
2015-02-02 09:57:46 -08:00
2016-01-07 15:51:13 -08:00
2014-06-06 16:08:16 -07:00
2016-02-11 21:47:32 -08:00
2015-02-02 09:57:46 -08:00
2015-11-30 17:43:55 -05:00
2015-09-02 12:22:54 -07:00
2015-12-18 19:29:50 -08:00
2015-08-07 14:28:45 +02:00
2015-07-14 13:20:09 -04:00
2015-11-30 11:23:45 -05:00
2014-11-12 11:15:54 +01:00
2015-10-21 14:42:38 -06:00
2016-02-04 21:37:52 -08:00
2015-11-25 21:38:58 -05:00
2015-12-18 19:29:50 -08:00
2015-11-02 23:51:25 -05:00
2014-10-20 16:21:33 +02:00
2014-10-20 16:21:33 +02:00
2015-01-20 19:43:24 +01:00
2014-07-17 22:07:39 +02:00
2016-01-26 17:24:16 -08:00
2014-11-12 11:15:57 +01:00
2015-12-03 09:32:33 -08:00
2015-11-18 11:59:09 -05:00
2015-11-09 17:42:19 -08:00
2016-02-04 21:37:52 -08:00
2014-05-28 12:16:28 +02:00
2016-01-06 21:43:08 -05:00
2014-11-20 09:11:15 +01:00
2015-08-10 23:07:05 -04:00
2014-10-20 16:21:33 +02:00
2015-05-31 18:06:28 -07:00
2016-01-06 21:43:09 -05:00
2016-01-06 21:43:03 -05:00
2014-11-24 14:45:27 +01:00
2015-07-23 13:07:04 -07:00
2015-12-10 12:57:04 -05:00
2015-12-10 12:57:04 -05:00
2015-02-02 09:57:46 -08:00
2013-04-09 14:13:15 -04:00
2015-08-07 14:28:45 +02:00
2015-05-31 18:06:28 -07:00
2015-02-02 09:57:45 -08:00
2015-09-08 18:03:49 +01:00
2013-11-26 11:09:07 +01:00
90a88d6ef8