Julia Lawall 90f5dfcc6a drivers/net: Remove redundant test
In each case, ap is checked not to be NULL a few lines before.

A simplified version of the semantic patch that makes this change is as
follows: (http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
expression E;
position p1,p2;
@@

if (x@p1 == NULL || ...) { ... when forall
   return ...; }
... when != \(x=E\|x--\|x++\|--x\|++x\|x-=E\|x+=E\|x|=E\|x&=E\|&x\)
(
x@p2 == NULL
|
x@p2 != NULL
)

// another path to the test that is not through p1?
@s exists@
local idexpression r.x;
position r.p1,r.p2;
@@

... when != x@p1
(
x@p2 == NULL
|
x@p2 != NULL
)

@fix depends on !s@
position r.p1,r.p2;
expression x,E;
statement S1,S2;
@@

(
- if ((x@p2 != NULL) || ...)
  S1
|
- if ((x@p2 == NULL) && ...) S1
|
- BUG_ON(x@p2 == NULL);
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-12-25 18:03:28 -08:00
..
2008-12-09 00:44:29 -05:00
2008-11-29 20:42:28 -08:00
2008-12-13 11:25:49 -08:00
2008-11-30 10:03:36 -08:00
2008-12-01 19:55:25 -08:00
2008-11-01 09:50:12 -07:00
2008-11-30 10:03:37 -08:00
2008-12-09 08:28:36 -08:00
2008-12-25 18:03:28 -08:00
2008-10-27 19:15:41 +01:00
2008-11-19 21:40:23 -08:00
2008-11-04 08:18:19 -08:00
2008-11-30 10:03:37 -08:00
2008-11-01 09:49:46 -07:00
2008-11-17 19:11:26 +01:00
2008-10-28 21:47:17 +00:00