Rob Herring 914d9d831e of: dynamic: Refactor action prints to not use "%pOF" inside devtree_lock ...

While originally it was fine to format strings using "%pOF" while
holding devtree_lock, this now causes a deadlock.  Lockdep reports:

    of_get_parent from of_fwnode_get_parent+0x18/0x24
    ^^^^^^^^^^^^^
    of_fwnode_get_parent from fwnode_count_parents+0xc/0x28
    fwnode_count_parents from fwnode_full_name_string+0x18/0xac
    fwnode_full_name_string from device_node_string+0x1a0/0x404
    device_node_string from pointer+0x3c0/0x534
    pointer from vsnprintf+0x248/0x36c
    vsnprintf from vprintk_store+0x130/0x3b4

Fix this by moving the printing in __of_changeset_entry_apply() outside
the lock. As the only difference in the multiple prints is the action
name, use the existing "action_names" to refactor the prints into a
single print.

Fixes: a92eb7621b9fb2c2 ("lib/vsprintf: Make use of fwnode API to obtain node names and separators")
Cc: stable@vger.kernel.org
Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20230801-dt-changeset-fixes-v3-2-5f0410e007dd@kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>

2023-08-21 09:23:55 -05:00

..

unittest-data

of/address: Add support for 3 address cell bus

2023-04-13 17:46:35 -05:00

address.c

dma-mapping updates for Linux 6.4

2023-04-29 10:29:57 -07:00

base.c

Char/Misc drivers for 6.4-rc1

2023-04-27 12:07:50 -07:00

cpu.c

of: Move CPU node related functions to their own file

2023-04-13 17:46:34 -05:00

device.c

of: device: Kill of_device_request_module()

2023-04-05 19:41:11 +02:00

dynamic.c

of: dynamic: Refactor action prints to not use "%pOF" inside devtree_lock

2023-08-21 09:23:55 -05:00

fdt_address.c

…

fdt.c

Devicetree fixes for 6.4, part 1:

2023-05-05 13:27:59 -07:00

irq.c

of/irq: add missing of_node_put() for interrupt parent node

2023-01-18 11:31:42 -06:00

Kconfig

of: make OF_EARLY_FLATTREE depend on HAS_IOMEM

2023-07-10 08:48:35 -06:00

kexec.c

mm,ima,kexec,of: use memblock_free_late from ima_free_kexec_buffer

2023-08-18 11:47:45 -05:00

kobj.c

of: make of_node_ktype constant

2023-02-06 11:03:00 -06:00

Makefile

Char/Misc drivers for 6.4-rc1

2023-04-27 12:07:50 -07:00

module.c

of: Move the request module helper logic to module.c

2023-04-05 19:41:10 +02:00

of_numa.c

of, numa: Fetch empty NUMA node ID from distance map

2021-10-04 13:13:44 -05:00

of_private.h

of: Make devtree_lock declaration private

2023-04-10 18:32:31 -05:00

of_reserved_mem.c

of: reserved_mem: Use stable allocation order

2023-06-20 09:34:58 -06:00

overlay.c

of: overlay: Fix missing of_node_put() in error case of init_overlay_changeset()

2023-06-09 16:12:37 -06:00

pdt.c

…

platform.c

of: Preserve "of-display" device name for compatibility

2023-07-11 16:33:01 -06:00

property.c

Devicetree updates for v6.3:

2023-02-24 13:31:53 -08:00

resolver.c

of: overlay: log the error cause on resolver failure

2020-03-02 11:32:44 -06:00

unittest.c

of: unittest: Fix EXPECT for parse_phandle_with_args_map() test

2023-08-21 09:23:38 -05:00