Eric Dumazet 4179cb5a4c vxlan: test dev->flags & IFF_UP before calling netif_rx()
netif_rx() must be called under a strict contract.

At device dismantle phase, core networking clears IFF_UP
and flush_all_backlogs() is called after rcu grace period
to make sure no incoming packet might be in a cpu backlog
and still referencing the device.

Most drivers call netif_rx() from their interrupt handler,
and since the interrupts are disabled at device dismantle,
netif_rx() does not have to check dev->flags & IFF_UP

Virtual drivers do not have this guarantee, and must
therefore make the check themselves.

Otherwise we risk use-after-free and/or crashes.

Note this patch also fixes a small issue that came
with commit ce6502a8f957 ("vxlan: fix a use after free
in vxlan_encap_bypass"), since the dev->stats.rx_dropped
change was done on the wrong device.

Fixes: d342894c5d2f ("vxlan: virtual extensible lan")
Fixes: ce6502a8f957 ("vxlan: fix a use after free in vxlan_encap_bypass")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Petr Machata <petrm@mellanox.com>
Cc: Ido Schimmel <idosch@mellanox.com>
Cc: Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-02-11 12:39:51 -08:00
..
2019-01-26 15:03:43 -08:00
2019-02-08 10:53:44 -08:00
2019-01-20 09:12:50 +12:00
2018-12-31 17:32:35 -08:00
2018-12-29 08:20:44 -07:00
2019-01-25 13:03:34 -10:00
2019-02-08 10:32:49 +10:00
2019-01-09 19:20:31 -05:00
2019-01-11 00:15:04 +01:00
2019-01-26 11:14:25 +01:00
2019-01-30 09:30:03 -08:00
2019-02-01 16:56:30 -08:00
2019-02-06 17:24:37 -05:00
2019-01-05 11:30:37 -08:00
2018-12-28 16:52:18 -08:00
2019-02-01 15:53:54 +01:00
2019-01-26 12:42:41 -08:00
2019-01-31 23:06:17 -08:00
2019-01-05 11:23:17 -08:00
2019-01-25 12:57:09 -10:00
2018-12-29 13:03:29 -08:00
2018-12-24 12:06:56 +01:00
2019-01-01 13:24:31 -08:00
2019-02-02 10:12:53 -08:00
2019-01-22 20:54:00 -05:00
2018-12-31 13:06:30 -08:00
2019-02-08 10:49:55 -08:00
2018-12-28 20:54:57 -08:00
2019-01-28 22:53:09 -08:00
2019-01-25 12:58:40 -10:00
2018-12-29 13:40:29 -08:00