Ian Abbott 922b67c1ac staging: comedi: ni_labpc: fix possible NULL deref during detach
`labpc_common_detach()` is called by the comedi core to clean up if
either `labpc_attach()` (including the one in the "ni_labpc_cs" module)
or `labpc_attach_pci()` returns an error.  It assumes the `thisboard`
macro (expanding to `((struct labpc_board_struct *)dev->board_ptr)`) is
non-null.  This is a valid assumption if `labpc_attach()` fails, but not
if `labpc_attach_pci()` fails, leading to a possible NULL pointer
dereference.

Check `thisboard` at the top of `labpc_common_detach()` and return early
if it is `NULL`.  This is okay because the only other thing that could
have been allocated is `dev->private` and that is freed by the comedi
core, not by this function.

Cc: <stable@vger.kernel.org> # 3.6.x
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 11:46:35 -07:00
..
2012-10-02 17:26:42 -07:00
2012-10-07 20:55:16 +09:00
2012-10-12 10:21:02 +09:00
2012-10-11 00:45:21 -07:00
2012-10-08 06:33:44 +09:00
2012-10-13 13:22:01 -07:00
2012-10-07 17:29:24 +09:00
2012-10-10 20:15:24 +09:00
2012-10-12 13:56:52 -04:00
2012-10-03 09:44:08 -07:00
2012-10-09 16:11:46 +09:00
2012-10-01 19:11:38 -07:00
2012-10-10 20:15:24 +09:00
2012-10-13 10:57:01 +09:00
2012-10-01 19:11:38 -07:00
2012-10-13 11:16:58 +09:00
2012-10-12 10:21:02 +09:00
2012-10-01 12:09:59 -07:00
2012-10-12 22:20:28 +09:00
2012-10-01 18:46:13 -07:00