b20172ca6b
If CONFIG_SERIAL_CORE_CONSOLE is not set, we get build errors.
Let's fix the issue by moving the endif after the serial base console
functions.
Fixes: 4547cd76f0
("serial: 8250: Fix add preferred console for serial8250_isa_init_ports()")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202404131416.VJljwvkS-lkp@intel.com/
Signed-off-by: Tony Lindgren <tony@atomide.com>
Link: https://lore.kernel.org/r/20240413103343.24231-1-tony@atomide.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
377 lines
8.3 KiB
C
377 lines
8.3 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Serial base bus layer for controllers
|
|
*
|
|
* Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
|
|
* Author: Tony Lindgren <tony@atomide.com>
|
|
*
|
|
* The serial core bus manages the serial core controller instances.
|
|
*/
|
|
|
|
#include <linux/cleanup.h>
|
|
#include <linux/container_of.h>
|
|
#include <linux/device.h>
|
|
#include <linux/idr.h>
|
|
#include <linux/module.h>
|
|
#include <linux/serial_core.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/spinlock.h>
|
|
|
|
#include "serial_base.h"
|
|
|
|
static bool serial_base_initialized;
|
|
|
|
static const struct device_type serial_ctrl_type = {
|
|
.name = "ctrl",
|
|
};
|
|
|
|
static const struct device_type serial_port_type = {
|
|
.name = "port",
|
|
};
|
|
|
|
static int serial_base_match(struct device *dev, struct device_driver *drv)
|
|
{
|
|
if (dev->type == &serial_ctrl_type &&
|
|
str_has_prefix(drv->name, serial_ctrl_type.name))
|
|
return 1;
|
|
|
|
if (dev->type == &serial_port_type &&
|
|
str_has_prefix(drv->name, serial_port_type.name))
|
|
return 1;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct bus_type serial_base_bus_type = {
|
|
.name = "serial-base",
|
|
.match = serial_base_match,
|
|
};
|
|
|
|
int serial_base_driver_register(struct device_driver *driver)
|
|
{
|
|
driver->bus = &serial_base_bus_type;
|
|
|
|
return driver_register(driver);
|
|
}
|
|
|
|
void serial_base_driver_unregister(struct device_driver *driver)
|
|
{
|
|
driver_unregister(driver);
|
|
}
|
|
|
|
static int serial_base_device_init(struct uart_port *port,
|
|
struct device *dev,
|
|
struct device *parent_dev,
|
|
const struct device_type *type,
|
|
void (*release)(struct device *dev),
|
|
unsigned int ctrl_id,
|
|
unsigned int port_id)
|
|
{
|
|
device_initialize(dev);
|
|
dev->type = type;
|
|
dev->parent = parent_dev;
|
|
dev->bus = &serial_base_bus_type;
|
|
dev->release = release;
|
|
|
|
if (!serial_base_initialized) {
|
|
dev_dbg(port->dev, "uart_add_one_port() called before arch_initcall()?\n");
|
|
return -EPROBE_DEFER;
|
|
}
|
|
|
|
if (type == &serial_ctrl_type)
|
|
return dev_set_name(dev, "%s:%d", dev_name(port->dev), ctrl_id);
|
|
|
|
if (type == &serial_port_type)
|
|
return dev_set_name(dev, "%s:%d.%d", dev_name(port->dev),
|
|
ctrl_id, port_id);
|
|
|
|
return -EINVAL;
|
|
}
|
|
|
|
static void serial_base_ctrl_release(struct device *dev)
|
|
{
|
|
struct serial_ctrl_device *ctrl_dev = to_serial_base_ctrl_device(dev);
|
|
|
|
kfree(ctrl_dev);
|
|
}
|
|
|
|
void serial_base_ctrl_device_remove(struct serial_ctrl_device *ctrl_dev)
|
|
{
|
|
if (!ctrl_dev)
|
|
return;
|
|
|
|
device_del(&ctrl_dev->dev);
|
|
put_device(&ctrl_dev->dev);
|
|
}
|
|
|
|
struct serial_ctrl_device *serial_base_ctrl_add(struct uart_port *port,
|
|
struct device *parent)
|
|
{
|
|
struct serial_ctrl_device *ctrl_dev;
|
|
int err;
|
|
|
|
ctrl_dev = kzalloc(sizeof(*ctrl_dev), GFP_KERNEL);
|
|
if (!ctrl_dev)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
ida_init(&ctrl_dev->port_ida);
|
|
|
|
err = serial_base_device_init(port, &ctrl_dev->dev,
|
|
parent, &serial_ctrl_type,
|
|
serial_base_ctrl_release,
|
|
port->ctrl_id, 0);
|
|
if (err)
|
|
goto err_put_device;
|
|
|
|
err = device_add(&ctrl_dev->dev);
|
|
if (err)
|
|
goto err_put_device;
|
|
|
|
return ctrl_dev;
|
|
|
|
err_put_device:
|
|
put_device(&ctrl_dev->dev);
|
|
|
|
return ERR_PTR(err);
|
|
}
|
|
|
|
static void serial_base_port_release(struct device *dev)
|
|
{
|
|
struct serial_port_device *port_dev = to_serial_base_port_device(dev);
|
|
|
|
kfree(port_dev);
|
|
}
|
|
|
|
struct serial_port_device *serial_base_port_add(struct uart_port *port,
|
|
struct serial_ctrl_device *ctrl_dev)
|
|
{
|
|
struct serial_port_device *port_dev;
|
|
int min = 0, max = -1; /* Use -1 for max to apply IDA defaults */
|
|
int err;
|
|
|
|
port_dev = kzalloc(sizeof(*port_dev), GFP_KERNEL);
|
|
if (!port_dev)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
/* Device driver specified port_id vs automatic assignment? */
|
|
if (port->port_id) {
|
|
min = port->port_id;
|
|
max = port->port_id;
|
|
}
|
|
|
|
err = ida_alloc_range(&ctrl_dev->port_ida, min, max, GFP_KERNEL);
|
|
if (err < 0) {
|
|
kfree(port_dev);
|
|
return ERR_PTR(err);
|
|
}
|
|
|
|
port->port_id = err;
|
|
|
|
err = serial_base_device_init(port, &port_dev->dev,
|
|
&ctrl_dev->dev, &serial_port_type,
|
|
serial_base_port_release,
|
|
port->ctrl_id, port->port_id);
|
|
if (err)
|
|
goto err_put_device;
|
|
|
|
port_dev->port = port;
|
|
|
|
err = device_add(&port_dev->dev);
|
|
if (err)
|
|
goto err_put_device;
|
|
|
|
return port_dev;
|
|
|
|
err_put_device:
|
|
put_device(&port_dev->dev);
|
|
ida_free(&ctrl_dev->port_ida, port->port_id);
|
|
|
|
return ERR_PTR(err);
|
|
}
|
|
|
|
void serial_base_port_device_remove(struct serial_port_device *port_dev)
|
|
{
|
|
struct serial_ctrl_device *ctrl_dev;
|
|
struct device *parent;
|
|
|
|
if (!port_dev)
|
|
return;
|
|
|
|
parent = port_dev->dev.parent;
|
|
ctrl_dev = to_serial_base_ctrl_device(parent);
|
|
|
|
device_del(&port_dev->dev);
|
|
ida_free(&ctrl_dev->port_ida, port_dev->port->port_id);
|
|
put_device(&port_dev->dev);
|
|
}
|
|
|
|
#ifdef CONFIG_SERIAL_CORE_CONSOLE
|
|
|
|
static int serial_base_add_one_prefcon(const char *match, const char *dev_name,
|
|
int port_id)
|
|
{
|
|
int ret;
|
|
|
|
ret = add_preferred_console_match(match, dev_name, port_id);
|
|
if (ret == -ENOENT)
|
|
return 0;
|
|
|
|
return ret;
|
|
}
|
|
|
|
#ifdef __sparc__
|
|
|
|
/* Handle Sparc ttya and ttyb options as done in console_setup() */
|
|
static int serial_base_add_sparc_console(const char *dev_name, int idx)
|
|
{
|
|
const char *name;
|
|
|
|
switch (idx) {
|
|
case 0:
|
|
name = "ttya";
|
|
break;
|
|
case 1:
|
|
name = "ttyb";
|
|
break;
|
|
default:
|
|
return 0;
|
|
}
|
|
|
|
return serial_base_add_one_prefcon(name, dev_name, idx);
|
|
}
|
|
|
|
#else
|
|
|
|
static inline int serial_base_add_sparc_console(const char *dev_name, int idx)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
#endif
|
|
|
|
static int serial_base_add_prefcon(const char *name, int idx)
|
|
{
|
|
const char *char_match __free(kfree) = NULL;
|
|
const char *nmbr_match __free(kfree) = NULL;
|
|
int ret;
|
|
|
|
/* Handle ttyS specific options */
|
|
if (strstarts(name, "ttyS")) {
|
|
/* No name, just a number */
|
|
nmbr_match = kasprintf(GFP_KERNEL, "%i", idx);
|
|
if (!nmbr_match)
|
|
return -ENODEV;
|
|
|
|
ret = serial_base_add_one_prefcon(nmbr_match, name, idx);
|
|
if (ret)
|
|
return ret;
|
|
|
|
/* Sparc ttya and ttyb */
|
|
ret = serial_base_add_sparc_console(name, idx);
|
|
if (ret)
|
|
return ret;
|
|
}
|
|
|
|
/* Handle the traditional character device name style console=ttyS0 */
|
|
char_match = kasprintf(GFP_KERNEL, "%s%i", name, idx);
|
|
if (!char_match)
|
|
return -ENOMEM;
|
|
|
|
return serial_base_add_one_prefcon(char_match, name, idx);
|
|
}
|
|
|
|
/**
|
|
* serial_base_add_preferred_console - Adds a preferred console
|
|
* @drv: Serial port device driver
|
|
* @port: Serial port instance
|
|
*
|
|
* Tries to add a preferred console for a serial port if specified in the
|
|
* kernel command line. Supports both the traditional character device such
|
|
* as console=ttyS0, and a hardware addressing based console=DEVNAME:0.0
|
|
* style name.
|
|
*
|
|
* Translates the kernel command line option using a hardware based addressing
|
|
* console=DEVNAME:0.0 to the serial port character device such as ttyS0.
|
|
* Cannot be called early for ISA ports, depends on struct device.
|
|
*
|
|
* Note that duplicates are ignored by add_preferred_console().
|
|
*
|
|
* Return: 0 on success, negative error code on failure.
|
|
*/
|
|
int serial_base_add_preferred_console(struct uart_driver *drv,
|
|
struct uart_port *port)
|
|
{
|
|
const char *port_match __free(kfree) = NULL;
|
|
int ret;
|
|
|
|
ret = serial_base_add_prefcon(drv->dev_name, port->line);
|
|
if (ret)
|
|
return ret;
|
|
|
|
port_match = kasprintf(GFP_KERNEL, "%s:%i.%i", dev_name(port->dev),
|
|
port->ctrl_id, port->port_id);
|
|
if (!port_match)
|
|
return -ENOMEM;
|
|
|
|
/* Translate a hardware addressing style console=DEVNAME:0.0 */
|
|
return serial_base_add_one_prefcon(port_match, drv->dev_name, port->line);
|
|
}
|
|
|
|
#endif
|
|
|
|
#ifdef CONFIG_SERIAL_8250_CONSOLE
|
|
|
|
/*
|
|
* Early ISA ports initialize the console before there is no struct device.
|
|
* This should be only called from serial8250_isa_init_preferred_console(),
|
|
* other callers are likely wrong and should rely on earlycon instead.
|
|
*/
|
|
int serial_base_add_isa_preferred_console(const char *name, int idx)
|
|
{
|
|
return serial_base_add_prefcon(name, idx);
|
|
}
|
|
|
|
#endif
|
|
|
|
static int serial_base_init(void)
|
|
{
|
|
int ret;
|
|
|
|
ret = bus_register(&serial_base_bus_type);
|
|
if (ret)
|
|
return ret;
|
|
|
|
ret = serial_base_ctrl_init();
|
|
if (ret)
|
|
goto err_bus_unregister;
|
|
|
|
ret = serial_base_port_init();
|
|
if (ret)
|
|
goto err_ctrl_exit;
|
|
|
|
serial_base_initialized = true;
|
|
|
|
return 0;
|
|
|
|
err_ctrl_exit:
|
|
serial_base_ctrl_exit();
|
|
|
|
err_bus_unregister:
|
|
bus_unregister(&serial_base_bus_type);
|
|
|
|
return ret;
|
|
}
|
|
arch_initcall(serial_base_init);
|
|
|
|
static void serial_base_exit(void)
|
|
{
|
|
serial_base_port_exit();
|
|
serial_base_ctrl_exit();
|
|
bus_unregister(&serial_base_bus_type);
|
|
}
|
|
module_exit(serial_base_exit);
|
|
|
|
MODULE_AUTHOR("Tony Lindgren <tony@atomide.com>");
|
|
MODULE_DESCRIPTION("Serial core bus");
|
|
MODULE_LICENSE("GPL");
|