iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net
History
YueHaibing 93b3fe8ae9 9p/virtio: Add cleanup path in p9_virtio_init 
commit d4548543fc4ece56c6f04b8586f435fb4fd84c20 upstream.

KASAN report this:

BUG: unable to handle kernel paging request at ffffffffa0097000
PGD 3870067 P4D 3870067 PUD 3871063 PMD 2326e2067 PTE 0
Oops: 0000 [#1
CPU: 0 PID: 5340 Comm: modprobe Not tainted 5.1.0-rc7+ #25
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.9.3-0-ge2fc41e-prebuilt.qemu-project.org 04/01/2014
RIP: 0010:__list_add_valid+0x10/0x70
Code: c3 48 8b 06 55 48 89 e5 5d 48 39 07 0f 94 c0 0f b6 c0 c3 90 90 90 90 90 90 90 55 48 89 d0 48 8b 52 08 48 89 e5 48 39 f2 75 19 <48> 8b 32 48 39 f0 75 3a

RSP: 0018:ffffc90000e23c68 EFLAGS: 00010246
RAX: ffffffffa00ad000 RBX: ffffffffa009d000 RCX: 0000000000000000
RDX: ffffffffa0097000 RSI: ffffffffa0097000 RDI: ffffffffa009d000
RBP: ffffc90000e23c68 R08: 0000000000000001 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: ffffffffa0097000
R13: ffff888231797180 R14: 0000000000000000 R15: ffffc90000e23e78
FS:  00007fb215285540(0000) GS:ffff888237a00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffffffa0097000 CR3: 000000022f144000 CR4: 00000000000006f0
Call Trace:
 v9fs_register_trans+0x2f/0x60 [9pnet
 ? 0xffffffffa0087000
 p9_virtio_init+0x25/0x1000 [9pnet_virtio
 do_one_initcall+0x6c/0x3cc
 ? kmem_cache_alloc_trace+0x248/0x3b0
 do_init_module+0x5b/0x1f1
 load_module+0x1db1/0x2690
 ? m_show+0x1d0/0x1d0
 __do_sys_finit_module+0xc5/0xd0
 __x64_sys_finit_module+0x15/0x20
 do_syscall_64+0x6b/0x1d0
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7fb214d8e839
Code: 00 f3 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01

RSP: 002b:00007ffc96554278 EFLAGS: 00000246 ORIG_RAX: 0000000000000139
RAX: ffffffffffffffda RBX: 000055e67eed2aa0 RCX: 00007fb214d8e839
RDX: 0000000000000000 RSI: 000055e67ce95c2e RDI: 0000000000000003
RBP: 000055e67ce95c2e R08: 0000000000000000 R09: 000055e67eed2aa0
R10: 0000000000000003 R11: 0000000000000246 R12: 0000000000000000
R13: 000055e67eeda500 R14: 0000000000040000 R15: 000055e67eed2aa0
Modules linked in: 9pnet_virtio(+) 9pnet gre rfkill vmw_vsock_virtio_transport_common vsock [last unloaded: 9pnet_virtio
CR2: ffffffffa0097000
---[ end trace 4a52bb13ff07b761

If register_virtio_driver() fails in p9_virtio_init,
we should call v9fs_unregister_trans() to do cleanup.

Link: http://lkml.kernel.org/r/20190430115942.41840-1-yuehaibing@huawei.com
Cc: stable@vger.kernel.org
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: b530cc794024 ("9p: add virtio transport")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Dominique Martinet <dominique.martinet@cea.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-08-04 09:34:51 +02:00
..
6lowpan
6lowpan: iphc: reset mac_header after decompress to fix panic
2018-10-10 08:52:04 +02:00
9p
9p/virtio: Add cleanup path in p9_virtio_init
2019-08-04 09:34:51 +02:00
802
…
8021q
vlan: disable SIOCSHWTSTAMP in container
2019-05-16 19:45:17 +02:00
appletalk
appletalk: Fix use-after-free in atalk_proc_exit
2019-04-27 09:33:59 +02:00
atm
net: atm: Fix potential Spectre v1 vulnerabilities
2019-04-27 09:33:59 +02:00
ax25
ax25: fix inconsistent lock state in ax25_destroy_timer
2019-06-22 08:18:25 +02:00
batman-adv
batman-adv: fix for leaked TVLV handler.
2019-08-04 09:34:39 +02:00
bluetooth
Bluetooth: validate BLE connection interval updates
2019-08-04 09:34:49 +02:00
bridge
bridge: Fix error path for kobject_init_and_add()
2019-05-16 19:45:17 +02:00
caif
net: caif: Add a missing rcu_read_unlock() in caif_flow_cb
2018-09-05 09:18:34 +02:00
can
can: purge socket error queue on sock destruct
2019-07-10 09:56:33 +02:00
ceph
libceph: handle an empty authorize reply
2019-03-23 08:44:18 +01:00
core
neigh: fix use-after-free read in pneigh_get_next
2019-06-22 08:18:25 +02:00
dcb
net: dcb: For wild-card lookups, use priority -1, not 0
2018-09-19 22:48:58 +02:00
dccp
dccp: do not use ipv6 header for ipv4 flow
2019-04-03 06:23:25 +02:00
decnet
dn_getsockoptdecnet: move nf_{get/set}sockopt outside sock lock
2018-02-25 11:03:38 +01:00
dns_resolver
KEYS: DNS: fix parsing multiple options
2018-07-22 14:25:54 +02:00
dsa
net: dsa: slave: Don't propagate flag changes on down slave interfaces
2019-02-20 10:13:15 +01:00
ethernet
net: introduce device min_header_len
2017-02-18 16:39:27 +01:00
hsr
net/hsr: fix possible crash in add_timer()
2019-03-23 08:44:31 +01:00
ieee802154
inet: frags: fix ip6frag_low_thresh boundary
2019-02-08 11:25:32 +01:00
ipv4
ipv4: Use return value of inet_iif() for __raw_v4_lookup in the while loop
2019-07-10 09:56:37 +02:00
ipv6
ipv6: flowlabel: fl6_sock_lookup() must use atomic_inc_not_zero
2019-06-22 08:18:25 +02:00
ipx
ipx: call ipxitf_put() in ioctl error path
2017-05-25 14:30:13 +02:00
irda
irda: Only insert new objects into the global database via setsockopt
2018-09-15 09:40:40 +02:00
iucv
af_iucv: Move sockaddr length checks to before accessing sa_family in bind and connect handlers
2018-11-10 07:41:35 -08:00
key
af_key: fix leaks in key_pol_get_resp and dump_sp.
2019-08-04 09:34:42 +02:00
l2tp
l2tp: fix infoleak in l2tp_ip6_recvmsg()
2019-03-23 08:44:29 +01:00
l3mdev
net: Add netif_is_l3_slave
2015-10-07 04:27:43 -07:00
lapb
lapb: fixed leak of control-blocks.
2019-06-22 08:18:25 +02:00
llc
llc: fix skb leak in llc_build_and_send_ui_pkt()
2019-06-11 12:24:06 +02:00
mac80211
mac80211: mesh: fix RCU warning
2019-07-21 09:07:06 +02:00
mac802154
net: mac802154: tx: expand tailroom if necessary
2018-09-09 20:04:32 +02:00
mpls
mpls, nospec: Sanitize array index in mpls_label_ok()
2018-03-11 16:19:47 +01:00
netfilter
ipvs: do not schedule icmp errors from tunnels
2019-05-16 19:45:06 +02:00
netlabel
netlabel: check for IPV4MASK in addrinfo_get
2018-10-20 09:52:36 +02:00
netlink
netlink: Don't shift on 64 for ngroups
2018-08-09 12:19:28 +02:00
netrom
netrom: switch to sock timer API
2019-02-06 19:43:06 +01:00
nfc
net: nfc: Fix NULL dereference on nfc_llcp_build_tlv fails
2019-03-23 08:44:22 +01:00
openvswitch
openvswitch: fix flow actions reallocation
2019-04-27 09:33:54 +02:00
packet
packet: Fix error path in packet_init
2019-05-16 19:45:17 +02:00
phonet
phonet: fix building with clang
2019-03-23 08:44:34 +01:00
rds
net: rds: fix memory leak in rds_ib_flush_mr_pool
2019-06-11 12:24:12 +02:00
rfkill
rfkill: gpio: fix memory leak in probe error path
2018-05-16 10:06:51 +02:00
rose
net: rose: fix a possible stack overflow
2019-04-03 06:23:25 +02:00
rxrpc
rxrpc: check return value of skb_to_sgvec always
2018-04-13 19:50:23 +02:00
sched
net: create skb_gso_validate_mac_len()
2019-06-11 12:24:10 +02:00
sctp
sctp: change to hold sk after auth shkey is created successfully
2019-07-10 09:56:36 +02:00
sunrpc
sunrpc: don't mark uninitialised items as VALID.
2019-05-16 19:44:44 +02:00
switchdev
switchdev: pass pointer to fib_info instead of copy
2016-06-24 10:18:16 -07:00
tipc
tipc: check msg->req data len in tipc_nl_compat_bearer_disable
2019-07-10 09:56:37 +02:00
unix
missing barriers in some of unix_sock ->addr and ->path accesses
2019-03-23 08:44:31 +01:00
vmw_vsock
vsock: cope with memory allocation failure at socket creation time
2019-02-23 09:05:13 +01:00
wimax
net:wimax: Fix doucble word "the the" in networking.xml
2015-08-09 22:43:52 -07:00
wireless
cfg80211: fix memory leak of wiphy device name
2019-07-10 09:56:34 +02:00
x25
net/x25: fix a race in x25_bind()
2019-03-23 08:44:30 +01:00
xfrm
xfrm: fix sa selector validation
2019-08-04 09:34:46 +02:00
compat.c
sock: Make sock->sk_stamp thread-safe
2019-01-13 10:05:28 +01:00
Kconfig
Make DST_CACHE a silent config option
2018-02-25 11:03:37 +01:00
Makefile
net: Introduce L3 Master device abstraction
2015-09-29 20:40:32 -07:00
socket.c
sockfs: getxattr: Fail with -EOPNOTSUPP for invalid attribute names
2019-03-23 08:44:21 +01:00
sysctl_net.c
net: Use ns_capable_noaudit() when determining net sysctl permissions
2016-09-15 08:27:50 +02:00