On contiguous allocation, we round up the size to the *next* power of 2, implement a function to free the unused pages after the newly allocate block. v2(Matthew Auld): - replace function name 'drm_buddy_free_unused_pages' with drm_buddy_block_trim - replace input argument name 'actual_size' with 'new_size' - add more validation checks for input arguments - add overlaps check to avoid needless searching and splitting - merged the below patch to see the feature in action - add free unused pages support to i915 driver - lock drm_buddy_block_trim() function as it calls mark_free/mark_split are all globally visible v3(Matthew Auld): - remove trim method error handling as we address the failure case at drm_buddy_block_trim() function v4: - in case of trim, at __alloc_range() split_block failure path marks the block as free and removes it from the original list, potentially also freeing it, to overcome this problem, we turn the drm_buddy_block_trim() input node into a temporary node to prevent recursively freeing itself, but still retain the un-splitting/freeing of the other nodes(Matthew Auld) - modify the drm_buddy_block_trim() function return type v5(Matthew Auld): - revert drm_buddy_block_trim() function return type changes in v4 - modify drm_buddy_block_trim() passing argument n_pages to original_size as n_pages has already been rounded up to the next power-of-two and passing n_pages results noop v6: - fix warnings reported by kernel test robot <lkp@intel.com> v7: - modify drm_buddy_block_trim() function doc description - at drm_buddy_block_trim() handle non-allocated block as a serious programmer error - fix a typo Signed-off-by: Arunpravin <Arunpravin.PaneerSelvam@amd.com> Reviewed-by: Matthew Auld <matthew.auld@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220221164552.2434-3-Arunpravin.PaneerSelvam@amd.com Signed-off-by: Christian König <christian.koenig@amd.com>
292 lines
7.7 KiB
C
292 lines
7.7 KiB
C
// SPDX-License-Identifier: MIT
|
|
/*
|
|
* Copyright © 2021 Intel Corporation
|
|
*/
|
|
|
|
#include <linux/slab.h>
|
|
|
|
#include <drm/ttm/ttm_bo_driver.h>
|
|
#include <drm/ttm/ttm_placement.h>
|
|
|
|
#include <drm/drm_buddy.h>
|
|
|
|
#include "i915_ttm_buddy_manager.h"
|
|
|
|
#include "i915_gem.h"
|
|
|
|
struct i915_ttm_buddy_manager {
|
|
struct ttm_resource_manager manager;
|
|
struct drm_buddy mm;
|
|
struct list_head reserved;
|
|
struct mutex lock;
|
|
u64 default_page_size;
|
|
};
|
|
|
|
static struct i915_ttm_buddy_manager *
|
|
to_buddy_manager(struct ttm_resource_manager *man)
|
|
{
|
|
return container_of(man, struct i915_ttm_buddy_manager, manager);
|
|
}
|
|
|
|
static int i915_ttm_buddy_man_alloc(struct ttm_resource_manager *man,
|
|
struct ttm_buffer_object *bo,
|
|
const struct ttm_place *place,
|
|
struct ttm_resource **res)
|
|
{
|
|
struct i915_ttm_buddy_manager *bman = to_buddy_manager(man);
|
|
struct i915_ttm_buddy_resource *bman_res;
|
|
struct drm_buddy *mm = &bman->mm;
|
|
unsigned long n_pages, lpfn;
|
|
u64 min_page_size;
|
|
u64 size;
|
|
int err;
|
|
|
|
lpfn = place->lpfn;
|
|
if (!lpfn)
|
|
lpfn = man->size;
|
|
|
|
bman_res = kzalloc(sizeof(*bman_res), GFP_KERNEL);
|
|
if (!bman_res)
|
|
return -ENOMEM;
|
|
|
|
ttm_resource_init(bo, place, &bman_res->base);
|
|
INIT_LIST_HEAD(&bman_res->blocks);
|
|
bman_res->mm = mm;
|
|
|
|
if (place->flags & TTM_PL_FLAG_TOPDOWN)
|
|
bman_res->flags |= DRM_BUDDY_TOPDOWN_ALLOCATION;
|
|
|
|
if (place->fpfn || lpfn != man->size)
|
|
bman_res->flags |= DRM_BUDDY_RANGE_ALLOCATION;
|
|
|
|
GEM_BUG_ON(!bman_res->base.num_pages);
|
|
size = bman_res->base.num_pages << PAGE_SHIFT;
|
|
|
|
min_page_size = bman->default_page_size;
|
|
if (bo->page_alignment)
|
|
min_page_size = bo->page_alignment << PAGE_SHIFT;
|
|
|
|
GEM_BUG_ON(min_page_size < mm->chunk_size);
|
|
|
|
if (place->flags & TTM_PL_FLAG_CONTIGUOUS) {
|
|
unsigned long pages;
|
|
|
|
size = roundup_pow_of_two(size);
|
|
min_page_size = size;
|
|
|
|
pages = size >> ilog2(mm->chunk_size);
|
|
if (pages > lpfn)
|
|
lpfn = pages;
|
|
}
|
|
|
|
if (size > mm->size) {
|
|
err = -E2BIG;
|
|
goto err_free_res;
|
|
}
|
|
|
|
n_pages = size >> ilog2(mm->chunk_size);
|
|
|
|
mutex_lock(&bman->lock);
|
|
err = drm_buddy_alloc_blocks(mm, (u64)place->fpfn << PAGE_SHIFT,
|
|
(u64)lpfn << PAGE_SHIFT,
|
|
(u64)n_pages << PAGE_SHIFT,
|
|
min_page_size,
|
|
&bman_res->blocks,
|
|
bman_res->flags);
|
|
mutex_unlock(&bman->lock);
|
|
if (unlikely(err))
|
|
goto err_free_blocks;
|
|
|
|
if (place->flags & TTM_PL_FLAG_CONTIGUOUS) {
|
|
u64 original_size = (u64)bman_res->base.num_pages << PAGE_SHIFT;
|
|
|
|
mutex_lock(&bman->lock);
|
|
drm_buddy_block_trim(mm,
|
|
original_size,
|
|
&bman_res->blocks);
|
|
mutex_unlock(&bman->lock);
|
|
}
|
|
|
|
*res = &bman_res->base;
|
|
return 0;
|
|
|
|
err_free_blocks:
|
|
mutex_lock(&bman->lock);
|
|
drm_buddy_free_list(mm, &bman_res->blocks);
|
|
mutex_unlock(&bman->lock);
|
|
err_free_res:
|
|
ttm_resource_fini(man, &bman_res->base);
|
|
kfree(bman_res);
|
|
return err;
|
|
}
|
|
|
|
static void i915_ttm_buddy_man_free(struct ttm_resource_manager *man,
|
|
struct ttm_resource *res)
|
|
{
|
|
struct i915_ttm_buddy_resource *bman_res = to_ttm_buddy_resource(res);
|
|
struct i915_ttm_buddy_manager *bman = to_buddy_manager(man);
|
|
|
|
mutex_lock(&bman->lock);
|
|
drm_buddy_free_list(&bman->mm, &bman_res->blocks);
|
|
mutex_unlock(&bman->lock);
|
|
|
|
ttm_resource_fini(man, res);
|
|
kfree(bman_res);
|
|
}
|
|
|
|
static void i915_ttm_buddy_man_debug(struct ttm_resource_manager *man,
|
|
struct drm_printer *printer)
|
|
{
|
|
struct i915_ttm_buddy_manager *bman = to_buddy_manager(man);
|
|
struct drm_buddy_block *block;
|
|
|
|
mutex_lock(&bman->lock);
|
|
drm_printf(printer, "default_page_size: %lluKiB\n",
|
|
bman->default_page_size >> 10);
|
|
|
|
drm_buddy_print(&bman->mm, printer);
|
|
|
|
drm_printf(printer, "reserved:\n");
|
|
list_for_each_entry(block, &bman->reserved, link)
|
|
drm_buddy_block_print(&bman->mm, block, printer);
|
|
mutex_unlock(&bman->lock);
|
|
}
|
|
|
|
static const struct ttm_resource_manager_func i915_ttm_buddy_manager_func = {
|
|
.alloc = i915_ttm_buddy_man_alloc,
|
|
.free = i915_ttm_buddy_man_free,
|
|
.debug = i915_ttm_buddy_man_debug,
|
|
};
|
|
|
|
/**
|
|
* i915_ttm_buddy_man_init - Setup buddy allocator based ttm manager
|
|
* @bdev: The ttm device
|
|
* @type: Memory type we want to manage
|
|
* @use_tt: Set use_tt for the manager
|
|
* @size: The size in bytes to manage
|
|
* @default_page_size: The default minimum page size in bytes for allocations,
|
|
* this must be at least as large as @chunk_size, and can be overridden by
|
|
* setting the BO page_alignment, to be larger or smaller as needed.
|
|
* @chunk_size: The minimum page size in bytes for our allocations i.e
|
|
* order-zero
|
|
*
|
|
* Note that the starting address is assumed to be zero here, since this
|
|
* simplifies keeping the property where allocated blocks having natural
|
|
* power-of-two alignment. So long as the real starting address is some large
|
|
* power-of-two, or naturally start from zero, then this should be fine. Also
|
|
* the &i915_ttm_buddy_man_reserve interface can be used to preserve alignment
|
|
* if say there is some unusable range from the start of the region. We can
|
|
* revisit this in the future and make the interface accept an actual starting
|
|
* offset and let it take care of the rest.
|
|
*
|
|
* Note that if the @size is not aligned to the @chunk_size then we perform the
|
|
* required rounding to get the usable size. The final size in pages can be
|
|
* taken from &ttm_resource_manager.size.
|
|
*
|
|
* Return: 0 on success, negative error code on failure.
|
|
*/
|
|
int i915_ttm_buddy_man_init(struct ttm_device *bdev,
|
|
unsigned int type, bool use_tt,
|
|
u64 size, u64 default_page_size,
|
|
u64 chunk_size)
|
|
{
|
|
struct ttm_resource_manager *man;
|
|
struct i915_ttm_buddy_manager *bman;
|
|
int err;
|
|
|
|
bman = kzalloc(sizeof(*bman), GFP_KERNEL);
|
|
if (!bman)
|
|
return -ENOMEM;
|
|
|
|
err = drm_buddy_init(&bman->mm, size, chunk_size);
|
|
if (err)
|
|
goto err_free_bman;
|
|
|
|
mutex_init(&bman->lock);
|
|
INIT_LIST_HEAD(&bman->reserved);
|
|
GEM_BUG_ON(default_page_size < chunk_size);
|
|
bman->default_page_size = default_page_size;
|
|
|
|
man = &bman->manager;
|
|
man->use_tt = use_tt;
|
|
man->func = &i915_ttm_buddy_manager_func;
|
|
ttm_resource_manager_init(man, bdev, bman->mm.size >> PAGE_SHIFT);
|
|
|
|
ttm_resource_manager_set_used(man, true);
|
|
ttm_set_driver_manager(bdev, type, man);
|
|
|
|
return 0;
|
|
|
|
err_free_bman:
|
|
kfree(bman);
|
|
return err;
|
|
}
|
|
|
|
/**
|
|
* i915_ttm_buddy_man_fini - Destroy the buddy allocator ttm manager
|
|
* @bdev: The ttm device
|
|
* @type: Memory type we want to manage
|
|
*
|
|
* Note that if we reserved anything with &i915_ttm_buddy_man_reserve, this will
|
|
* also be freed for us here.
|
|
*
|
|
* Return: 0 on success, negative error code on failure.
|
|
*/
|
|
int i915_ttm_buddy_man_fini(struct ttm_device *bdev, unsigned int type)
|
|
{
|
|
struct ttm_resource_manager *man = ttm_manager_type(bdev, type);
|
|
struct i915_ttm_buddy_manager *bman = to_buddy_manager(man);
|
|
struct drm_buddy *mm = &bman->mm;
|
|
int ret;
|
|
|
|
ttm_resource_manager_set_used(man, false);
|
|
|
|
ret = ttm_resource_manager_evict_all(bdev, man);
|
|
if (ret)
|
|
return ret;
|
|
|
|
ttm_set_driver_manager(bdev, type, NULL);
|
|
|
|
mutex_lock(&bman->lock);
|
|
drm_buddy_free_list(mm, &bman->reserved);
|
|
drm_buddy_fini(mm);
|
|
mutex_unlock(&bman->lock);
|
|
|
|
ttm_resource_manager_cleanup(man);
|
|
kfree(bman);
|
|
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* i915_ttm_buddy_man_reserve - Reserve address range
|
|
* @man: The buddy allocator ttm manager
|
|
* @start: The offset in bytes, where the region start is assumed to be zero
|
|
* @size: The size in bytes
|
|
*
|
|
* Note that the starting address for the region is always assumed to be zero.
|
|
*
|
|
* Return: 0 on success, negative error code on failure.
|
|
*/
|
|
int i915_ttm_buddy_man_reserve(struct ttm_resource_manager *man,
|
|
u64 start, u64 size)
|
|
{
|
|
struct i915_ttm_buddy_manager *bman = to_buddy_manager(man);
|
|
struct drm_buddy *mm = &bman->mm;
|
|
unsigned long flags = 0;
|
|
int ret;
|
|
|
|
flags |= DRM_BUDDY_RANGE_ALLOCATION;
|
|
|
|
mutex_lock(&bman->lock);
|
|
ret = drm_buddy_alloc_blocks(mm, start,
|
|
start + size,
|
|
size, mm->chunk_size,
|
|
&bman->reserved,
|
|
flags);
|
|
mutex_unlock(&bman->lock);
|
|
|
|
return ret;
|
|
}
|
|
|