Paul Fulghum 9453a5adaf [PATCH] ptmx: fix duplicate idr_remove
Remove duplicate call to idr_remove() in ptmx_open.

Error during open can result in call to release_dev() followed by call to
idr_remove().  release_dev already calls idr_remove so the second call can
cause a stack dump in idr_remove()->sub_remove() flagging an attempt to
release an already released entry.

I reproduces this on a machine with a misconfigured X server (attempting to
restart multiple times rapidly) getting the same error as the 1st link
below.

This also seems to be related to:
http://marc.theaimsgroup.com/?l=selinux&m=110536513426735&w=2
http://marc.theaimsgroup.com/?l=selinux&m=110596994916785&w=2

The stack dump can occur on close (as well as open) as shown
in the 1st instance above, possible from something like:

process A - open (index=0), open fail to out1,
  release_dev calls idr_remove (index 0), down(sem) sleeps
process B - open (index=0), open OK (idr allocated)
process A - wake and call idr_remove on index 0
...
process B - close, release_dev, stack dump on idr_remove (index=0)
  because entry already removed

Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-04-11 06:18:43 -07:00
..
2006-03-25 08:22:55 -08:00
2006-01-01 22:21:50 +01:00
2006-03-23 07:38:16 -08:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2006-03-26 18:17:21 +02:00
2005-04-16 15:20:36 -07:00
2006-02-14 10:01:39 -08:00
2005-04-16 15:20:36 -07:00
2006-03-28 16:45:26 +11:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2006-03-29 13:24:50 +11:00
2005-10-29 19:30:42 +01:00
2005-10-29 19:30:42 +01:00
2005-05-04 07:33:13 -07:00
2006-03-28 09:16:05 -08:00
2006-03-28 09:16:05 -08:00
2006-03-25 08:22:52 -08:00
2006-03-28 09:16:08 -08:00
2006-01-10 08:01:59 -08:00
2006-03-23 07:38:11 -08:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2006-03-23 07:38:11 -08:00
2006-01-10 08:01:59 -08:00
2005-10-29 19:30:55 +01:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2006-03-25 08:22:52 -08:00
2005-04-16 15:20:36 -07:00
2006-02-03 08:31:59 -08:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2006-01-12 09:09:00 -08:00
2005-04-16 15:20:36 -07:00
2006-01-10 08:01:59 -08:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2006-03-23 07:38:15 -08:00
2006-03-23 07:38:15 -08:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2006-03-28 09:16:08 -08:00
2006-03-24 07:33:24 -08:00
2006-03-25 08:22:52 -08:00
2006-02-11 21:41:13 -08:00
2006-03-31 12:18:56 -08:00