Andreas Gruenbacher 945526846a dnotify: ignore FS_EVENT_ON_CHILD ... Mask off FS_EVENT_ON_CHILD in dnotify_handle_event(). Otherwise, when there is more than one watch on a directory and dnotify_should_send_event() succeeds, events with FS_EVENT_ON_CHILD set will trigger all watches and cause spurious events. This case was overlooked in commit e42e2773. #define _GNU_SOURCE #include <stdio.h> #include <stdlib.h> #include <unistd.h> #include <signal.h> #include <sys/types.h> #include <sys/stat.h> #include <fcntl.h> #include <string.h> static void create_event(int s, siginfo_t* si, void* p) { printf("create\n"); } static void delete_event(int s, siginfo_t* si, void* p) { printf("delete\n"); } int main (void) { struct sigaction action; char *tmpdir, *file; int fd1, fd2; sigemptyset (&action.sa_mask); action.sa_flags = SA_SIGINFO; action.sa_sigaction = create_event; sigaction (SIGRTMIN + 0, &action, NULL); action.sa_sigaction = delete_event; sigaction (SIGRTMIN + 1, &action, NULL); # define TMPDIR "/tmp/test.XXXXXX" tmpdir = malloc(strlen(TMPDIR) + 1); strcpy(tmpdir, TMPDIR); mkdtemp(tmpdir); # define TMPFILE "/file" file = malloc(strlen(tmpdir) + strlen(TMPFILE) + 1); sprintf(file, "%s/%s", tmpdir, TMPFILE); fd1 = open (tmpdir, O_RDONLY); fcntl(fd1, F_SETSIG, SIGRTMIN); fcntl(fd1, F_NOTIFY, DN_MULTISHOT | DN_CREATE); fd2 = open (tmpdir, O_RDONLY); fcntl(fd2, F_SETSIG, SIGRTMIN + 1); fcntl(fd2, F_NOTIFY, DN_MULTISHOT | DN_DELETE); if (fork()) { /* This triggers a create event */ creat(file, 0600); /* This triggers a create and delete event (!) */ unlink(file); } else { sleep(1); rmdir(tmpdir); } return 0; } Signed-off-by: Andreas Gruenbacher <agruen@suse.de> Signed-off-by: Eric Paris <eparis@redhat.com>		2009-10-20 18:02:33 -04:00
..
dnotify	dnotify: ignore FS_EVENT_ON_CHILD	2009-10-20 18:02:33 -04:00
inotify	inotify: update the group mask on mark addition	2009-08-28 12:51:14 -04:00
fsnotify.c	inotify: use GFP_NOFS under potential memory pressure	2009-07-21 15:26:27 -04:00
fsnotify.h	fsnotify: generic notification queue and waitq	2009-06-11 14:57:53 -04:00
group.c	fsnotify: generic notification queue and waitq	2009-06-11 14:57:53 -04:00
inode_mark.c	fsnotify: do not set group for a mark before it is on the i_list	2009-10-18 15:49:38 -04:00
Kconfig	fsnotify: use def_bool in kconfig instead of letting the user choose	2009-07-21 15:26:26 -04:00
Makefile	fsnotify: add marks to inodes so groups can interpret how to handle those inodes	2009-06-11 14:57:53 -04:00
notification.c	inotify: fix coalesce duplicate events into a single event in special case	2009-10-18 15:49:38 -04:00