Ming Lei 3a762de55b block: save irq state in blkg_lookup_create() ... blkg_lookup_create() may be called from pool_map() in which irq state is saved, so we have to do that in blkg_lookup_create(). Otherwise, the following lockdep warning can be triggered: [ 104.258537] ================================ [ 104.259129] WARNING: inconsistent lock state [ 104.259725] 4.20.0-rc6+ #545 Not tainted [ 104.260268] -------------------------------- [ 104.260865] inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage. [ 104.261727] swapper/49/0 [HC0[0]:SC1[1]:HE0:SE0] takes: [ 104.262444] 00000000db365b5d (&(&pool->lock)->rlock#3){+.?.}, at: thin_endio+0xcf/0x2a3 [dm_thin_pool] [ 104.263747] {SOFTIRQ-ON-W} state was registered at: [ 104.264417] _raw_spin_unlock_irq+0x29/0x4c [ 104.265014] blkg_lookup_create+0xdc/0xe6 [ 104.265609] bio_associate_blkg_from_css+0xd3/0x13f [ 104.266312] bio_associate_blkg+0x15a/0x1bb [ 104.266913] pool_map+0xe8/0x103 [dm_thin_pool] [ 104.267572] __map_bio+0x98/0x29c [dm_mod] [ 104.268162] __split_and_process_non_flush+0x29e/0x306 [dm_mod] [ 104.269003] __split_and_process_bio+0x16a/0x25b [dm_mod] [ 104.269971] __dm_make_request.isra.14+0xdc/0x124 [dm_mod] [ 104.270973] generic_make_request+0x3f5/0x68b [ 104.271676] process_prepared_mapping+0x166/0x1ef [dm_thin_pool] [ 104.272531] schedule_zero+0x239/0x273 [dm_thin_pool] [ 104.273245] process_cell+0x60c/0x6f1 [dm_thin_pool] [ 104.273967] do_worker+0x60c/0xca8 [dm_thin_pool] [ 104.274635] process_one_work+0x4eb/0x834 [ 104.275203] worker_thread+0x318/0x484 [ 104.275740] kthread+0x1d1/0x1e1 [ 104.276203] ret_from_fork+0x3a/0x50 [ 104.276714] irq event stamp: 170003 [ 104.277201] hardirqs last enabled at (170002): [<ffffffff81bcc33e>] _raw_spin_unlock_irqrestore+0x44/0x6b [ 104.278535] hardirqs last disabled at (170003): [<ffffffff81bcc1ad>] _raw_spin_lock_irqsave+0x20/0x55 [ 104.280273] softirqs last enabled at (169978): [<ffffffff810d13d4>] irq_enter+0x4c/0x73 [ 104.281617] softirqs last disabled at (169979): [<ffffffff810d1479>] irq_exit+0x7e/0x11d [ 104.282744] [ 104.282744] other info that might help us debug this: [ 104.283640] Possible unsafe locking scenario: [ 104.283640] [ 104.284452] CPU0 [ 104.284803] ---- [ 104.285150] lock(&(&pool->lock)->rlock#3); [ 104.285762] <Interrupt> [ 104.286130] lock(&(&pool->lock)->rlock#3); [ 104.286750] [ 104.286750] *** DEADLOCK *** [ 104.286750] [ 104.287564] no locks held by swapper/49/0. [ 104.288129] [ 104.288129] stack backtrace: [ 104.288738] CPU: 49 PID: 0 Comm: swapper/49 Not tainted 4.20.0-rc6+ #545 [ 104.289700] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.10.2-2.fc27 04/01/2014 [ 104.290858] Call Trace: [ 104.291204] <IRQ> [ 104.291502] dump_stack+0x9a/0xe6 [ 104.291968] mark_lock+0x56c/0x7a6 [ 104.292442] ? check_usage_backwards+0x209/0x209 [ 104.293086] __lock_acquire+0x400/0x15bf [ 104.293662] ? check_chain_key+0x150/0x1aa [ 104.294236] lock_acquire+0x1a6/0x1e3 [ 104.294768] ? thin_endio+0xcf/0x2a3 [dm_thin_pool] [ 104.295444] ? _raw_spin_unlock_irqrestore+0x44/0x6b [ 104.296143] ? process_prepared_discard_fail+0x36/0x36 [dm_thin_pool] [ 104.297031] _raw_spin_lock_irqsave+0x46/0x55 [ 104.297659] ? thin_endio+0xcf/0x2a3 [dm_thin_pool] [ 104.298335] thin_endio+0xcf/0x2a3 [dm_thin_pool] [ 104.298997] ? process_prepared_discard_fail+0x36/0x36 [dm_thin_pool] [ 104.299886] ? check_flags+0x20a/0x20a [ 104.300408] ? lock_acquire+0x1a6/0x1e3 [ 104.300954] ? process_prepared_discard_fail+0x36/0x36 [dm_thin_pool] [ 104.301865] clone_endio+0x1bb/0x22d [dm_mod] [ 104.302491] ? disable_write_zeroes+0x20/0x20 [dm_mod] [ 104.303200] ? bio_disassociate_blkg+0xc6/0x15f [ 104.303836] ? bio_endio+0x2b2/0x2da [ 104.304349] clone_endio+0x1f3/0x22d [dm_mod] [ 104.304978] ? disable_write_zeroes+0x20/0x20 [dm_mod] [ 104.305709] ? bio_disassociate_blkg+0xc6/0x15f [ 104.306333] ? bio_endio+0x2b2/0x2da [ 104.306853] clone_endio+0x1f3/0x22d [dm_mod] [ 104.307476] ? disable_write_zeroes+0x20/0x20 [dm_mod] [ 104.308185] ? bio_disassociate_blkg+0xc6/0x15f [ 104.308817] ? bio_endio+0x2b2/0x2da [ 104.309319] blk_update_request+0x2de/0x4cc [ 104.309927] blk_mq_end_request+0x2a/0x183 [ 104.310498] blk_done_softirq+0x16a/0x1a6 [ 104.311051] ? blk_softirq_cpu_dead+0xe2/0xe2 [ 104.311653] ? __lock_is_held+0x2a/0x87 [ 104.312186] __do_softirq+0x250/0x4e8 [ 104.312705] irq_exit+0x7e/0x11d [ 104.313157] call_function_single_interrupt+0xf/0x20 [ 104.313860] </IRQ> [ 104.314163] RIP: 0010:native_safe_halt+0x2/0x3 [ 104.314792] Code: 63 02 df f0 83 44 24 fc 00 48 89 df e8 cc 3f 7a ff 48 8b 03 a8 08 74 0b 65 81 25 9d 31 45 7e ff ff ff 7f 5b 5d 41 5c c3 fb f4 <c3> f4 c3 0f 1f 44 00 00 41 56 41 55 41 54 55 53 e8 a2 0d 5c ff e8 [ 104.317339] RSP: 0018:ffff888106c9fdc0 EFLAGS: 00000246 ORIG_RAX: ffffffffffffff04 [ 104.318390] RAX: 1ffff11020d92100 RBX: 0000000000000000 RCX: ffffffff81159ac7 [ 104.319366] RDX: 1ffffffff05d5e69 RSI: 0000000000000007 RDI: ffff888106c90d1c [ 104.320339] RBP: 0000000000000000 R08: dffffc0000000000 R09: 0000000000000001 [ 104.321313] R10: ffffed1025d57ba0 R11: ffffed1025d57b9f R12: 1ffff11020d93fbf [ 104.322328] R13: 0000000000000031 R14: ffff888106c90040 R15: 0000000000000000 [ 104.323307] ? lockdep_hardirqs_on+0x26b/0x278 [ 104.323927] default_idle+0xd9/0x1a8 [ 104.324427] do_idle+0x162/0x2b2 [ 104.324891] ? arch_cpu_idle_exit+0x28/0x28 [ 104.325467] ? mark_held_locks+0x28/0x7f [ 104.326031] ? _raw_spin_unlock_irqrestore+0x44/0x6b [ 104.326719] cpu_startup_entry+0x1d/0x1f [ 104.327261] start_secondary+0x2cb/0x308 [ 104.327806] ? set_cpu_sibling_map+0x8a3/0x8a3 [ 104.328421] secondary_startup_64+0xa4/0xb0 Fixes: b978962ad4 ("blkcg: update blkg_lookup_create() to do locking") Cc: Mike Snitzer <snitzer@redhat.com> Cc: Dennis Zhou <dennis@kernel.org> Signed-off-by: Ming Lei <ming.lei@redhat.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>		2018-12-19 09:35:45 -07:00
..
partitions	partitions/aix: append null character to print data from disk	2018-07-27 09:17:41 -06:00
badblocks.c	badblocks: fix wrong return value in badblocks_set if badblocks are disabled	2017-11-03 11:29:50 -07:00
bfq-cgroup.c	blkcg: fix ref count issue with bio_blkcg() using task_css	2018-12-07 22:26:36 -07:00
bfq-iosched.c	Linux 4.20-rc6	2018-12-09 17:45:40 -07:00
bfq-iosched.h	block, bfq: fix decrement of num_active_groups	2018-12-07 07:40:07 -07:00
bfq-wf2q.c	block, bfq: fix decrement of num_active_groups	2018-12-07 07:40:07 -07:00
bio-integrity.c	block: remove the bio_integrity_advance export	2018-12-16 08:33:57 -07:00
bio.c	block: remove the unused bio_set_pages_dirty and bio_check_pages_dirty exports	2018-12-14 06:17:58 -07:00
blk-cgroup.c	block: save irq state in blkg_lookup_create()	2018-12-19 09:35:45 -07:00
blk-core.c	block: clear REQ_HIPRI if polling is not supported	2018-12-16 09:01:38 -07:00
blk-exec.c	block: remove dead elevator code	2018-11-07 13:42:32 -07:00
blk-flush.c	block: add queue_is_mq() helper	2018-11-16 08:34:06 -07:00
blk-integrity.c	block: merge BIOVEC_SEG_BOUNDARY into biovec_phys_mergeable	2018-09-24 12:33:57 -06:00
blk-ioc.c	block: remove the queue_lock indirection	2018-11-15 12:17:28 -07:00
blk-iolatency.c	block: fix blk-iolatency accounting underflow	2018-12-17 11:19:54 -07:00
blk-lib.c	block: fix 32 bit overflow in __blkdev_issue_discard()	2018-11-14 08:17:18 -07:00
blk-map.c	Merge branch 'for-4.16/block' of git://git.kernel.dk/linux-block	2018-01-29 11:51:49 -08:00
blk-merge.c	block: remove the blk_recount_segments export	2018-12-14 06:17:55 -07:00
blk-mq-cpumap.c	blk-mq: initial support for multiple queue maps	2018-11-07 13:45:00 -07:00
blk-mq-debugfs-zoned.c	block: Make struct request_queue smaller for CONFIG_BLK_DEV_ZONED=n	2018-07-09 09:07:52 -06:00
blk-mq-debugfs.c	blk-mq: fix dispatch from sw queue	2018-12-17 11:19:54 -07:00
blk-mq-debugfs.h	blk-mq-debugfs: support rq_qos	2018-12-16 19:53:47 -07:00
blk-mq-pci.c	blk-mq: initial support for multiple queue maps	2018-11-07 13:45:00 -07:00
blk-mq-rdma.c	blk-mq-rdma: pass in queue map to blk_mq_rdma_map_queues	2018-12-13 09:59:08 +01:00
blk-mq-sched.c	blk-mq: fix dispatch from sw queue	2018-12-17 11:19:54 -07:00
blk-mq-sched.h	block: mq-deadline: Fix write completion handling	2018-12-17 11:19:39 -07:00
blk-mq-sysfs.c	blk-mq: export hctx->type in debugfs instead of sysfs	2018-12-17 05:44:45 -07:00
blk-mq-tag.c	sbitmap: optimize wakeup check	2018-11-30 14:48:04 -07:00
blk-mq-tag.h	Merge branch 'for-4.15/block' of git://git.kernel.dk/linux-block	2017-11-14 15:32:19 -08:00
blk-mq-virtio.c	blk-mq: initial support for multiple queue maps	2018-11-07 13:45:00 -07:00
blk-mq.c	block: make request_to_qc_t public	2018-12-18 17:50:47 +01:00
blk-mq.h	blk-mq: fix dispatch from sw queue	2018-12-17 11:19:54 -07:00
blk-pm.c	block: remove the queue_lock indirection	2018-11-15 12:17:28 -07:00
blk-pm.h	block: remove the queue_lock indirection	2018-11-15 12:17:28 -07:00
blk-rq-qos.c	blk-mq-debugfs: support rq_qos	2018-12-16 19:53:47 -07:00
blk-rq-qos.h	block: fix blk-iolatency accounting underflow	2018-12-17 11:19:54 -07:00
blk-settings.c	block: use atomic bitops for ->queue_flags	2018-11-15 12:13:19 -07:00
blk-softirq.c	block: remove a few unused exports	2018-11-15 12:13:25 -07:00
blk-stat.c	block: remove a few unused exports	2018-11-15 12:13:25 -07:00
blk-stat.h	block: deactivate blk_stat timer in wbt_disable_default()	2018-12-12 06:47:51 -07:00
blk-sysfs.c	blk-mq: enable IO poll if .nr_queues of type poll > 0	2018-12-17 21:35:07 -07:00
blk-throttle.c	blkcg: consolidate bio_issue_init() to be a part of core	2018-12-07 22:26:37 -07:00
blk-timeout.c	block: don't hold the queue_lock over blk_abort_request	2018-11-15 12:13:18 -07:00
blk-wbt.c	blk-wbt: export internal state via debugfs	2018-12-16 19:53:49 -07:00
blk-wbt.h	block: remove external dependency on wbt_flags	2018-07-09 09:07:54 -06:00
blk-zoned.c	block: add queue_is_mq() helper	2018-11-16 08:34:06 -07:00
blk.h	block: sum requests in the plug structure	2018-11-26 10:35:22 -07:00
bounce.c	blkcg: remove bio->bi_css and instead use bio->bi_blkg	2018-12-07 22:26:37 -07:00
bsg-lib.c	bsg: move bsg-lib parts outside of request queue	2018-11-07 13:42:33 -07:00
bsg.c	block: add queue_is_mq() helper	2018-11-16 08:34:06 -07:00
cmdline-parser.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
compat_ioctl.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
elevator.c	block: add queue_is_mq() helper	2018-11-16 08:34:06 -07:00
genhd.c	block: return just one value from part_in_flight	2018-12-10 08:30:38 -07:00
ioctl.c	block: Introduce BLKGETNRZONES ioctl	2018-10-25 11:17:40 -06:00
ioprio.c	block: add ioprio_check_cap function	2018-05-31 10:50:54 -04:00
Kconfig	blk-wbt: kill check for legacy queue type	2018-11-07 13:42:32 -07:00
Kconfig.iosched	block: remove legacy IO schedulers	2018-11-07 13:42:32 -07:00
kyber-iosched.c	blk-mq: allow software queue to map to multiple hardware queues	2018-11-07 13:44:59 -07:00
Makefile	block: remove legacy IO schedulers	2018-11-07 13:42:32 -07:00
mq-deadline.c	block: mq-deadline: Fix write completion handling	2018-12-17 11:19:39 -07:00
opal_proto.h	block: sed-opal: Set MBRDone on S3 resume path if TPER is MBREnabled	2017-09-11 09:45:52 -06:00
partition-generic.c	block: return just one value from part_in_flight	2018-12-10 08:30:38 -07:00
scsi_ioctl.c	block: consistently use GFP_NOIO instead of __GFP_NORECLAIM	2018-05-14 08:55:18 -06:00
sed-opal.c	block: sed-opal: Fix a couple off by one bugs	2018-06-20 12:04:06 -06:00
t10-pi.c	block: move dif_prepare/dif_complete functions to block layer	2018-07-30 08:27:02 -06:00