Mirsad Goran Todorovac
94f3bc7e84
test_firmware: fix the memory leak of the allocated firmware buffer
...
commit 48e156023059e57a8fc68b498439832f7600ffff upstream.
The following kernel memory leak was noticed after running
tools/testing/selftests/firmware/fw_run_tests.sh:
[root@pc-mtodorov firmware]# cat /sys/kernel/debug/kmemleak
.
.
.
unreferenced object 0xffff955389bc3400 (size 1024):
comm "test_firmware-0", pid 5451, jiffies 4294944822 (age 65.652s)
hex dump (first 32 bytes):
47 48 34 35 36 37 0a 00 00 00 00 00 00 00 00 00 GH4567..........
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff962f5dec>] slab_post_alloc_hook+0x8c/0x3c0
[<ffffffff962fcca4>] __kmem_cache_alloc_node+0x184/0x240
[<ffffffff962704de>] kmalloc_trace+0x2e/0xc0
[<ffffffff9665b42d>] test_fw_run_batch_request+0x9d/0x180
[<ffffffff95fd813b>] kthread+0x10b/0x140
[<ffffffff95e033e9>] ret_from_fork+0x29/0x50
unreferenced object 0xffff9553c334b400 (size 1024):
comm "test_firmware-1", pid 5452, jiffies 4294944822 (age 65.652s)
hex dump (first 32 bytes):
47 48 34 35 36 37 0a 00 00 00 00 00 00 00 00 00 GH4567..........
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff962f5dec>] slab_post_alloc_hook+0x8c/0x3c0
[<ffffffff962fcca4>] __kmem_cache_alloc_node+0x184/0x240
[<ffffffff962704de>] kmalloc_trace+0x2e/0xc0
[<ffffffff9665b42d>] test_fw_run_batch_request+0x9d/0x180
[<ffffffff95fd813b>] kthread+0x10b/0x140
[<ffffffff95e033e9>] ret_from_fork+0x29/0x50
unreferenced object 0xffff9553c334f000 (size 1024):
comm "test_firmware-2", pid 5453, jiffies 4294944822 (age 65.652s)
hex dump (first 32 bytes):
47 48 34 35 36 37 0a 00 00 00 00 00 00 00 00 00 GH4567..........
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff962f5dec>] slab_post_alloc_hook+0x8c/0x3c0
[<ffffffff962fcca4>] __kmem_cache_alloc_node+0x184/0x240
[<ffffffff962704de>] kmalloc_trace+0x2e/0xc0
[<ffffffff9665b42d>] test_fw_run_batch_request+0x9d/0x180
[<ffffffff95fd813b>] kthread+0x10b/0x140
[<ffffffff95e033e9>] ret_from_fork+0x29/0x50
unreferenced object 0xffff9553c3348400 (size 1024):
comm "test_firmware-3", pid 5454, jiffies 4294944822 (age 65.652s)
hex dump (first 32 bytes):
47 48 34 35 36 37 0a 00 00 00 00 00 00 00 00 00 GH4567..........
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff962f5dec>] slab_post_alloc_hook+0x8c/0x3c0
[<ffffffff962fcca4>] __kmem_cache_alloc_node+0x184/0x240
[<ffffffff962704de>] kmalloc_trace+0x2e/0xc0
[<ffffffff9665b42d>] test_fw_run_batch_request+0x9d/0x180
[<ffffffff95fd813b>] kthread+0x10b/0x140
[<ffffffff95e033e9>] ret_from_fork+0x29/0x50
[root@pc-mtodorov firmware]#
Note that the size 1024 corresponds to the size of the test firmware
buffer. The actual number of the buffers leaked is around 70-110,
depending on the test run.
The cause of the leak is the following:
request_partial_firmware_into_buf() and request_firmware_into_buf()
provided firmware buffer isn't released on release_firmware(), we
have allocated it and we are responsible for deallocating it manually.
This is introduced in a number of context where previously only
release_firmware() was called, which was insufficient.
Reported-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
Fixes: 7feebfa487b92 ("test_firmware: add support for request_firmware_into_buf")
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Dan Carpenter <error27@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: Russ Weight <russell.h.weight@intel.com>
Cc: Tianfei zhang <tianfei.zhang@intel.com>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Zhengchao Shao <shaozhengchao@huawei.com>
Cc: Colin Ian King <colin.i.king@gmail.com>
Cc: linux-kernel@vger.kernel.org
Cc: Kees Cook <keescook@chromium.org>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: Luis R. Rodriguez <mcgrof@kernel.org>
Cc: linux-kselftest@vger.kernel.org
Cc: stable@vger.kernel.org # v5.4
Signed-off-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
Link: https://lore.kernel.org/r/20230509084746.48259-3-mirsad.todorovac@alu.unizg.hr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-06-09 10:29:03 +02:00
..
2019-07-03 16:57:17 +02:00
2022-06-22 14:11:02 +02:00
2023-05-30 12:44:01 +01:00
2023-01-18 11:40:54 +01:00
2019-02-06 11:01:57 +01:00
2022-04-15 14:18:39 +02:00
2020-06-17 16:40:28 +02:00
2019-05-21 10:50:46 +02:00
2023-03-11 16:43:38 +01:00
2022-04-15 14:18:23 +02:00
2019-07-02 08:41:37 +02:00
2022-12-08 11:22:59 +01:00
2021-11-17 09:48:31 +01:00
2019-05-21 10:50:46 +02:00
2020-06-24 17:50:39 +02:00
2019-09-15 19:42:16 +02:00
2018-08-22 10:52:48 -07:00
2018-06-12 16:19:22 -07:00
2019-05-24 17:39:02 +02:00
2019-05-24 17:39:02 +02:00
2019-05-24 17:27:11 +02:00
2022-06-06 08:33:50 +02:00
2019-05-30 11:26:32 -07:00
2019-06-03 12:32:56 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2018-10-12 09:17:46 +02:00
2019-07-25 15:47:37 +02:00
2019-05-21 10:50:45 +02:00
2019-06-05 17:37:10 +02:00
2019-06-05 17:37:16 +02:00
2018-08-16 12:14:42 -07:00
2021-05-14 09:44:27 +02:00
2019-05-24 17:27:11 +02:00
2018-11-30 07:22:05 +01:00
2019-05-30 11:26:32 -07:00
2017-11-02 11:10:55 +01:00
2019-05-30 11:26:32 -07:00
2019-06-19 17:09:55 +02:00
2017-11-02 11:10:55 +01:00
2019-06-19 17:09:06 +02:00
2019-05-24 17:39:02 +02:00
2017-11-02 11:10:55 +01:00
2023-05-30 12:44:03 +01:00
2019-03-12 10:04:02 -07:00
2019-06-19 17:09:06 +02:00
2019-06-19 17:09:06 +02:00
2017-09-26 15:01:20 -06:00
2019-06-19 17:09:06 +02:00
2020-10-29 09:57:52 +01:00
2018-07-27 19:04:33 +08:00
2020-11-10 12:37:27 +01:00
2018-08-22 10:52:48 -07:00
2019-06-19 17:09:06 +02:00
2019-06-19 17:09:06 +02:00
2020-08-19 08:15:54 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2023-05-30 12:44:09 +01:00
2018-06-12 23:33:24 +02:00
2018-07-27 19:16:38 +08:00
2017-11-02 11:10:55 +01:00
2021-07-20 16:10:46 +02:00
2019-05-24 17:37:53 +02:00
2021-11-17 09:48:31 +01:00
2017-11-02 11:10:55 +01:00
2020-08-21 13:05:32 +02:00
2019-07-10 18:43:43 -07:00
2019-11-06 08:47:50 -08:00
2023-06-09 10:29:02 +02:00
2017-11-15 11:56:19 -08:00
2019-06-05 17:36:37 +02:00
2019-04-09 14:19:06 +02:00
2018-04-27 08:51:26 -04:00
2019-09-25 17:51:39 -07:00
2019-06-18 13:47:24 +02:00
2019-06-05 17:36:38 +02:00
2020-04-13 10:48:07 +02:00
2017-11-02 11:10:55 +01:00
2018-07-27 19:04:33 +08:00
2018-12-29 11:36:44 -08:00
2021-01-12 20:16:10 +01:00
2019-10-14 15:04:00 -07:00
2017-02-24 17:46:57 -08:00
2017-02-24 17:46:57 -08:00
2022-05-09 09:03:22 +02:00
2019-05-13 11:07:33 +02:00
2022-07-12 16:30:49 +02:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:56 +02:00
2019-01-22 13:39:59 +01:00
2018-05-09 06:55:44 +02:00
2019-07-16 19:23:22 -07:00
2023-01-18 11:41:55 +01:00
2019-02-19 20:52:19 -07:00
2019-05-30 11:26:32 -07:00
2019-05-24 17:27:11 +02:00
2017-11-02 11:10:55 +01:00
2022-03-19 13:40:16 +01:00
2022-12-08 11:23:05 +01:00
2019-09-24 15:54:07 -07:00
2019-05-21 10:50:46 +02:00
2019-05-21 10:50:46 +02:00
2019-08-30 18:47:15 -07:00
2019-06-19 17:09:08 +02:00
2021-05-19 10:08:33 +02:00
2020-09-17 13:47:52 +02:00
2021-07-14 16:53:16 +02:00
2021-07-14 16:53:16 +02:00
2019-05-30 11:26:32 -07:00
2022-08-25 11:18:36 +02:00
2019-06-20 14:07:34 -06:00
2019-06-05 17:37:06 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-02-28 07:55:43 +01:00
2023-02-06 07:52:42 +01:00
2021-03-17 17:03:44 +01:00
2019-05-24 17:37:53 +02:00
2019-05-24 17:39:02 +02:00
2021-05-07 10:51:37 +02:00
2018-10-16 13:45:44 +02:00
2019-05-21 10:50:45 +02:00
2017-11-02 11:10:55 +01:00
2019-05-24 17:39:02 +02:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2023-02-06 07:52:45 +01:00
2018-07-09 14:10:40 +02:00
2022-06-14 18:12:02 +02:00
2023-01-18 11:40:55 +01:00
2017-11-02 11:10:55 +01:00
2019-06-05 19:03:39 -07:00
2019-05-21 10:50:45 +02:00
2019-05-24 17:27:11 +02:00
2022-10-26 13:22:27 +02:00
2019-05-03 10:49:17 -04:00
2017-02-03 16:35:42 -05:00
2019-06-19 17:09:06 +02:00
2018-01-26 11:45:16 -06:00
2018-08-30 12:56:40 +02:00
2019-05-21 10:50:45 +02:00
2019-07-14 16:17:18 -07:00
2019-05-21 11:28:45 +02:00
2019-05-21 10:50:45 +02:00
2023-06-09 10:29:01 +02:00
2022-06-22 14:11:13 +02:00
2022-09-05 10:27:42 +02:00
2019-09-25 17:51:39 -07:00
2019-07-16 19:23:22 -07:00
2022-07-29 17:14:17 +02:00
2019-06-19 17:09:55 +02:00
2020-01-12 12:21:44 +01:00
2020-11-05 11:43:22 +01:00
2021-07-19 08:53:16 +02:00
2019-07-11 15:17:41 -07:00
2019-08-08 07:45:01 -06:00
2022-06-22 14:11:03 +02:00
2019-09-24 15:54:09 -07:00
2022-06-22 14:11:16 +02:00
2019-06-03 11:49:37 +02:00
2019-08-19 13:14:53 -03:00
2021-05-22 11:38:30 +02:00
2019-05-30 11:26:32 -07:00
2019-07-16 19:23:22 -07:00
2020-10-01 13:18:23 +02:00
2020-01-29 16:45:29 +01:00
2020-01-29 16:45:29 +01:00
2020-12-11 13:23:32 +01:00
2018-06-27 18:58:49 +03:00
2019-05-21 10:50:45 +02:00
2019-07-01 19:34:46 -07:00
2021-09-22 12:26:29 +02:00
2019-05-21 10:50:45 +02:00
2023-06-09 10:29:03 +02:00
2019-05-21 10:50:45 +02:00
2018-11-30 12:13:15 -08:00
2018-10-15 16:31:29 -04:00
2020-06-22 09:31:12 +02:00
2022-04-15 14:18:21 +02:00
2019-05-21 10:50:45 +02:00
2018-10-16 13:45:44 +02:00
2022-01-27 09:19:55 +01:00
2019-05-21 10:50:45 +02:00
2020-06-30 15:37:04 -04:00
2019-07-16 19:23:22 -07:00
2017-02-26 11:03:38 -05:00
2020-05-27 17:46:43 +02:00
2019-06-19 17:09:55 +02:00
2019-05-21 10:50:45 +02:00
2021-09-22 12:26:38 +02:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:36:37 +02:00
2019-07-16 19:23:22 -07:00
2019-04-08 16:44:21 -06:00
2019-05-14 19:52:51 -07:00
2019-03-07 18:32:00 -08:00
2019-10-16 14:56:21 +02:00
2017-07-21 09:38:30 +02:00
2019-05-14 19:52:49 -07:00
2022-04-15 14:18:28 +02:00
2019-10-03 12:12:23 -04:00
2019-07-24 17:38:01 +02:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2020-01-09 10:20:07 +01:00
2019-05-06 11:12:09 -07:00
2019-05-24 17:39:02 +02:00
2018-06-07 17:34:39 -07:00
2023-02-25 11:53:26 +01:00
2019-05-30 11:26:41 -07:00
2022-06-22 14:11:13 +02:00
2017-11-02 11:10:55 +01:00
2022-04-15 14:18:28 +02:00
2017-08-15 09:02:07 -07:00