Geliang Tang
724d06b437
mptcp: fix static checker warnings in mptcp_pm_add_timer ...
Fix the following Smatch complaint:
net/mptcp/pm_netlink.c:213 mptcp_pm_add_timer()
warn: variable dereferenced before check 'msk' (see line 208)
net/mptcp/pm_netlink.c
207 struct mptcp_sock *msk = entry->sock;
208 struct sock *sk = (struct sock *)msk;
209 struct net *net = sock_net(sk);
^^
"msk" dereferenced here.
210
211 pr_debug("msk=%p", msk);
212
213 if (!msk)
^^^^
Too late.
214 return;
215
Fixes: 93f323b9cccc ("mptcp: add a new sysctl add_addr_timeout")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
Link: https://lore.kernel.org/r/078a2ef5bdc4e3b2c25ef852461692001f426495.1604976945.git.geliangtang@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2020-11-12 07:54:15 -08:00
2020-06-14 01:57:21 +09:00
2020-11-02 12:25:52 -08:00
2020-09-28 00:51:39 -07:00
2020-10-30 11:48:17 -07:00
2020-10-31 12:26:30 -07:00
2020-07-25 17:49:04 -07:00
2020-10-02 19:11:11 -07:00
2020-10-29 17:22:59 -05:00
2020-09-30 08:34:08 -07:00
2020-10-15 12:33:24 -07:00
2020-11-09 16:42:12 -08:00
2020-09-05 15:57:05 -07:00
2020-11-03 22:30:32 +01:00
2020-10-12 15:29:27 +02:00
2020-11-09 20:03:55 -08:00
2020-10-30 11:59:54 -07:00
2020-11-07 10:40:56 -08:00
2020-08-23 17:36:59 -05:00
2020-11-09 17:50:27 -08:00
2020-11-02 17:50:53 -08:00
2020-10-02 19:11:11 -07:00
2020-10-02 19:11:11 -07:00
2020-11-11 17:45:55 -08:00
2020-11-10 17:57:14 -08:00
2020-10-03 16:51:07 -07:00
2020-07-24 15:41:54 -07:00
2020-08-02 01:02:12 -07:00
2020-10-02 19:11:11 -07:00
2020-10-30 11:43:42 -07:00
2020-06-14 01:57:21 +09:00
2020-10-30 11:34:09 -07:00
2020-11-07 10:40:56 -08:00
2020-11-07 10:40:56 -08:00
2020-11-03 12:55:53 -08:00
2020-11-12 07:54:15 -08:00
2020-10-02 19:11:11 -07:00
2020-11-06 17:33:38 -08:00
2020-10-30 11:46:11 -07:00
2020-10-09 20:22:32 -07:00
2020-08-23 17:36:59 -05:00
2020-10-30 11:57:56 -07:00
2020-06-14 01:57:21 +09:00
2020-11-06 17:33:38 -08:00
2020-11-09 16:41:40 -08:00
2020-08-23 17:36:59 -05:00
2020-10-02 19:11:11 -07:00
2020-11-11 15:29:34 -08:00
2020-10-28 09:14:49 -03:00
2020-08-23 17:36:59 -05:00
2020-10-15 13:28:00 +01:00
2020-11-10 17:00:28 -08:00
2020-11-06 17:33:38 -08:00
2020-11-07 10:41:15 -08:00
2020-10-22 09:44:27 -07:00
2020-09-23 17:46:31 -07:00
2020-11-02 17:50:43 -08:00
2020-10-15 12:43:21 -07:00
2020-10-15 18:42:13 -07:00
2020-10-29 17:43:20 -07:00
2020-10-30 10:06:56 +01:00
2020-08-23 17:36:59 -05:00
2020-10-12 16:16:50 -07:00
2020-11-07 10:41:15 -08:00
2020-10-03 00:02:13 -04:00
2020-06-30 15:57:34 -07:00
2020-10-29 19:27:45 +01:00
2020-10-29 19:27:45 +01:00
2020-10-05 18:40:01 -07:00
724d06b437