Andreas Gruenbacher 95ecbd0f16 Revert "gfs2: stop using generic_writepages in gfs2_ail1_start_one"
Commit b2b0a5e97855 switched from generic_writepages() to
filemap_fdatawrite_wbc() in gfs2_ail1_start_one() on the path to
replacing ->writepage() with ->writepages() and eventually eliminating
the former.  Function gfs2_ail1_start_one() is called from
gfs2_log_flush(), our main function for flushing the filesystem log.

Unfortunately, at least as implemented today, ->writepage() and
->writepages() are entirely different operations for journaled data
inodes: while the former creates and submits transactions covering the
data to be written, the latter flushes dirty buffers out to disk.

With gfs2_ail1_start_one() now calling ->writepages(), we end up
creating filesystem transactions while we are in the course of a log
flush, which immediately deadlocks on the sdp->sd_log_flush_lock
semaphore.

Work around that by going back to how things used to work before commit
b2b0a5e97855 for now; figuring out a superior solution will take time we
don't have available right now.  However ...

Since the removal of generic_writepages() is imminent, open-code it
here.  We're already inside a blk_start_plug() ...  blk_finish_plug()
section here, so skip that part of the original generic_writepages().

This reverts commit b2b0a5e978552e348f85ad9c7568b630a5ede659.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Acked-by: Christoph Hellwig <hch@lst.de>
2023-01-22 09:46:14 +01:00
..
2022-12-23 11:39:18 -08:00
2023-01-06 12:01:49 -08:00
2022-12-13 10:43:59 -08:00
2022-12-12 20:14:04 -08:00
2022-12-15 18:14:21 -08:00
\n
2022-12-12 20:32:50 -08:00
2022-12-13 19:29:45 -08:00
2022-12-13 19:29:45 -08:00
2022-12-13 19:29:45 -08:00
2022-12-11 18:12:18 -08:00
2022-12-14 10:11:51 -08:00
2022-10-20 10:13:27 +02:00
2022-12-13 19:29:45 -08:00
2022-12-12 20:54:39 -08:00
2022-09-24 07:00:00 +02:00
2023-01-07 10:38:11 -08:00
2023-01-10 15:03:06 -06:00
2022-12-11 18:12:18 -08:00
2022-12-12 20:18:26 -08:00
2022-12-15 11:12:21 -08:00
2022-12-23 11:55:54 -08:00
2022-10-10 19:45:17 -07:00
2022-12-13 09:47:48 -08:00
2022-05-09 16:21:46 -04:00
2022-12-12 20:24:51 -08:00
2023-01-06 15:44:32 +01:00
2022-09-11 20:26:07 -07:00
2023-01-05 07:34:21 -08:00
2022-11-25 17:01:22 +09:00
2022-10-20 10:13:27 +02:00
2022-12-14 12:20:00 -08:00
2022-08-20 11:34:33 -04:00
2022-12-11 18:12:17 -08:00
2022-10-10 19:45:17 -07:00
2022-12-12 19:20:05 -08:00
2022-12-15 18:09:48 -08:00
2022-12-12 19:20:05 -08:00
2022-12-12 19:03:10 -08:00
2022-04-01 19:35:56 -07:00
2022-10-10 14:21:11 -07:00
2022-08-03 10:35:43 -07:00
2022-12-13 09:14:50 -08:00
2022-12-12 19:30:18 -08:00
2022-12-13 09:14:50 -08:00
2022-12-21 14:45:25 +01:00
2022-12-12 19:30:18 -08:00
2022-06-28 13:58:05 -04:00
2022-12-13 10:26:38 -08:00
2022-10-26 10:02:34 +02:00
2022-12-12 18:38:47 -08:00