iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/sched
History
Baowen Zheng 963178a063 flow_offload: fix suspicious RCU usage when offloading tc action 
Fix suspicious rcu_dereference_protected() usage when offloading tc action.

We should hold tcfa_lock to offload tc action in action initiation.

Without these changes, the following warning will be observed:

WARNING: suspicious RCU usage
5.16.0-rc5-net-next-01504-g7d1f236dcffa-dirty #50 Tainted: G          I
-----------------------------
include/net/tc_act/tc_tunnel_key.h:33 suspicious rcu_dereference_protected() usage!
1 lock held by tc/12108:
CPU: 4 PID: 12108 Comm: tc Tainted: G
Hardware name: Dell Inc. PowerEdge R740/07WCGN, BIOS 1.6.11 11/20/2018
Call Trace:
<TASK>
dump_stack_lvl+0x49/0x5e
dump_stack+0x10/0x12
lockdep_rcu_suspicious+0xed/0xf8
tcf_tunnel_key_offload_act_setup+0x1de/0x300 [act_tunnel_key]
tcf_action_offload_add_ex+0xc0/0x1f0
tcf_action_init+0x26a/0x2f0
tcf_action_add+0xa9/0x1f0
tc_ctl_action+0xfb/0x170
rtnetlink_rcv_msg+0x169/0x510
? sched_clock+0x9/0x10
? rtnl_newlink+0x70/0x70
netlink_rcv_skb+0x55/0x100
rtnetlink_rcv+0x15/0x20
netlink_unicast+0x1a8/0x270
netlink_sendmsg+0x245/0x490
sock_sendmsg+0x65/0x70
____sys_sendmsg+0x219/0x260
? __import_iovec+0x2c/0x150
___sys_sendmsg+0xb7/0x100
? __lock_acquire+0x3d5/0x1f40
? __this_cpu_preempt_check+0x13/0x20
? lock_is_held_type+0xe4/0x140
? sched_clock+0x9/0x10
? ktime_get_coarse_real_ts64+0xbe/0xd0
? __this_cpu_preempt_check+0x13/0x20
? lockdep_hardirqs_on+0x7e/0x100
? ktime_get_coarse_real_ts64+0xbe/0xd0
? trace_hardirqs_on+0x2a/0xf0
__sys_sendmsg+0x5a/0xa0
? syscall_trace_enter.constprop.0+0x1dd/0x220
__x64_sys_sendmsg+0x1f/0x30
do_syscall_64+0x3b/0x90
entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x7f4db7bb7a60

Fixes: 8cbfe939abe9 ("flow_offload: allow user to offload tc action to net device")
Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Baowen Zheng <baowen.zheng@corigine.com>
Signed-off-by: Louis Peens <louis.peens@corigine.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2021-12-23 11:17:00 +00:00
..
act_api.c
flow_offload: fix suspicious RCU usage when offloading tc action
2021-12-23 11:17:00 +00:00
act_bpf.c
flow_offload: fill flags to action structure
2021-12-19 14:08:47 +00:00
act_connmark.c
flow_offload: fill flags to action structure
2021-12-19 14:08:47 +00:00
act_csum.c
flow_offload: allow user to offload tc action to net device
2021-12-19 14:08:48 +00:00
act_ct.c
flow_offload: allow user to offload tc action to net device
2021-12-19 14:08:48 +00:00
act_ctinfo.c
flow_offload: fill flags to action structure
2021-12-19 14:08:47 +00:00
act_gact.c
flow_offload: allow user to offload tc action to net device
2021-12-19 14:08:48 +00:00
act_gate.c
flow_offload: allow user to offload tc action to net device
2021-12-19 14:08:48 +00:00
act_ife.c
flow_offload: fill flags to action structure
2021-12-19 14:08:47 +00:00
act_ipt.c
flow_offload: fill flags to action structure
2021-12-19 14:08:47 +00:00
act_meta_mark.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
act_meta_skbprio.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
act_meta_skbtcindex.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
act_mirred.c
flow_offload: allow user to offload tc action to net device
2021-12-19 14:08:48 +00:00
act_mpls.c
flow_offload: allow user to offload tc action to net device
2021-12-19 14:08:48 +00:00
act_nat.c
flow_offload: fill flags to action structure
2021-12-19 14:08:47 +00:00
act_pedit.c
flow_offload: add ops to tc_action_ops for flow action setup
2021-12-19 14:08:48 +00:00
act_police.c
flow_offload: allow user to offload tc action to net device
2021-12-19 14:08:48 +00:00
act_sample.c
flow_offload: allow user to offload tc action to net device
2021-12-19 14:08:48 +00:00
act_simple.c
flow_offload: fill flags to action structure
2021-12-19 14:08:47 +00:00
act_skbedit.c
flow_offload: allow user to offload tc action to net device
2021-12-19 14:08:48 +00:00
act_skbmod.c
flow_offload: fill flags to action structure
2021-12-19 14:08:47 +00:00
act_tunnel_key.c
flow_offload: allow user to offload tc action to net device
2021-12-19 14:08:48 +00:00
act_vlan.c
flow_offload: allow user to offload tc action to net device
2021-12-19 14:08:48 +00:00
cls_api.c
net/sched: use min() macro instead of doing it manually
2021-12-21 10:16:47 +00:00
cls_basic.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
cls_bpf.c
bpf: Refactor BPF_PROG_RUN into a function
2021-08-17 00:45:07 +02:00
cls_cgroup.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
cls_flow.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
cls_flower.c
flow_offload: validate flags of filter and actions
2021-12-19 14:08:48 +00:00
cls_fw.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
cls_matchall.c
flow_offload: validate flags of filter and actions
2021-12-19 14:08:48 +00:00
cls_route.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
cls_rsvp6.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
cls_rsvp.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
cls_rsvp.h
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
cls_tcindex.c
net_sched: refactor TC action init API
2021-08-02 10:24:38 +01:00
cls_u32.c
flow_offload: validate flags of filter and actions
2021-12-19 14:08:48 +00:00
em_canid.c
net: sched: kerneldoc fixes
2020-07-13 17:20:40 -07:00
em_cmp.c
net: sched: fix misspellings using misspell-fixer tool
2020-11-10 17:00:28 -08:00
em_ipset.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-03 14:34:53 -07:00
em_ipt.c
sched: consistently handle layer3 header accesses in the presence of VLANs
2020-07-03 14:34:53 -07:00
em_meta.c
net: introduce sk_forward_alloc_get()
2021-10-27 18:20:29 -07:00
em_nbyte.c
net: sched: Return the correct errno code
2021-02-06 11:15:28 -08:00
em_text.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
em_u32.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
ematch.c
net: sched: Fix spelling mistakes
2021-05-31 22:44:56 -07:00
Kconfig
net: sched: incorrect Kconfig dependencies on Netfilter modules
2020-12-09 15:49:29 -08:00
Makefile
net/sched: sch_frag: add generic packet fragment support.
2020-11-27 14:36:02 -08:00
sch_api.c
net: sched: Remove Qdisc::running sequence counter
2021-10-18 12:54:41 +01:00
sch_atm.c
net: sched: Remove Qdisc::running sequence counter
2021-10-18 12:54:41 +01:00
sch_blackhole.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_cake.c
sch_cake: do not call cake_destroy() from cake_init()
2021-12-10 08:11:36 -08:00
sch_cbq.c
net: sched: Remove Qdisc::running sequence counter
2021-10-18 12:54:41 +01:00
sch_cbs.c
net: don't include ethtool.h from netdevice.h
2020-11-23 17:27:04 -08:00
sch_choke.c
net: sched: validate stab values
2021-03-10 15:47:52 -08:00
sch_codel.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_drr.c
net: sched: Remove Qdisc::running sequence counter
2021-10-18 12:54:41 +01:00
sch_dsmark.c
net/sched: store the last executed chain also for clsact egress
2021-07-29 22:17:37 +01:00
sch_etf.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_ets.c
net/sched: sch_ets: don't remove idle classes from the round-robin list
2021-12-13 12:30:23 +00:00
sch_fifo.c
net_sched: fix NULL deref in fifo_set_limit()
2021-10-01 14:59:10 -07:00
sch_fq_codel.c
fq_codel: generalise ce_threshold marking for subset of traffic
2021-10-20 15:24:36 -07:00
sch_fq_pie.c
net/sched: fq_pie: prevent dismantle issue
2021-12-09 08:01:00 -08:00
sch_fq.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_frag.c
net/sched: sch_frag: fix stack OOB read while fragmenting IPv4 packets
2021-04-29 15:31:53 -07:00
sch_generic.c
net: watchdog: add net device refcount tracker
2021-12-07 20:44:58 -08:00
sch_gred.c
net: sched: gred: dynamically allocate tc_gred_qopt_offload
2021-10-27 12:06:52 -07:00
sch_hfsc.c
net: sched: Remove Qdisc::running sequence counter
2021-10-18 12:54:41 +01:00
sch_hhf.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_htb.c
sch_htb: Add extack messages for EOPNOTSUPP errors
2021-10-28 14:34:03 +01:00
sch_ingress.c
net: sched: Pass ingress block to tcf_classify_ingress
2020-02-19 17:49:48 -08:00
sch_mq.c
net: sched: Remove Qdisc::running sequence counter
2021-10-18 12:54:41 +01:00
sch_mqprio.c
net: sched: Remove Qdisc::running sequence counter
2021-10-18 12:54:41 +01:00
sch_multiq.c
net: sched: Remove Qdisc::running sequence counter
2021-10-18 12:54:41 +01:00
sch_netem.c
net: sched: sch_netem: Refactor code in 4-state loss generator
2021-11-15 13:23:23 +00:00
sch_pie.c
net: sched: fix misspellings using misspell-fixer tool
2020-11-10 17:00:28 -08:00
sch_plug.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_prio.c
net: sched: Remove Qdisc::running sequence counter
2021-10-18 12:54:41 +01:00
sch_qfq.c
net: sched: Remove Qdisc::running sequence counter
2021-10-18 12:54:41 +01:00
sch_red.c
net: sched: validate stab values
2021-03-10 15:47:52 -08:00
sch_sfb.c
net/sched: store the last executed chain also for clsact egress
2021-07-29 22:17:37 +01:00
sch_sfq.c
net/sched: store the last executed chain also for clsact egress
2021-07-29 22:17:37 +01:00
sch_skbprio.c
Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"
2020-07-16 16:48:34 -07:00
sch_taprio.c
net/sched: sch_taprio: fix undefined behavior in ktime_mono_to_any
2021-11-09 19:16:23 -08:00
sch_tbf.c
net: sch_tbf: Add a graft command
2021-10-19 12:24:51 +01:00
sch_teql.c
net: sched: sch_teql: fix null-pointer dereference
2021-04-08 14:14:42 -07:00