Julia Lawall
971370cc18
drivers/rtc: introduce missing kfree ...
Error handling code following a kzalloc should free the allocated data.
The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/ )
// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@
x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
when != if (...) { <+...x...+> }
(
x->f1 = E
|
(x->f1 == NULL || ...)
|
f(...,x->f1,...)
)
...>
(
return \(0\|<+...x...+>\|ptr\);
|
return@p2 ...;
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: David Brownell <david-b@pacbell.net>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-09-23 07:39:45 -07:00
2009-09-20 20:18:57 +02:00
2009-09-12 12:01:34 +01:00
2009-09-21 15:15:53 +02:00
2009-09-22 07:17:27 -07:00
2009-09-23 07:39:29 -07:00
2009-09-15 10:17:16 -07:00
2009-09-22 07:17:25 -07:00
2009-09-23 07:39:29 -07:00
2009-09-23 07:39:29 -07:00
2009-09-18 09:16:57 -07:00
2009-09-22 07:17:45 -07:00
2009-09-14 20:27:00 +02:00
2009-09-21 15:14:54 +02:00
2009-09-15 09:50:47 -07:00
2009-09-22 07:17:38 -07:00
2009-09-23 07:39:43 -07:00
2009-09-22 07:51:45 -07:00
2009-09-22 07:51:28 -07:00
2009-09-23 07:39:43 -07:00
2009-09-19 23:36:56 +01:00
2009-09-22 07:51:45 -07:00
2009-09-02 23:07:36 -07:00
2009-09-01 01:14:07 -07:00
2009-09-23 07:39:41 -07:00
2009-09-23 07:39:43 -07:00
2009-09-23 07:39:29 -07:00
2009-09-23 07:39:43 -07:00
2009-09-21 15:14:55 +02:00
2009-09-21 15:14:58 +02:00
2009-09-22 07:51:45 -07:00
2009-09-22 07:51:45 -07:00
2009-09-22 07:17:25 -07:00
2009-09-22 07:51:45 -07:00
2009-09-23 07:39:43 -07:00
2009-09-23 07:39:43 -07:00
2009-09-23 07:39:43 -07:00
2009-09-23 07:39:43 -07:00
2009-09-23 07:39:43 -07:00
2009-09-23 07:39:43 -07:00
2009-09-22 07:17:24 -07:00
2009-09-22 07:17:38 -07:00
2009-09-16 07:49:54 -07:00
2009-09-22 07:17:42 -07:00
2009-09-14 20:26:59 +02:00
2009-09-22 07:17:49 -07:00
2009-09-11 11:28:00 +10:00
2009-09-17 15:48:24 +02:00
2009-09-23 07:39:45 -07:00
2009-09-22 07:51:45 -07:00
2009-09-22 07:17:25 -07:00
2009-09-23 07:39:29 -07:00
2009-09-23 07:39:43 -07:00
2009-09-23 07:39:44 -07:00
2009-09-16 16:21:00 -04:00
2009-09-23 07:39:43 -07:00
2009-09-18 09:43:09 -07:00
2009-09-22 07:51:45 -07:00
2009-09-21 15:14:58 +02:00
2009-09-23 07:39:43 -07:00
2009-09-23 07:39:30 -07:00
2009-09-18 08:39:37 +00:00
2009-09-22 07:51:45 -07:00
971370cc18