Bart Van Assche 978b7922d3 scsi: core: Fix a race between scsi_done() and scsi_timeout()
If there is a race between scsi_done() and scsi_timeout() and if
scsi_timeout() loses the race, scsi_timeout() should not reset the request
timer. Hence change the return value for this case from BLK_EH_RESET_TIMER
into BLK_EH_DONE.

Although the block layer holds a reference on a request (req->ref) while
calling a timeout handler, restarting the timer (blk_add_timer()) while a
request is being completed is racy.

Reviewed-by: Mike Christie <michael.christie@oracle.com>
Cc: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>
Cc: John Garry <john.garry@huawei.com>
Cc: Hannes Reinecke <hare@suse.de>
Reported-by: Adrian Hunter <adrian.hunter@intel.com>
Fixes: 15f73f5b3e59 ("blk-mq: move failure injection out of blk_mq_complete_request")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20221018202958.1902564-2-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2022-10-22 03:25:59 +00:00
..
2022-10-10 13:28:06 -07:00
2022-10-10 09:10:28 -07:00
2022-10-07 10:48:49 -07:00
2022-10-12 10:23:24 -07:00
2022-10-12 10:23:24 -07:00
2022-10-11 17:42:58 -06:00
2022-10-08 09:46:29 -07:00
2022-10-14 18:41:41 -07:00
2022-10-12 10:23:24 -07:00
2022-10-11 10:53:25 -07:00
2022-10-10 13:59:01 -07:00
2022-10-11 10:53:25 -07:00
2022-10-10 13:20:53 -07:00
2022-10-12 10:23:24 -07:00
2022-10-09 14:05:15 -07:00
2022-10-07 11:24:20 -07:00
2022-10-14 18:41:41 -07:00
2022-10-10 13:13:51 -07:00
2022-10-15 16:36:38 -07:00
2022-10-14 12:38:03 -07:00
2022-10-11 11:08:18 -07:00
2022-10-12 10:23:24 -07:00
2022-10-12 10:35:20 -07:00
2022-10-10 09:10:28 -07:00
2022-10-07 11:32:10 -07:00
2022-10-07 11:24:20 -07:00
2022-10-14 18:36:42 -07:00
2022-10-07 16:13:55 -07:00
2022-10-04 19:36:53 -07:00
2022-10-10 14:02:53 -07:00
2022-10-12 14:46:48 -07:00
2022-10-10 14:02:53 -07:00
2022-10-13 10:31:13 -07:00
2022-10-12 14:39:38 -07:00