Jozsef Kadlecsik 97f7cf1cd8 netfilter: ipset: fix performance regression in swap operation
The patch "netfilter: ipset: fix race condition between swap/destroy
and kernel side add/del/test", commit 28628fa9 fixes a race condition.
But the synchronize_rcu() added to the swap function unnecessarily slows
it down: it can safely be moved to destroy and use call_rcu() instead.

Eric Dumazet pointed out that simply calling the destroy functions as
rcu callback does not work: sets with timeout use garbage collectors
which need cancelling at destroy which can wait. Therefore the destroy
functions are split into two: cancelling garbage collectors safely at
executing the command received by netlink and moving the remaining
part only into the rcu callback.

Link: https://lore.kernel.org/lkml/C0829B10-EAA6-4809-874E-E1E9C05A8D84@automattic.com/
Fixes: 28628fa952fe ("netfilter: ipset: fix race condition between swap/destroy and kernel side add/del/test")
Reported-by: Ale Crismani <ale.crismani@automattic.com>
Reported-by: David Wang <00107082@163.com>
Tested-by: David Wang <00107082@163.com>
Signed-off-by: Jozsef Kadlecsik <kadlec@netfilter.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
2024-01-31 23:13:57 +01:00
..
2023-10-01 19:09:54 +01:00
2024-01-18 11:37:24 -08:00
2023-12-15 16:25:55 -08:00
2023-12-26 20:31:01 +00:00
2024-01-11 10:07:29 -08:00
2023-12-29 07:46:38 +00:00
2024-01-03 18:37:22 -08:00
2024-01-19 21:30:09 -08:00
2024-01-23 08:38:13 -08:00
2024-01-04 10:29:18 +00:00
2024-01-11 14:19:23 -08:00
2024-01-23 08:38:13 -08:00
2023-12-26 20:31:01 +00:00
2023-12-18 16:46:08 -08:00
2023-12-12 14:24:14 +01:00
2024-01-04 10:23:10 -08:00
2024-01-04 10:23:10 -08:00
2024-01-08 11:43:04 -08:00