Jamal Hadi Salim 1a29321ed0 net_sched: act: Dont increment refcnt on replace ...

This is a bug fix. The existing code tries to kill many
 birds with one stone: Handling binding of actions to
 filters, new actions and replacing of action
 attributes. A simple test case to illustrate:

XXXX
 moja@fe1:~$ sudo tc actions add action drop index 12
 moja@fe1:~$ actions get action gact index 12
 action order 1: gact action drop
  random type none pass val 0
  index 12 ref 1 bind 0
 moja@fe1:~$ sudo tc actions replace action ok index 12
 moja@fe1:~$ actions get action gact index 12
 action order 1: gact action drop
  random type none pass val 0
  index 12 ref 2 bind 0
XXXX

The above shows the refcounf being wrongly incremented on replace.
There are more complex scenarios with binding of actions to filters
that i am leaving out that didnt work as well...

Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

2013-12-27 12:50:00 -05:00

..

act_api.c

net_sched: Provide default walker function for actions

2013-12-05 19:28:42 -05:00

act_csum.c

net_sched: act: Dont increment refcnt on replace

2013-12-27 12:50:00 -05:00

act_gact.c

net_sched: act: Dont increment refcnt on replace

2013-12-27 12:50:00 -05:00

act_ipt.c

net_sched: act: Dont increment refcnt on replace

2013-12-27 12:50:00 -05:00

act_mirred.c

net_sched: Use default action walker methods

2013-12-05 19:28:43 -05:00

act_nat.c

net_sched: act: Dont increment refcnt on replace

2013-12-27 12:50:00 -05:00

act_pedit.c

net_sched: act: Dont increment refcnt on replace

2013-12-27 12:50:00 -05:00

act_police.c

net_sched: act: Dont increment refcnt on replace

2013-12-27 12:50:00 -05:00

act_simple.c

net_sched: act: Dont increment refcnt on replace

2013-12-27 12:50:00 -05:00

act_skbedit.c

net_sched: act: Dont increment refcnt on replace

2013-12-27 12:50:00 -05:00

cls_api.c

net_cls: remove duplicated include from cls_api.c

2013-04-07 17:12:01 -04:00

cls_basic.c

qdisc: basic classifier - remove unnecessary initialization

2013-09-30 15:47:43 -04:00

cls_bpf.c

net: sched: cls_bpf: add BPF-based classifier

2013-10-29 17:33:17 -04:00

cls_cgroup.c

cgroup: cls: remove unnecessary task_cls_classid

2013-10-08 16:27:34 -04:00

cls_flow.c

netlink: rename ssk to sk in struct netlink_skb_params

2013-04-19 14:57:56 -04:00

cls_fw.c

pkt_sched: fix error return code in fw_change_attrs()

2013-04-19 17:34:53 -04:00

cls_route.c

pkt_sched: namespace aware act_mirred

2013-01-14 15:09:36 -05:00

cls_rsvp6.c

…

cls_rsvp.c

…

cls_rsvp.h

pkt_sched: namespace aware act_mirred

2013-01-14 15:09:36 -05:00

cls_tcindex.c

pkt_sched: namespace aware act_mirred

2013-01-14 15:09:36 -05:00

cls_u32.c

pkt_sched: namespace aware act_mirred

2013-01-14 15:09:36 -05:00

em_canid.c

net: em_canid: Ematch rule to match CAN frames according to their identifiers

2012-07-04 13:07:05 +02:00

em_cmp.c

net_sched: cleanups

2011-01-19 23:31:12 -08:00

em_ipset.c

em_ipset: use dev_net() accessor

2013-10-18 16:23:06 -04:00

em_meta.c

qdisc: meta return ENOMEM on alloc failure

2013-09-30 15:47:43 -04:00

em_nbyte.c

net_sched: cleanups

2011-01-19 23:31:12 -08:00

em_text.c

net_sched: cleanups

2011-01-19 23:31:12 -08:00

em_u32.c

net_sched: cleanups

2011-01-19 23:31:12 -08:00

ematch.c

net: Convert net_ratelimit uses to net_<level>_ratelimited

2012-05-15 13:45:03 -04:00

Kconfig

net: sched: cls_bpf: add BPF-based classifier

2013-10-29 17:33:17 -04:00

Makefile

net: sched: cls_bpf: add BPF-based classifier

2013-10-29 17:33:17 -04:00

sch_api.c

net_sched: increment drop counters in qdisc_tree_decrease_qlen()

2013-10-08 16:27:33 -04:00

sch_atm.c

net_sched: info leak in atm_tc_dump_class()

2013-07-31 15:04:19 -07:00

sch_blackhole.c

pkt_sched: Add qdisc->ops->peek() implementation.

2008-10-31 00:45:55 -07:00

sch_cbq.c

net_sched: Fix stack info leak in cbq_dump_wrr().

2013-07-30 00:16:21 -07:00

sch_choke.c

treewide: Add __GFP_NOWARN to k.alloc calls with v.alloc fallbacks

2013-08-20 13:06:40 +02:00

sch_codel.c

fq_codel: should use qdisc backlog as threshold

2012-05-16 15:30:26 -04:00

sch_drr.c

net_sched: add 64bit rate estimators

2013-06-11 02:51:03 -07:00

sch_dsmark.c

net: sched: factorize code (qdisc_drop())

2012-05-04 11:50:05 -04:00

sch_fifo.c

pkt_sched: Stop using NLA_PUT*().

2012-04-01 18:11:37 -04:00

sch_fq_codel.c

net: fq_codel: Fix off-by-one error

2013-03-29 15:32:23 -04:00

sch_fq.c

pkt_sched: fq: fix pacing for small frames

2013-11-15 21:01:52 -05:00

sch_generic.c

net: Add layer 2 hardware acceleration operations for macvlan devices

2013-11-07 19:11:41 -05:00

sch_gred.c

net_sched: gred: actually perform idling in WRED mode

2012-09-13 16:10:13 -04:00

sch_hfsc.c

net_sched: add 64bit rate estimators

2013-06-11 02:51:03 -07:00

sch_htb.c

net: sched: htb: fix the calculation of quantum

2013-12-11 15:08:41 -05:00

sch_ingress.c

net_sched: factorize qdisc stats handling

2011-01-10 16:07:54 -08:00

sch_mq.c

qdisc: allow setting default queuing discipline

2013-08-31 00:32:32 -04:00

sch_mqprio.c

qdisc: allow setting default queuing discipline

2013-08-31 00:32:32 -04:00

sch_multiq.c

pkt_sched: Stop using NLA_PUT*().

2012-04-01 18:11:37 -04:00

sch_netem.c

netem: fix gemodel loss generator

2013-11-30 12:49:29 -05:00

sch_plug.c

net_sched: sch_plug: plug_qdisc_ops is static

2012-02-13 16:04:40 -05:00

sch_prio.c

pkt_sched: Stop using NLA_PUT*().

2012-04-01 18:11:37 -04:00

sch_qfq.c

pkt_sched: sch_qfq: remove a source of high packet delay/jitter

2013-07-18 13:02:00 -07:00

sch_red.c

pkt_sched: Stop using NLA_PUT*().

2012-04-01 18:11:37 -04:00

sch_sfb.c

sch_sfb: Fix missing NULL check

2012-07-12 08:33:18 -07:00

sch_sfq.c

pkt_sched: Stop using NLA_PUT*().

2012-04-01 18:11:37 -04:00

sch_tbf.c

sch_tbf: use do_div() for 64-bit divide

2013-12-11 22:53:26 -05:00

sch_teql.c

sch_teql: Convert over to dev_neigh_lookup_skb().

2012-07-05 01:09:06 -07:00