7d9f8468ff
Previously, there was a bug where if an extent had greater durability than required (because we needed to move a durability=1 pointer and ended up putting it on a durability 2 device), we would submit a write for replicas=2 - the durability of the pointer being rewritten - instead of the number of replicas required to bring it back up to the data_replicas option. This, plus the allocation path sometimes allocating on a greater durability device than requested, meant that extents could continue having more and more replicas added as they were being rewritten. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
50 lines
1.2 KiB
C
50 lines
1.2 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
|
|
#ifndef _BCACHEFS_DATA_UPDATE_H
|
|
#define _BCACHEFS_DATA_UPDATE_H
|
|
|
|
#include "bkey_buf.h"
|
|
#include "io_write_types.h"
|
|
|
|
struct moving_context;
|
|
|
|
struct data_update_opts {
|
|
unsigned rewrite_ptrs;
|
|
unsigned kill_ptrs;
|
|
u16 target;
|
|
u8 extra_replicas;
|
|
unsigned btree_insert_flags;
|
|
unsigned write_flags;
|
|
};
|
|
|
|
struct data_update {
|
|
/* extent being updated: */
|
|
enum btree_id btree_id;
|
|
struct bkey_buf k;
|
|
struct data_update_opts data_opts;
|
|
struct moving_context *ctxt;
|
|
struct bch_move_stats *stats;
|
|
struct bch_write_op op;
|
|
};
|
|
|
|
int bch2_data_update_index_update(struct bch_write_op *);
|
|
|
|
void bch2_data_update_read_done(struct data_update *,
|
|
struct bch_extent_crc_unpacked);
|
|
|
|
int bch2_extent_drop_ptrs(struct btree_trans *,
|
|
struct btree_iter *,
|
|
struct bkey_s_c,
|
|
struct data_update_opts);
|
|
|
|
void bch2_data_update_exit(struct data_update *);
|
|
int bch2_data_update_init(struct btree_trans *, struct btree_iter *,
|
|
struct moving_context *,
|
|
struct data_update *,
|
|
struct write_point_specifier,
|
|
struct bch_io_opts, struct data_update_opts,
|
|
enum btree_id, struct bkey_s_c);
|
|
void bch2_data_update_opts_normalize(struct bkey_s_c, struct data_update_opts *);
|
|
|
|
#endif /* _BCACHEFS_DATA_UPDATE_H */
|