Eric Dumazet
99dc568545
tcp: add annotations around sk->sk_shutdown accesses ...
[ Upstream commit e14cadfd80d76f01bfaa1a8d745b1db19b57d6be ]
Now sk->sk_shutdown is no longer a bitfield, we can add
standard READ_ONCE()/WRITE_ONCE() annotations to silence
KCSAN reports like the following:
BUG: KCSAN: data-race in tcp_disconnect / tcp_poll
write to 0xffff88814588582c of 1 bytes by task 3404 on cpu 1:
tcp_disconnect+0x4d6/0xdb0 net/ipv4/tcp.c:3121
__inet_stream_connect+0x5dd/0x6e0 net/ipv4/af_inet.c:715
inet_stream_connect+0x48/0x70 net/ipv4/af_inet.c:727
__sys_connect_file net/socket.c:2001 [inline]
__sys_connect+0x19b/0x1b0 net/socket.c:2018
__do_sys_connect net/socket.c:2028 [inline]
__se_sys_connect net/socket.c:2025 [inline]
__x64_sys_connect+0x41/0x50 net/socket.c:2025
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
read to 0xffff88814588582c of 1 bytes by task 3374 on cpu 0:
tcp_poll+0x2e6/0x7d0 net/ipv4/tcp.c:562
sock_poll+0x253/0x270 net/socket.c:1383
vfs_poll include/linux/poll.h:88 [inline]
io_poll_check_events io_uring/poll.c:281 [inline]
io_poll_task_func+0x15a/0x820 io_uring/poll.c:333
handle_tw_list io_uring/io_uring.c:1184 [inline]
tctx_task_work+0x1fe/0x4d0 io_uring/io_uring.c:1246
task_work_run+0x123/0x160 kernel/task_work.c:179
get_signal+0xe64/0xff0 kernel/signal.c:2635
arch_do_signal_or_restart+0x89/0x2a0 arch/x86/kernel/signal.c:306
exit_to_user_mode_loop+0x6f/0xe0 kernel/entry/common.c:168
exit_to_user_mode_prepare+0x6c/0xb0 kernel/entry/common.c:204
__syscall_exit_to_user_mode_work kernel/entry/common.c:286 [inline]
syscall_exit_to_user_mode+0x26/0x140 kernel/entry/common.c:297
do_syscall_64+0x4d/0xc0 arch/x86/entry/common.c:86
entry_SYSCALL_64_after_hwframe+0x63/0xcd
value changed: 0x03 -> 0x00
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-03-01 13:13:34 +01:00
2021-09-15 09:47:31 +02:00
2024-01-08 11:29:47 +01:00
2023-01-18 11:41:37 +01:00
2024-02-23 08:24:50 +01:00
2023-12-20 15:41:18 +01:00
2023-12-20 15:41:15 +01:00
2022-04-20 09:19:40 +02:00
2023-08-30 16:27:25 +02:00
2024-01-25 14:34:26 -08:00
2023-01-18 11:41:04 +01:00
2021-07-14 16:53:33 +02:00
2023-11-28 16:50:17 +00:00
2023-03-17 08:32:51 +01:00
2024-02-23 08:25:13 +01:00
2023-10-25 11:53:19 +02:00
2024-02-23 08:25:14 +01:00
2023-08-11 11:53:57 +02:00
2023-11-20 10:30:15 +01:00
2023-06-21 15:44:10 +02:00
2020-04-23 10:36:45 +02:00
2023-07-27 08:37:24 +02:00
2023-01-18 11:41:09 +01:00
2022-11-03 23:56:54 +09:00
2024-01-08 11:29:44 +01:00
2024-03-01 13:13:34 +01:00
2024-02-23 08:25:04 +01:00
2024-02-23 08:25:07 +01:00
2023-09-23 11:00:02 +02:00
2023-08-30 16:27:16 +02:00
2023-10-10 21:46:44 +02:00
2022-04-27 13:50:47 +02:00
2021-02-10 09:25:28 +01:00
2024-02-23 08:25:04 +01:00
2024-03-01 13:13:33 +01:00
2022-12-14 11:30:45 +01:00
2023-02-22 12:50:41 +01:00
2024-01-25 14:34:25 -08:00
2024-03-01 13:13:34 +01:00
2024-01-25 14:34:23 -08:00
2024-02-23 08:24:50 +01:00
2023-09-23 10:59:43 +02:00
2024-02-23 08:25:11 +01:00
2023-05-30 12:44:05 +01:00
2023-02-22 12:50:25 +01:00
2023-12-13 18:18:14 +01:00
2022-01-11 15:23:33 +01:00
2023-12-13 18:18:17 +01:00
2021-09-03 10:08:12 +02:00
2024-02-23 08:24:50 +01:00
2024-01-08 11:29:47 +01:00
2024-01-08 11:29:44 +01:00
2024-02-23 08:25:07 +01:00
2024-03-01 13:13:32 +01:00
2023-10-10 21:46:45 +02:00
2024-02-23 08:24:50 +01:00
2021-11-17 09:48:48 +01:00
2024-02-23 08:24:56 +01:00
2021-10-27 09:54:24 +02:00
2024-02-23 08:25:07 +01:00
2024-01-15 18:25:29 +01:00
2024-02-23 08:25:05 +01:00
2024-01-25 14:34:25 -08:00
2024-03-01 13:13:33 +01:00
2023-02-22 12:50:26 +01:00
2023-07-27 08:37:23 +02:00
2023-10-25 11:53:21 +02:00
2021-06-18 09:59:00 +02:00
2023-06-21 15:44:10 +02:00
2023-06-21 15:44:10 +02:00
2024-01-15 18:25:26 +01:00
99dc568545