Emmanuel Grumbach 9ad08fb1bc wifi: mac80211: fix a expired vs. cancel race in roc
When the remain on channel is removed at the time it should
have expired, we have a race: the driver could be handling
the flow of the expiration while mac80211 is cancelling
that very same remain on channel request.

This wouldn't be problem in itself, but since mac80211
can send the next request to the driver in the cancellation
flow, we can get to the following situation:

           CPU0                             CPU1
expiration of roc in driver
ieee80211_remain_on_channel_expired()
                                         Cancellation of the roc
schedules a worker (hw_roc_done)
                                         Add next roc
hw_roc_done_wk runs and ends
the second roc prematurely.

Since, by design, there is only one single request sent to the
driver at a time, we can safely assume that after the cancel()
request returns from the driver, we should not handle any worker
that handles the expiration of the request.

Cancel the hw_roc_done worker after the cancellation to make
sure we start the next one with a clean slate.

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230928172905.4e4469be20ac.Iab0525f5cc4698acf23eab98b8b1eec02099cde0@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2023-10-23 11:45:17 +02:00
..
2023-09-11 11:27:22 +02:00
2023-09-11 11:27:22 +02:00
2023-09-11 11:27:22 +02:00
2023-09-11 11:27:22 +02:00
2023-09-11 11:27:22 +02:00
2023-10-06 17:08:47 +03:00
2023-10-06 17:08:47 +03:00
2023-09-11 11:27:22 +02:00
2023-10-23 11:43:28 +02:00
2023-09-11 11:27:22 +02:00
2023-09-11 11:27:22 +02:00
2023-10-06 17:08:47 +03:00
2023-09-26 09:16:42 +02:00
2023-09-26 09:16:42 +02:00