da2c8fef13
Grab nfsd_mutex lock in nfsd_nl_rpc_status_get_dumpit routine and remove
nfsd_nl_rpc_status_get_start() and nfsd_nl_rpc_status_get_done(). This
patch fix the syzbot log reported below:
INFO: task syz-executor.1:17770 blocked for more than 143 seconds.
Not tainted 6.10.0-rc3-syzkaller-00022-gcea2a26553ac #0
"echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
task:syz-executor.1 state:D stack:23800 pid:17770 tgid:17767 ppid:11381 flags:0x00000006
Call Trace:
<TASK>
context_switch kernel/sched/core.c:5408 [inline]
__schedule+0x17e8/0x4a20 kernel/sched/core.c:6745
__schedule_loop kernel/sched/core.c:6822 [inline]
schedule+0x14b/0x320 kernel/sched/core.c:6837
schedule_preempt_disabled+0x13/0x30 kernel/sched/core.c:6894
__mutex_lock_common kernel/locking/mutex.c:684 [inline]
__mutex_lock+0x6a4/0xd70 kernel/locking/mutex.c:752
nfsd_nl_listener_get_doit+0x115/0x5d0 fs/nfsd/nfsctl.c:2124
genl_family_rcv_msg_doit net/netlink/genetlink.c:1115 [inline]
genl_family_rcv_msg net/netlink/genetlink.c:1195 [inline]
genl_rcv_msg+0xb16/0xec0 net/netlink/genetlink.c:1210
netlink_rcv_skb+0x1e5/0x430 net/netlink/af_netlink.c:2564
genl_rcv+0x28/0x40 net/netlink/genetlink.c:1219
netlink_unicast_kernel net/netlink/af_netlink.c:1335 [inline]
netlink_unicast+0x7ec/0x980 net/netlink/af_netlink.c:1361
netlink_sendmsg+0x8db/0xcb0 net/netlink/af_netlink.c:1905
sock_sendmsg_nosec net/socket.c:730 [inline]
__sock_sendmsg+0x223/0x270 net/socket.c:745
____sys_sendmsg+0x525/0x7d0 net/socket.c:2585
___sys_sendmsg net/socket.c:2639 [inline]
__sys_sendmsg+0x2b0/0x3a0 net/socket.c:2668
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f24ed27cea9
RSP: 002b:00007f24ee0080c8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007f24ed3b3f80 RCX: 00007f24ed27cea9
RDX: 0000000000000000 RSI: 0000000020000100 RDI: 0000000000000005
RBP: 00007f24ed2ebff4 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
Fixes: 1bd773b4f0c9 ("nfsd: hold nfsd_mutex across entire netlink operation")
Fixes: bd9d6a3efa97 ("NFSD: add rpc_status netlink support")
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
198 lines
3.7 KiB
YAML
198 lines
3.7 KiB
YAML
# SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause)
|
|
|
|
name: nfsd
|
|
protocol: genetlink
|
|
uapi-header: linux/nfsd_netlink.h
|
|
|
|
doc: NFSD configuration over generic netlink.
|
|
|
|
attribute-sets:
|
|
-
|
|
name: rpc-status
|
|
attributes:
|
|
-
|
|
name: xid
|
|
type: u32
|
|
byte-order: big-endian
|
|
-
|
|
name: flags
|
|
type: u32
|
|
-
|
|
name: prog
|
|
type: u32
|
|
-
|
|
name: version
|
|
type: u8
|
|
-
|
|
name: proc
|
|
type: u32
|
|
-
|
|
name: service_time
|
|
type: s64
|
|
-
|
|
name: pad
|
|
type: pad
|
|
-
|
|
name: saddr4
|
|
type: u32
|
|
byte-order: big-endian
|
|
display-hint: ipv4
|
|
-
|
|
name: daddr4
|
|
type: u32
|
|
byte-order: big-endian
|
|
display-hint: ipv4
|
|
-
|
|
name: saddr6
|
|
type: binary
|
|
display-hint: ipv6
|
|
-
|
|
name: daddr6
|
|
type: binary
|
|
display-hint: ipv6
|
|
-
|
|
name: sport
|
|
type: u16
|
|
byte-order: big-endian
|
|
-
|
|
name: dport
|
|
type: u16
|
|
byte-order: big-endian
|
|
-
|
|
name: compound-ops
|
|
type: u32
|
|
multi-attr: true
|
|
-
|
|
name: server
|
|
attributes:
|
|
-
|
|
name: threads
|
|
type: u32
|
|
multi-attr: true
|
|
-
|
|
name: gracetime
|
|
type: u32
|
|
-
|
|
name: leasetime
|
|
type: u32
|
|
-
|
|
name: scope
|
|
type: string
|
|
-
|
|
name: version
|
|
attributes:
|
|
-
|
|
name: major
|
|
type: u32
|
|
-
|
|
name: minor
|
|
type: u32
|
|
-
|
|
name: enabled
|
|
type: flag
|
|
-
|
|
name: server-proto
|
|
attributes:
|
|
-
|
|
name: version
|
|
type: nest
|
|
nested-attributes: version
|
|
multi-attr: true
|
|
-
|
|
name: sock
|
|
attributes:
|
|
-
|
|
name: addr
|
|
type: binary
|
|
-
|
|
name: transport-name
|
|
type: string
|
|
-
|
|
name: server-sock
|
|
attributes:
|
|
-
|
|
name: addr
|
|
type: nest
|
|
nested-attributes: sock
|
|
multi-attr: true
|
|
|
|
operations:
|
|
list:
|
|
-
|
|
name: rpc-status-get
|
|
doc: dump pending nfsd rpc
|
|
attribute-set: rpc-status
|
|
dump:
|
|
reply:
|
|
attributes:
|
|
- xid
|
|
- flags
|
|
- prog
|
|
- version
|
|
- proc
|
|
- service_time
|
|
- saddr4
|
|
- daddr4
|
|
- saddr6
|
|
- daddr6
|
|
- sport
|
|
- dport
|
|
- compound-ops
|
|
-
|
|
name: threads-set
|
|
doc: set the number of running threads
|
|
attribute-set: server
|
|
flags: [ admin-perm ]
|
|
do:
|
|
request:
|
|
attributes:
|
|
- threads
|
|
- gracetime
|
|
- leasetime
|
|
- scope
|
|
-
|
|
name: threads-get
|
|
doc: get the number of running threads
|
|
attribute-set: server
|
|
do:
|
|
reply:
|
|
attributes:
|
|
- threads
|
|
- gracetime
|
|
- leasetime
|
|
- scope
|
|
-
|
|
name: version-set
|
|
doc: set nfs enabled versions
|
|
attribute-set: server-proto
|
|
flags: [ admin-perm ]
|
|
do:
|
|
request:
|
|
attributes:
|
|
- version
|
|
-
|
|
name: version-get
|
|
doc: get nfs enabled versions
|
|
attribute-set: server-proto
|
|
do:
|
|
reply:
|
|
attributes:
|
|
- version
|
|
-
|
|
name: listener-set
|
|
doc: set nfs running sockets
|
|
attribute-set: server-sock
|
|
flags: [ admin-perm ]
|
|
do:
|
|
request:
|
|
attributes:
|
|
- addr
|
|
-
|
|
name: listener-get
|
|
doc: get nfs running listeners
|
|
attribute-set: server-sock
|
|
do:
|
|
reply:
|
|
attributes:
|
|
- addr
|