Files
linux/drivers/scsi
Yang Yingliang 9d0ad1e2ba scsi: fcoe: Fix possible name leak when device_register() fails
[ Upstream commit 47b6a122c7 ]

If device_register() returns an error, the name allocated by dev_set_name()
needs to be freed. As the comment of device_register() says, one should use
put_device() to give up the reference in the error path. Fix this by
calling put_device(), then the name can be freed in kobject_cleanup().

The 'fcf' is freed in fcoe_fcf_device_release(), so the kfree() in the
error path can be removed.

The 'ctlr' is freed in fcoe_ctlr_device_release(), so don't use the error
label, just return NULL after calling put_device().

Fixes: 9a74e884ee ("[SCSI] libfcoe: Add fcoe_sysfs")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221112094310.3633291-1-yangyingliang@huawei.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-01-14 10:15:51 +01:00
..
2020-03-11 23:07:59 -04:00
2019-11-12 22:21:35 -05:00
2020-02-24 14:54:25 -05:00
2020-03-11 23:07:59 -04:00
2020-10-07 21:48:28 -04:00
2020-09-02 22:49:06 -04:00
2020-09-02 22:49:06 -04:00
2020-08-23 17:36:59 -05:00
2021-05-14 09:50:27 +02:00
2020-07-24 22:09:55 -04:00
2022-02-16 12:54:20 +01:00
2020-09-15 17:34:18 -04:00
2020-08-23 17:36:59 -05:00
2021-05-14 09:50:27 +02:00
2022-01-27 10:54:23 +01:00
2022-01-27 10:54:23 +01:00
2020-02-24 15:01:57 -05:00
2021-05-14 09:50:27 +02:00