linux

iv/linux

History

Nathan Chancellor 37209783c7 thunderbolt: Make priority unsigned in struct tb_path

Clang warns:

drivers/thunderbolt/tunnel.c:504:17: warning: implicit truncation from
'int' to bit-field changes value from 5 to -3
[-Wbitfield-constant-conversion]
        path->priority = 5;
                       ^ ~
1 warning generated.

The priority member in struct tb_path is only ever assigned a positive
number:

$ rg -n priority drivers/thunderbolt/path.c
drivers/thunderbolt/tunnel.c:99:        path->priority = 3;
drivers/thunderbolt/tunnel.c:308:       path->priority = 2;
drivers/thunderbolt/tunnel.c:323:       path->priority = 1;
drivers/thunderbolt/tunnel.c:504:       path->priority = 5;

Furthermore, that value is only assigned to an unsigned integer in
tb_path_activate (the priority member in struct tb_regs_hop).

Fixes: 44242d6c9703 ("thunderbolt: Add support for DMA tunnels")
Link: https://github.com/ClangBuiltLinux/linux/issues/454
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>

2019-04-25 12:18:27 +03:00

cap.c

thunderbolt: Add dummy read after port capability list walk on Light Ridge

2019-04-18 11:18:51 +03:00

ctl.c

thunderbolt: Make rest of the logging to happen at debug level

2019-04-18 11:18:53 +03:00

ctl.h

thunderbolt: Add Intel as copyright holder

2018-10-02 15:52:08 -07:00

dma_port.c

thunderbolt: Convert rest of the driver files to use SPDX identifier