iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/core
History
Yang Yingliang 814152a89e net: fix memleak in register_netdevice() 
I got a memleak report when doing some fuzz test:

unreferenced object 0xffff888112584000 (size 13599):
  comm "ip", pid 3048, jiffies 4294911734 (age 343.491s)
  hex dump (first 32 bytes):
    74 61 70 30 00 00 00 00 00 00 00 00 00 00 00 00  tap0............
    00 ee d9 19 81 88 ff ff 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<000000002f60ba65>] __kmalloc_node+0x309/0x3a0
    [<0000000075b211ec>] kvmalloc_node+0x7f/0xc0
    [<00000000d3a97396>] alloc_netdev_mqs+0x76/0xfc0
    [<00000000609c3655>] __tun_chr_ioctl+0x1456/0x3d70
    [<000000001127ca24>] ksys_ioctl+0xe5/0x130
    [<00000000b7d5e66a>] __x64_sys_ioctl+0x6f/0xb0
    [<00000000e1023498>] do_syscall_64+0x56/0xa0
    [<000000009ec0eb12>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
unreferenced object 0xffff888111845cc0 (size 8):
  comm "ip", pid 3048, jiffies 4294911734 (age 343.491s)
  hex dump (first 8 bytes):
    74 61 70 30 00 88 ff ff                          tap0....
  backtrace:
    [<000000004c159777>] kstrdup+0x35/0x70
    [<00000000d8b496ad>] kstrdup_const+0x3d/0x50
    [<00000000494e884a>] kvasprintf_const+0xf1/0x180
    [<0000000097880a2b>] kobject_set_name_vargs+0x56/0x140
    [<000000008fbdfc7b>] dev_set_name+0xab/0xe0
    [<000000005b99e3b4>] netdev_register_kobject+0xc0/0x390
    [<00000000602704fe>] register_netdevice+0xb61/0x1250
    [<000000002b7ca244>] __tun_chr_ioctl+0x1cd1/0x3d70
    [<000000001127ca24>] ksys_ioctl+0xe5/0x130
    [<00000000b7d5e66a>] __x64_sys_ioctl+0x6f/0xb0
    [<00000000e1023498>] do_syscall_64+0x56/0xa0
    [<000000009ec0eb12>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
unreferenced object 0xffff88811886d800 (size 512):
  comm "ip", pid 3048, jiffies 4294911734 (age 343.491s)
  hex dump (first 32 bytes):
    00 00 00 00 ad 4e ad de ff ff ff ff 00 00 00 00  .....N..........
    ff ff ff ff ff ff ff ff c0 66 3d a3 ff ff ff ff  .........f=.....
  backtrace:
    [<0000000050315800>] device_add+0x61e/0x1950
    [<0000000021008dfb>] netdev_register_kobject+0x17e/0x390
    [<00000000602704fe>] register_netdevice+0xb61/0x1250
    [<000000002b7ca244>] __tun_chr_ioctl+0x1cd1/0x3d70
    [<000000001127ca24>] ksys_ioctl+0xe5/0x130
    [<00000000b7d5e66a>] __x64_sys_ioctl+0x6f/0xb0
    [<00000000e1023498>] do_syscall_64+0x56/0xa0
    [<000000009ec0eb12>] entry_SYSCALL_64_after_hwframe+0x44/0xa9

If call_netdevice_notifiers() failed, then rollback_registered()
calls netdev_unregister_kobject() which holds the kobject. The
reference cannot be put because the netdev won't be add to todo
list, so it will leads a memleak, we need put the reference to
avoid memleak.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2020-06-18 20:05:54 -07:00
..
bpf_sk_storage.c
bpf: Implement CAP_BPF
2020-05-15 17:29:41 +02:00
datagram.c
net: use indirect call wrappers for skb_copy_datagram_iter()
2020-03-25 11:30:40 -07:00
datagram.h
net/core: Allow the compiler to verify declaration and definition consistency
2019-03-27 13:49:44 -07:00
dev_addr_lists.c
net: change addr_list_lock back to static key
2020-06-09 12:59:45 -07:00
dev_ioctl.c
ethtool: add timestamping related string sets
2020-03-29 22:32:36 -07:00
dev.c
net: fix memleak in register_netdevice()
2020-06-18 20:05:54 -07:00
devlink.c
devlink: Add ACL control packet traps
2020-06-01 11:49:23 -07:00
drop_monitor.c
drop_monitor: work around gcc-10 stringop-overflow warning
2020-05-01 15:45:16 -07:00
dst_cache.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
dst.c
net/dst: use a smaller percpu_counter batch for dst entries accounting
2020-05-08 21:33:33 -07:00
failover.c
failover: allow name change on IFF_UP slave interfaces
2019-04-10 22:12:26 -07:00
fib_notifier.c
net: fib_notifier: propagate extack down to the notifier block callback
2019-10-04 11:10:56 -07:00
fib_rules.c
net: fib_rules: Correctly set table field when table number exceeds 8 bits
2020-02-16 18:38:24 -08:00
filter.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf
2020-06-13 15:28:08 -07:00
flow_dissector.c
flow_dissector: Move out netns_bpf prog callbacks
2020-06-01 15:21:02 -07:00
flow_offload.c
net: remove indirect block netdev event registration
2020-06-01 11:41:50 -07:00
gen_estimator.c
net_sched: gen_estimator: extend packet counter to 64bit
2019-11-06 21:51:36 -08:00
gen_stats.c
docs: networking: convert gen_stats.txt to ReST
2020-04-28 14:39:46 -07:00
gro_cells.c
gro_cells: make sure device is up in gro_cells_receive()
2019-03-10 11:07:14 -07:00
hwbm.c
net: hwbm: Make the hwbm_pool lock a mutex
2019-06-09 19:40:10 -07:00
link_watch.c
net: Add IF_OPER_TESTING
2020-04-20 12:43:24 -07:00
lwt_bpf.c
net: add net available in build_state
2020-03-29 22:30:57 -07:00
lwtunnel.c
net: ipv6: add rpl sr tunnel
2020-03-29 22:30:57 -07:00
Makefile
ethtool: move to its own directory
2019-12-12 17:07:05 -08:00
neighbour.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-05-31 17:48:46 -07:00
net_namespace.c
nsproxy: add struct nsset
2020-05-09 13:57:12 +02:00
net-procfs.c
net: procfs: use index hashlist instead of name hashlist
2019-10-01 14:47:19 -07:00
net-sysfs.c
net: core: recursively find netdev by device node
2020-05-15 10:18:49 -07:00
net-sysfs.h
net-sysfs: add netdev_change_owner()
2020-02-26 20:07:25 -08:00
net-traces.c
page_pool: add tracepoints for page_pool with details need by XDP
2019-06-19 11:23:13 -04:00
netclassid_cgroup.c
cgroup, netclassid: remove double cond_resched
2020-04-21 15:44:30 -07:00
netevent.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
netpoll.c
netpoll: accept NULL np argument in netpoll_send_skb()
2020-05-07 18:11:07 -07:00
netprio_cgroup.c
netprio_cgroup: Fix unlimited memory leak of v2 cgroups
2020-05-09 20:59:21 -07:00
page_pool.c
net: page pool: allow to pass zero flags to page_pool_init()
2020-03-29 21:49:20 -07:00
pktgen.c
docs: networking: convert pktgen.txt to ReST
2020-04-30 12:56:37 -07:00
ptp_classifier.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 295
2019-06-05 17:36:38 +02:00
request_sock.c
tcp: add rcu protection around tp->fastopen_rsk
2019-10-13 10:13:08 -07:00
rtnetlink.c
net: change addr_list_lock back to static key
2020-06-09 12:59:45 -07:00
scm.c
net: ignore sock_from_file errors in __scm_install_fd
2020-05-13 12:30:54 -07:00
secure_seq.c
crypto: lib/sha1 - remove unnecessary includes of linux/cryptohash.h
2020-05-08 15:32:17 +10:00
skbuff.c
net: unexport skb_gro_receive()
2020-05-19 19:55:36 -07:00
skmsg.c
bpf: Fix running sk_skb program types with ktls
2020-06-01 14:48:32 -07:00
sock_diag.c
sock: make cookie generation global instead of per netns
2019-08-09 13:14:46 -07:00
sock_map.c
bpf: Fix memlock accounting for sock_hash
2020-06-12 15:21:29 -07:00
sock_reuseport.c
net: Generate reuseport group ID on group creation
2020-02-21 22:29:45 +01:00
sock.c
net: Make locking in sock_bindtoindex optional
2020-06-01 14:57:14 -07:00
stream.c
tcp: make sure EPOLLOUT wont be missed
2019-08-19 13:07:43 -07:00
sysctl_net_core.c
Merge branch 'work.sysctl' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2020-06-10 16:05:54 -07:00
timestamping.c
net: Introduce a new MII time stamping interface.
2019-12-25 19:51:33 -08:00
tso.c
net: Use skb accessors in network core
2019-07-22 20:47:56 -07:00
utils.c
net: Fix skb->csum update in inet_proto_csum_replace16().
2020-01-24 20:54:30 +01:00
xdp.c
xdp: Handle frame_sz in xdp_convert_zc_to_xdp_frame()
2020-06-17 09:58:15 -07:00