Daniel Borkmann 32b2f4b196 sched: cls_flow: fix panic on filter replace
The following test case causes a NULL pointer dereference in cls_flow:

  tc filter add dev foo parent 1: handle 0x1 flow hash keys dst action ok
  tc filter replace dev foo parent 1: pref 49152 handle 0x1 \
            flow hash keys mark action drop

To be more precise, actually two different panics are fixed, the first
occurs because tcf_exts_init() is not called on the newly allocated
filter when we do a replace. And the second panic uncovered after that
happens since the arguments of list_replace_rcu() are swapped, the old
element needs to be the first argument and the new element the second.

Fixes: 70da9f0bf999 ("net: sched: cls_flow use RCU")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: John Fastabend <john.r.fastabend@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2015-07-21 00:25:03 -07:00
..
2015-05-02 22:25:17 -04:00
2015-07-15 21:36:35 -07:00
2015-05-02 22:25:17 -04:00
2014-11-21 14:20:18 -05:00
2011-01-19 23:31:12 -08:00
2015-06-18 21:14:28 +02:00
2011-01-19 23:31:12 -08:00
2015-05-13 15:19:48 -04:00
2014-09-30 01:02:26 -04:00
2014-09-30 01:02:26 -04:00
2014-09-30 01:02:26 -04:00
2014-09-30 01:02:26 -04:00
2014-09-30 01:02:26 -04:00
2014-09-30 01:02:26 -04:00
2014-09-30 01:02:26 -04:00
2014-09-30 01:02:26 -04:00
2014-09-30 01:02:26 -04:00