Tejun Heo 9f8a2c23c6 scsi: replace sr_test_unit_ready() with scsi_test_unit_ready()
The usage of TUR has been confusing involving several different
commits updating different parts over time.  Currently, the only
differences between scsi_test_unit_ready() and sr_test_unit_ready()
are,

* scsi_test_unit_ready() also sets sdev->changed on NOT_READY.

* scsi_test_unit_ready() returns 0 if TUR ended with UNIT_ATTENTION or
  NOT_READY.

Due to the above two differences, sr is using its own
sr_test_unit_ready(), but sd - the sole user of the above extra
handling - doesn't even need them.

Where scsi_test_unit_ready() is used in sd_media_changed(), the code
is looking for device ready w/ media present state which is true iff
TUR succeeds w/o sense data or UA, and when the device is not ready
for whatever reason sd_media_changed() explicitly marks media as
missing so there's no reason to set sdev->changed automatically from
scsi_test_unit_ready() on NOT_READY.

Drop both special handlings from scsi_test_unit_ready(), which makes
it equivalant to sr_test_unit_ready(), and replace
sr_test_unit_ready() with scsi_test_unit_ready().  Also, drop the
unnecessary explicit NOT_READY check from sd_media_changed().
Checking return value is enough for testing device readiness.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
2010-12-16 17:53:39 +01:00
..
2010-10-25 16:28:09 -05:00
2010-10-26 10:42:35 -05:00
2008-08-29 02:13:10 -07:00
2010-10-25 15:01:14 -05:00
2010-07-27 12:02:00 -05:00
2010-01-18 10:48:08 -06:00
2008-12-28 20:00:03 +01:00
2010-05-02 15:55:03 -04:00
2008-01-30 13:14:02 -06:00
2008-01-30 13:14:02 -06:00
2010-11-10 14:54:09 +01:00
2010-08-11 00:55:42 -04:00
2010-09-16 11:48:48 -04:00
2009-12-10 08:54:13 -06:00