ed5c2f5fd1
The value returned by an i2c driver's remove function is mostly ignored. (Only an error message is printed if the value is non-zero that the error is ignored.) So change the prototype of the remove function to return no value. This way driver authors are not tempted to assume that passing an error to the upper layer is a good idea. All drivers are adapted accordingly. There is no intended change of behaviour, all callbacks were prepared to return 0 before. Reviewed-by: Peter Senna Tschudin <peter.senna@gmail.com> Reviewed-by: Jeremy Kerr <jk@codeconstruct.com.au> Reviewed-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Reviewed-by: Crt Mori <cmo@melexis.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by: Marek Behún <kabel@kernel.org> # for leds-turris-omnia Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Petr Machata <petrm@nvidia.com> # for mlxsw Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> # for surface3_power Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> # for bmc150-accel-i2c + kxcjk-1013 Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> # for media/* + staging/media/* Acked-by: Miguel Ojeda <ojeda@kernel.org> # for auxdisplay/ht16k33 + auxdisplay/lcd2s Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> # for versaclock5 Reviewed-by: Ajay Gupta <ajayg@nvidia.com> # for ucsi_ccg Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> # for iio Acked-by: Peter Rosin <peda@axentia.se> # for i2c-mux-*, max9860 Acked-by: Adrien Grassein <adrien.grassein@gmail.com> # for lontium-lt8912b Reviewed-by: Jean Delvare <jdelvare@suse.de> # for hwmon, i2c-core and i2c/muxes Acked-by: Corey Minyard <cminyard@mvista.com> # for IPMI Reviewed-by: Vladimir Oltean <olteanv@gmail.com> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com> # for drivers/power Acked-by: Krzysztof Hałasa <khalasa@piap.pl> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Wolfram Sang <wsa@kernel.org>
80 lines
1.8 KiB
C
80 lines
1.8 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* TSC2004 touchscreen driver
|
|
*
|
|
* Copyright (C) 2015 QWERTY Embedded Design
|
|
* Copyright (C) 2015 EMAC Inc.
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/input.h>
|
|
#include <linux/of.h>
|
|
#include <linux/i2c.h>
|
|
#include <linux/regmap.h>
|
|
#include "tsc200x-core.h"
|
|
|
|
static const struct input_id tsc2004_input_id = {
|
|
.bustype = BUS_I2C,
|
|
.product = 2004,
|
|
};
|
|
|
|
static int tsc2004_cmd(struct device *dev, u8 cmd)
|
|
{
|
|
u8 tx = TSC200X_CMD | TSC200X_CMD_12BIT | cmd;
|
|
s32 data;
|
|
struct i2c_client *i2c = to_i2c_client(dev);
|
|
|
|
data = i2c_smbus_write_byte(i2c, tx);
|
|
if (data < 0) {
|
|
dev_err(dev, "%s: failed, command: %x i2c error: %d\n",
|
|
__func__, cmd, data);
|
|
return data;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int tsc2004_probe(struct i2c_client *i2c,
|
|
const struct i2c_device_id *id)
|
|
|
|
{
|
|
return tsc200x_probe(&i2c->dev, i2c->irq, &tsc2004_input_id,
|
|
devm_regmap_init_i2c(i2c, &tsc200x_regmap_config),
|
|
tsc2004_cmd);
|
|
}
|
|
|
|
static void tsc2004_remove(struct i2c_client *i2c)
|
|
{
|
|
tsc200x_remove(&i2c->dev);
|
|
}
|
|
|
|
static const struct i2c_device_id tsc2004_idtable[] = {
|
|
{ "tsc2004", 0 },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(i2c, tsc2004_idtable);
|
|
|
|
#ifdef CONFIG_OF
|
|
static const struct of_device_id tsc2004_of_match[] = {
|
|
{ .compatible = "ti,tsc2004" },
|
|
{ /* sentinel */ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, tsc2004_of_match);
|
|
#endif
|
|
|
|
static struct i2c_driver tsc2004_driver = {
|
|
.driver = {
|
|
.name = "tsc2004",
|
|
.of_match_table = of_match_ptr(tsc2004_of_match),
|
|
.pm = &tsc200x_pm_ops,
|
|
},
|
|
.id_table = tsc2004_idtable,
|
|
.probe = tsc2004_probe,
|
|
.remove = tsc2004_remove,
|
|
};
|
|
module_i2c_driver(tsc2004_driver);
|
|
|
|
MODULE_AUTHOR("Michael Welling <mwelling@ieee.org>");
|
|
MODULE_DESCRIPTION("TSC2004 Touchscreen Driver");
|
|
MODULE_LICENSE("GPL");
|