Dan Carpenter 0448d38c1e usb: gadget: f_hid: fix error handling in ghid_setup() ...

There were a two issues here.

1) We returned PTR_ERR(NULL) which means success if class_create()
   failed.
2) If alloc_chrdev_region() failed then we should clean up before
   returning.

Also kernel style is to have "error handling" as opposed to "success
handling".  In the original code checking for "if (!status) " is
confusing and this bad style is what lead to bug #2.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>

2014-11-18 08:47:44 -06:00

..

function

usb: gadget: f_hid: fix error handling in ghid_setup()

2014-11-18 08:47:44 -06:00

legacy

usb: gadget: midi: f_midi_alloc() can be static

2014-11-12 09:01:03 -06:00

udc

usb: gadget: Add UDC driver for Broadcom USB3.0 device controller IP BDC

2014-11-18 08:47:23 -06:00

composite.c

usb: gadget: configfs: add suspend/resume

2014-11-03 10:00:59 -06:00

config.c

usb: gadget: always update HS/SS descriptors and create a copy of them

2012-10-31 15:09:44 +02:00

configfs.c

usb: gadget: udc: core: prepend udc_attach_driver with usb_

2014-11-03 10:01:16 -06:00

configfs.h

usb: gadget: OS descriptors: provide interface directory names

2014-06-19 10:06:48 -05:00

epautoconf.c

usb: delete non-required instances of include <linux/init.h>

2014-01-08 15:01:39 -08:00

functions.c

usb: gadget: add a forward pointer from usb_function to its "instance"

2013-01-21 20:52:46 +02:00

Kconfig

usb: gadget: hid: add configfs support

2014-11-06 16:18:19 -06:00

Makefile

usb: gadget: use $(srctree) instead of $(PWD) for includes

2014-08-29 15:53:46 -05:00

u_f.c

usb: gadget: only GPL drivers in the gadget and phy framework

2014-04-21 14:07:12 -05:00

u_f.h

usb: gadget: FunctionFS: share VLA macros with all usb gadget files

2014-05-14 09:37:27 -05:00

u_os_desc.h

usb: gadget: u_os_desc: helper functions for accessing ext prop buffer

2014-07-10 08:36:51 -05:00

usbstring.c

usb: delete non-required instances of include <linux/init.h>

2014-01-08 15:01:39 -08:00