Ard Biesheuvel 9246fd26f9 crypto: arm/aes-ctr - fix NULL dereference in tail processing
commit f82e90b28654804ab72881d577d87c3d5c65e2bc upstream.

The AES-CTR glue code avoids calling into the blkcipher API for the
tail portion of the walk, by comparing the remainder of walk.nbytes
modulo AES_BLOCK_SIZE with the residual nbytes, and jumping straight
into the tail processing block if they are equal. This tail processing
block checks whether nbytes != 0, and does nothing otherwise.

However, in case of an allocation failure in the blkcipher layer, we
may enter this code with walk.nbytes == 0, while nbytes > 0. In this
case, we should not dereference the source and destination pointers,
since they may be NULL. So instead of checking for nbytes != 0, check
for (walk.nbytes % AES_BLOCK_SIZE) != 0, which implies the former in
non-error conditions.

Fixes: 86464859cc77 ("crypto: arm - AES in ECB/CBC/CTR/XTS modes using ARMv8 Crypto Extensions")
Reported-by: xiakaixu <xiakaixu@huawei.com>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-09-30 10:18:34 +02:00
..
2016-09-24 10:07:45 +02:00
2016-09-24 10:07:44 +02:00
2016-09-24 10:07:44 +02:00
2015-11-12 15:26:39 -08:00
2016-09-24 10:07:43 +02:00
2015-11-22 11:35:26 +01:00
2016-09-24 10:07:45 +02:00
2016-09-24 10:07:45 +02:00
2016-09-24 10:07:44 +02:00
2016-09-24 10:07:45 +02:00
2016-09-07 08:32:38 +02:00
2015-11-11 09:16:10 -08:00
2016-09-24 10:07:43 +02:00