Eric Dumazet
d0f95894fd
netlink: annotate data-races around sk->sk_err ...
syzbot caught another data-race in netlink when
setting sk->sk_err.
Annotate all of them for good measure.
BUG: KCSAN: data-race in netlink_recvmsg / netlink_recvmsg
write to 0xffff8881613bb220 of 4 bytes by task 28147 on cpu 0:
netlink_recvmsg+0x448/0x780 net/netlink/af_netlink.c:1994
sock_recvmsg_nosec net/socket.c:1027 [inline]
sock_recvmsg net/socket.c:1049 [inline]
__sys_recvfrom+0x1f4/0x2e0 net/socket.c:2229
__do_sys_recvfrom net/socket.c:2247 [inline]
__se_sys_recvfrom net/socket.c:2243 [inline]
__x64_sys_recvfrom+0x78/0x90 net/socket.c:2243
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
write to 0xffff8881613bb220 of 4 bytes by task 28146 on cpu 1:
netlink_recvmsg+0x448/0x780 net/netlink/af_netlink.c:1994
sock_recvmsg_nosec net/socket.c:1027 [inline]
sock_recvmsg net/socket.c:1049 [inline]
__sys_recvfrom+0x1f4/0x2e0 net/socket.c:2229
__do_sys_recvfrom net/socket.c:2247 [inline]
__se_sys_recvfrom net/socket.c:2243 [inline]
__x64_sys_recvfrom+0x78/0x90 net/socket.c:2243
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
value changed: 0x00000000 -> 0x00000016
Reported by Kernel Concurrency Sanitizer on:
CPU: 1 PID: 28146 Comm: syz-executor.0 Not tainted 6.6.0-rc3-syzkaller-00055-g9ed22ae6be81 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20231003183455.3410550-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2023-10-04 17:32:54 -07:00
2023-08-09 15:32:43 -07:00
2023-08-18 12:44:56 -07:00
2023-06-24 15:50:13 -07:00
2023-06-24 15:50:13 -07:00
2023-09-18 12:56:58 +01:00
2023-08-24 10:51:39 -07:00
2023-09-20 11:03:11 -07:00
2023-08-30 08:36:17 +02:00
2023-05-31 13:06:57 +02:00
2023-10-01 17:14:37 +01:00
2023-06-24 15:50:13 -07:00
2023-09-01 07:27:33 +01:00
2023-08-24 11:24:37 +02:00
2023-10-04 08:28:07 -07:00
2023-08-01 21:07:46 -07:00
2023-09-18 07:10:31 +01:00
2023-08-28 08:02:24 -07:00
2023-08-09 13:08:09 -07:00
2023-10-03 07:18:58 -07:00
2023-09-20 11:54:49 +01:00
2023-09-18 08:26:19 +01:00
2023-08-29 17:39:15 -07:00
2023-10-04 15:34:18 -07:00
2023-10-03 09:49:24 +02:00
2023-09-14 10:43:51 +02:00
2023-08-18 12:44:56 -07:00
2023-10-01 18:19:27 +01:00
2023-08-09 15:34:28 -07:00
2023-09-26 09:12:47 +02:00
2023-06-24 15:41:46 -07:00
2023-06-24 15:50:13 -07:00
2023-08-15 15:26:18 -07:00
2023-09-18 12:47:56 +01:00
2023-09-18 07:06:05 +01:00
2023-10-04 15:57:28 +02:00
2023-08-02 12:28:22 -07:00
2023-10-04 17:32:54 -07:00
2023-08-28 06:58:46 +01:00
2023-10-03 07:39:31 -07:00
2023-06-10 00:11:41 -07:00
2023-08-18 12:44:56 -07:00
2023-08-10 14:10:53 -07:00
2023-06-24 15:50:13 -07:00
2023-07-17 09:02:30 +01:00
2023-10-01 19:31:29 +01:00
2023-09-18 09:36:57 +02:00
2023-06-24 15:50:13 -07:00
2023-06-28 16:43:10 -07:00
2023-09-05 08:54:12 +02:00
2023-10-04 17:29:58 -07:00
2023-09-10 19:31:42 +01:00
2023-09-13 11:51:11 -04:00
2023-07-21 08:54:03 +01:00
2023-10-04 13:24:12 -07:00
2023-09-12 09:51:49 +02:00
2023-09-07 18:33:07 -07:00
2023-07-31 14:41:08 -07:00
2023-09-26 09:12:27 +02:00
2023-06-24 15:50:13 -07:00
2023-08-31 13:21:11 +02:00
2023-08-29 17:39:15 -07:00
2023-07-19 10:07:27 -07:00
2023-10-01 19:31:29 +01:00
2023-08-15 15:26:17 -07:00
d0f95894fd